From: Michael Trimarchi <michael@amarulasolutions.com>
To: Ye Li <ye.li@nxp.com>, Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>
Cc: u-boot@lists.denx.de,
Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
linux-amarula@amarulasolutions.com,
Anthony Brandon <anthony@amarulasolutions.com>
Subject: [RFC PATCH] imx8m: Drop env_get_location for imx8mn and imx8mp
Date: Thu, 18 Nov 2021 14:58:07 +0100 [thread overview]
Message-ID: <20211118135807.325871-1-michael@amarulasolutions.com> (raw)
This function defined for two architecture is not really clean
and can be generate problem when people add a new board
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
arch/arm/mach-imx/imx8m/soc.c | 42 -----------------------------------
1 file changed, 42 deletions(-)
diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
index e75d2fa255..83a515c973 100644
--- a/arch/arm/mach-imx/imx8m/soc.c
+++ b/arch/arm/mach-imx/imx8m/soc.c
@@ -1311,45 +1311,3 @@ void do_error(struct pt_regs *pt_regs, unsigned int esr)
}
#endif
#endif
-
-#if defined(CONFIG_IMX8MN) || defined(CONFIG_IMX8MP)
-enum env_location env_get_location(enum env_operation op, int prio)
-{
- enum boot_device dev = get_boot_device();
- enum env_location env_loc = ENVL_UNKNOWN;
-
- if (prio)
- return env_loc;
-
- switch (dev) {
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
- case QSPI_BOOT:
- env_loc = ENVL_SPI_FLASH;
- break;
-#endif
-#ifdef CONFIG_ENV_IS_IN_NAND
- case NAND_BOOT:
- env_loc = ENVL_NAND;
- break;
-#endif
-#ifdef CONFIG_ENV_IS_IN_MMC
- case SD1_BOOT:
- case SD2_BOOT:
- case SD3_BOOT:
- case MMC1_BOOT:
- case MMC2_BOOT:
- case MMC3_BOOT:
- env_loc = ENVL_MMC;
- break;
-#endif
- default:
-#if defined(CONFIG_ENV_IS_NOWHERE)
- env_loc = ENVL_NOWHERE;
-#endif
- break;
- }
-
- return env_loc;
-}
-
-#endif
--
2.25.1
next reply other threads:[~2021-11-18 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 13:58 Michael Trimarchi [this message]
2021-11-18 18:53 ` [RFC PATCH] imx8m: Drop env_get_location for imx8mn and imx8mp ZHIZHIKIN Andrey
2021-11-18 21:48 ` Michael Nazzareno Trimarchi
2021-11-19 12:57 ` ZHIZHIKIN Andrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118135807.325871-1-michael@amarulasolutions.com \
--to=michael@amarulasolutions.com \
--cc=anthony@amarulasolutions.com \
--cc=ariel.dalessandro@collabora.com \
--cc=festevam@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox