From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53903C433F5 for ; Thu, 18 Nov 2021 13:42:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B928461401 for ; Thu, 18 Nov 2021 13:42:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B928461401 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD4FC81918; Thu, 18 Nov 2021 14:42:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="LJrDbLK6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4A1F4811DE; Thu, 18 Nov 2021 14:42:42 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B5E282E88; Thu, 18 Nov 2021 14:42:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 4447461401; Thu, 18 Nov 2021 13:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637242956; bh=UQP9/PDuj0JpyfssyWrTOa80JwdUFAcad/FLol9A1Nw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LJrDbLK6jtwdk0uACj/WicOUqCo0X+US2Tmy3o4si5LTiNGfX8JqsUTmNb1R+q+lP 2ChWe8Z402NM6g7QUtZZkVXZaGB33qjQvktx4ESUvdX/QVO21sZ6gOCDThnc59Xs83 sWBk39nQIiqCjp4IKzIMSkMgpBggog9NlQ6K2kS19/M6HL0T1qEnlxbTiy5/hLbThm hmuW3bOJpq7Kr/14IcyRRpwVWuLdM+K5aWydepGHaLKwCS0eSfsq3N9O7UOPkiQW/A jgY0AvX/qRpiHyF0k6SgGuVreRLlySACg280sBriMCPPJ1CA2BR4w0xba+wq4M4MdG 7/rPHNv1NdqYA== Date: Thu, 18 Nov 2021 14:42:19 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Masami Hiramatsu Cc: Simon Glass , u-boot-board-maintainers@lists.denx.de, u-boot-custodians@lists.denx.de, Tom Rini , u-boot@lists.denx.de, Joe Hershberger , Wolfgang Denk , Marek =?UTF-8?B?QmVow7pu?= , ilias.apalodimas@linaro.org, Kazuhiko Sakamoto Subject: Re: [PATCH] Revert "board: synquacer: developerbox: Don't set gd->env_addr to default_environment" Message-ID: <20211118144219.6fa2032e@thinkpad> In-Reply-To: <163721432461.467760.11657628315867225456.stgit@localhost> References: <163721432461.467760.11657628315867225456.stgit@localhost> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 18 Nov 2021 14:45:25 +0900 Masami Hiramatsu wrote: > Without default setting of gd->env_addr, U-Boot will cause > a synchronous abort if the env-variables on the SPI flash is > broken or not saved corectly. Set gd->env_addr correctly. >=20 > This reverts commit 535870f3b0fb09ee9b2885409f05304111464643. >=20 > Signed-off-by: Masami Hiramatsu > --- > board/socionext/developerbox/developerbox.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/board/socionext/developerbox/developerbox.c b/board/socionex= t/developerbox/developerbox.c > index 31b1349514..9552bfcdc3 100644 > --- a/board/socionext/developerbox/developerbox.c > +++ b/board/socionext/developerbox/developerbox.c > @@ -82,6 +82,8 @@ int board_init(void) > { > gd->bd->bi_boot_params =3D CONFIG_SYS_LOAD_ADDR + LOAD_OFFSET; > =20 > + gd->env_addr =3D (ulong)&default_environment[0]; > + > synquacer_setup_scbm_smmu(); > =20 > return 0; >=20 Reviewed-by: Marek Beh=C3=BAn I will look into this when I respin the default environment series. Marek