From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,
liuhao <liuhao@phytium.com.cn>, shuyiqi <shuyiqi@phytium.com.cn>,
Michal Simek <monstr@monstr.eu>,
u-boot@lists.denx.de
Subject: Re: [PATCH] pci: Add standard PCIe ECAM macros
Date: Thu, 18 Nov 2021 14:15:48 -0500 [thread overview]
Message-ID: <20211118191548.GP24579@bill-the-cat> (raw)
In-Reply-To: <20211103000105.20171-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Wed, Nov 03, 2021 at 01:01:05AM +0100, Pali Rohár wrote:
> Lot of PCIe controllers are using ECAM addressing. So add common ECAM
> macros into U-Boot's pci.h header file which can be suitable for most
> PCI controller drivers.
>
> Replace custom ECAM address macros in every PCI controller driver by new
> ECAM macros from U-Boot's pci.h header file.
>
> Similar macros are defined also in Linux kernel. There is a small
> difference between Linux and these new U-Boot macros.
>
> U-Boot's PCIE_ECAM_OFFSET() takes device and function numbers in separate
> arguments. Linux's PCIE_ECAM_OFFSET() takes device and function numbers
> encoded in one argument. The reason is that U-Boot's PCI_DEVFN() macro is
> different than Linux's PCI_SLOT() macro. So having device and function
> numbers in separate arguments makes code more straightforward.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-11-18 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 0:01 [PATCH] pci: Add standard PCIe ECAM macros Pali Rohár
2021-11-04 6:51 ` Stefan Roese
2021-11-18 19:15 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118191548.GP24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=liuhao@phytium.com.cn \
--cc=monstr@monstr.eu \
--cc=pali@kernel.org \
--cc=shuyiqi@phytium.com.cn \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox