From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71015C433F5 for ; Tue, 30 Nov 2021 03:58:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8019283025; Tue, 30 Nov 2021 04:58:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rxCGKtQx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 79B118302A; Tue, 30 Nov 2021 04:58:48 +0100 (CET) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2365682F98 for ; Tue, 30 Nov 2021 04:58:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id 132so25307919qkj.11 for ; Mon, 29 Nov 2021 19:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w40K7BO7bDpvzNQNRxbzAbedB2Sv3bnNiATjwuwvR5w=; b=rxCGKtQx0HNMDqM7xshyKGvP+ksctjDl5VV7pMC8rplie5SGjDXd/91hy7lDWO3IOl 6f9niKHqiosmmAFxI4gW77RRuR/lbDMKOD7M3QL6hxGEPZmAeD8HgXAFONIE1R1ab+Rv h3EgFsNj0a2UopCFCz5zPLgViAimxZPRkPmZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w40K7BO7bDpvzNQNRxbzAbedB2Sv3bnNiATjwuwvR5w=; b=iA3BaR7LMP9yNaGz2DKzpGBSIWNUgApbCe4Jf4x/ZF4y7Q5qKnFzm0QcKmkCTZC1in uU0+DQnS2lYYjy91hTvNkCc2H3TGt83GoisNgg061IcheSCX525HjWaook9yBTUg9DiL 4cjoSu2JyPRsMPLH3t6eTNWhzJ7mSyNwRQZQinHgZB2r9wu+YOdOJYYe8nWZ6enClffY nEDxxR81jOZqYJhI9B/wjoqOnR3LOVLAND195W/aS6lRjpAElPwpf8gVNFEqk0/SCcrP 7EKChPBnKzB0TKYy/KKmAo4oYaHV8SukbURSKy/ZnrztJtr6qhmXfLPtIkiQ/KM6j1wr D0SQ== X-Gm-Message-State: AOAM531X9ZPqVsE7Ncactq6hUYlsqJn3nLE6XH/y8QOB5zGGfVAX8+Ew WGVv9oAAJ/jPVpjPSsxUl2nBsA== X-Google-Smtp-Source: ABdhPJzNZPYjZSoMqBqw5eUU9lGxH6i9kWGxaDrkeHvovrQbcpimGzv2ErqKBE4c3DAH6A0AqFpPtw== X-Received: by 2002:a05:620a:1a05:: with SMTP id bk5mr42674631qkb.2.1638244723879; Mon, 29 Nov 2021 19:58:43 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-edec-aa90-ebd5-017a.res6.spectrum.com. [2603:6081:7b01:cbda:edec:aa90:ebd5:17a]) by smtp.gmail.com with ESMTPSA id d9sm9734344qkn.131.2021.11.29.19.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 19:58:43 -0800 (PST) Date: Mon, 29 Nov 2021 22:58:41 -0500 From: Tom Rini To: Stefan =?iso-8859-1?Q?M=E4tje?= Cc: Jagan Teki , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] Fix wrong QSPI clock calculation for AM4372 Message-ID: <20211130035841.GV24579@bill-the-cat> References: <20211130000656.1837826-1-stefan.maetje@esd.eu> <20211130000656.1837826-2-stefan.maetje@esd.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ib+jMG/sLdQHPyB8" Content-Disposition: inline In-Reply-To: <20211130000656.1837826-2-stefan.maetje@esd.eu> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Ib+jMG/sLdQHPyB8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 30, 2021 at 01:06:56AM +0100, Stefan M=E4tje wrote: > On AM4372 the SPI_GCLK input gets its clock from the PRCM module which > divides the PER_CLKOUTM2 frequency (192MHz) by a fixed factor of 4. > See AM437x Reference Manual in section 27 QSPI >> 27.2 Integration. >=20 > The QSPI_FCLK therefore needs to take this factor into account and > becomes (192000000 / 4). >=20 > Signed-off-by: Stefan M=E4tje > --- > drivers/spi/ti_qspi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c > index 664b9cad79..bccdeeaf82 100644 > --- a/drivers/spi/ti_qspi.c > +++ b/drivers/spi/ti_qspi.c > @@ -25,7 +25,8 @@ DECLARE_GLOBAL_DATA_PTR; > =20 > /* ti qpsi register bit masks */ > #define QSPI_TIMEOUT 2000000 > -#define QSPI_FCLK 192000000 > +/* AM4372: QSPI gets SPI_GCLK from PRCM unit as PER_CLKOUTM2 divided by = 4. */ > +#define QSPI_FCLK (192000000 / 4) > #define QSPI_DRA7XX_FCLK 76800000 > #define QSPI_WLEN_MAX_BITS 128 > #define QSPI_WLEN_MAX_BYTES (QSPI_WLEN_MAX_BITS >> 3) How is this treated in the kernel? Thanks. --=20 Tom --Ib+jMG/sLdQHPyB8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGloW4ACgkQFHw5/5Y0 tyxscQv/Y/5djst8Bbwq43Lbwrp/WTDCCVy9IFqs8PyGDio+of270EwH5FdAz2Yq BdMRqm4Jv+BZh+oQ8oCXCAhWdXNHAH1m7NmfWiYba3Ep9bW0Nc4pouLsHE06PILk akVSPQPQMG7ZG+KDcNaxVz+9swXf/3wLFO+P7kalXliEycdtb0iZMKNFhrKnfaKi ElJeMQmnsN1Qhc2/xSbYjwUKLm1BySnbYaT1sm59YJGXg+7UieIlvY1gqXp1/ybZ pvVj7jciEC5aM77hm1LwUPuo+fI4k+y9T28hxwveHEP6Q2tMzZnGl5qEjTfru7vk h4+isIZIigON/D7Zcd4gDZbeJQLvyVfZqTdGC3TxxWjV9/Y06v+EP+mNfZK7+/uT m1r0/j4U0X/f9HnPLkwjajW5fOOuNxJOctZuDuFmoCklDAtxVsIZrRiv/nzPd78m o2yf7cN/502WQEwodQEHu+aGF1HWmh3FI1RJvAynwZ6ENHM5PDJK820O1AWP9hJl MyybHWuK =3ulM -----END PGP SIGNATURE----- --Ib+jMG/sLdQHPyB8--