From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39895C433EF for ; Fri, 10 Dec 2021 06:05:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E191882DA1; Fri, 10 Dec 2021 07:05:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 335E682DA1; Fri, 10 Dec 2021 07:05:44 +0100 (CET) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9BC0C82054 for ; Fri, 10 Dec 2021 07:05:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jamin_lin@aspeedtech.com Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1BA5eD5L075966; Fri, 10 Dec 2021 13:40:13 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (118.99.190.129) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 10 Dec 2021 14:05:17 +0800 Date: Fri, 10 Dec 2021 14:05:16 +0800 From: Jamin Lin To: Simon Glass CC: Alexandru Gagniuc , Philippe Reynes , Sean Anderson , Thomas Perrot , open list , Troy Lee , Steven Lee Subject: Re: [PATCH v2] rsa: adds rsa3072 algorithm Message-ID: <20211210060515.GA16602@aspeedtech.com> References: <20211209035715.5733-1-jamin_lin@aspeedtech.com> <20211209035715.5733-2-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [118.99.190.129] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1BA5eD5L075966 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The 12/10/2021 00:15, Simon Glass wrote: > Hi Jamin, > > On Wed, 8 Dec 2021 at 20:57, Jamin Lin wrote: > > > > Add to support rsa 30272 bits algorithm in tools > > 3072 > Will fix > > for image sign at host side and adds rsa 3027 bits > > 3072 ? > Will fix > > verification in the image binary. > > > > Signed-off-by: Jamin Lin > > wq > > --- > > include/u-boot/rsa.h | 1 + > > lib/rsa/rsa-verify.c | 6 ++++++ > > tools/image-sig-host.c | 7 +++++++ > > 3 files changed, 14 insertions(+) > > Please can you update the vboot tes to add a test for this? > > Regards, > Simon Will add Hi Simon Thanks for your suggestion. I fixed typo and added test case in vboot for rsa3072 testing. V3 patch is waiting for your review. Thanks