From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11A00C433F5 for ; Tue, 14 Dec 2021 11:10:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5FD2F804C8; Tue, 14 Dec 2021 12:10:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="UyltijQ9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E29BA80FF4; Tue, 14 Dec 2021 12:10:38 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 171FE80394 for ; Tue, 14 Dec 2021 12:10:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B39BD6146E; Tue, 14 Dec 2021 11:10:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 042BCC34600; Tue, 14 Dec 2021 11:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639480233; bh=c5wNQ9zbqUzU1HjjPluXCE3GtV865LLVj1Wlq1Oemio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UyltijQ9pkScX5dQUSbzvyNnMBjz3FbxM349h9/x/MVRxYH/vp7x3KJ+K9p2H7iqm CZwthOYiNewToj4c/8iR8NUKjJTndflyRV24DGr8QS67/XqgVPEBR0jOIBur2gqln6 9i7mkvElkIVmIvSIRVZT2bAFbGAQeXtfJzQJmdvyfW9qT2LWc/RaG+rmNzftF4fuad T9wq80yZvHEzH3Bobu14rP3is6mQ2PEsx1wQc8v1EomEdwATt15sJioBuD7fVnhaA7 mVgr5fblfjbnBDErO/jzq28doE7aqSPSY/o2wG/qelPxsCc9A8inYCOm7KQCw4ao7C zJlEVPF4Glv+A== Received: by pali.im (Postfix) id 35A00798; Tue, 14 Dec 2021 12:10:30 +0100 (CET) Date: Tue, 14 Dec 2021 12:10:30 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek =?utf-8?B?QmVow7pu?= Cc: Stefan Roese , u-boot@lists.denx.de, Marek =?utf-8?B?QmVow7pu?= Subject: Re: [PATCH u-boot-marvell v2 6/9] arm: mvebu: spl: Print srcaddr in error message Message-ID: <20211214111030.p44erpox4jicvykr@pali> References: <20211126143738.23830-1-kabel@kernel.org> <20211126143738.23830-7-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211126143738.23830-7-kabel@kernel.org> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Friday 26 November 2021 15:37:35 Marek Behún wrote: > From: Marek Behún > > Print the wrong srcaddr (spl_image->offset) in error message also for > SATA case. > > Signed-off-by: Marek Behún > --- > arch/arm/mach-mvebu/spl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c > index af9e45ac7a..8c8cbc833f 100644 > --- a/arch/arm/mach-mvebu/spl.c > +++ b/arch/arm/mach-mvebu/spl.c > @@ -190,7 +190,8 @@ int spl_parse_board_header(struct spl_image_info *spl_image, > */ > if (mhdr->blockid == IBR_HDR_SATA_ID) { > if (spl_image->offset < 1) { > - printf("ERROR: Wrong SATA srcaddr in kwbimage\n"); > + printf("ERROR: Wrong SATA srcaddr (%u) in kwbimage\n", Maybe change message to "ERROR: Wrong srcaddr (%u) in SATA kwbimage" for consistency with other newly added error messages in this patch series? > + spl_image->offset); > return -EINVAL; > } > spl_image->offset -= 1; > -- > 2.32.0 >