U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, "Pali Rohár" <pali@kernel.org>,
	"Marek Behún" <marek.behun@nic.cz>
Subject: [PATCH u-boot-marvell v3 1/9] arm: mvebu: Check that kwbimage offset and blocksize are valid
Date: Tue, 14 Dec 2021 14:22:14 +0100	[thread overview]
Message-ID: <20211214132222.21324-2-kabel@kernel.org> (raw)
In-Reply-To: <20211214132222.21324-1-kabel@kernel.org>

From: Pali Rohár <pali@kernel.org>

There are certain restrictions for kwbimage offset and blocksize.
Validate them.

Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
---
 arch/arm/mach-mvebu/spl.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
index 73c4b9af3e..a6ed4367dd 100644
--- a/arch/arm/mach-mvebu/spl.c
+++ b/arch/arm/mach-mvebu/spl.c
@@ -163,6 +163,18 @@ int spl_parse_board_header(struct spl_image_info *spl_image,
 		spl_image->offset *= 512;
 #endif
 
+	if (spl_image->offset % 4 != 0) {
+		printf("ERROR: Wrong srcaddr (%u) in kwbimage\n",
+		       spl_image->offset);
+		return -EINVAL;
+	}
+
+	if (mhdr->blocksize <= 4 || mhdr->blocksize % 4 != 0) {
+		printf("ERROR: Wrong blocksize (%u) in kwbimage\n",
+		       mhdr->blocksize);
+		return -EINVAL;
+	}
+
 	spl_image->size = mhdr->blocksize;
 	spl_image->entry_point = mhdr->execaddr;
 	spl_image->load_addr = mhdr->destaddr;
-- 
2.32.0


  reply	other threads:[~2021-12-14 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 13:22 [PATCH u-boot-marvell v3 0/9] More verifications for kwbimage in SPL Marek Behún
2021-12-14 13:22 ` Marek Behún [this message]
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 2/9] SPL: Add struct spl_boot_device parameter into spl_parse_board_header() Marek Behún
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 3/9] arm: mvebu: Check that kwbimage blockid matches boot mode Marek Behún
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 4/9] SPL: Add support for checking board / BootROM specific image types Marek Behún
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 5/9] arm: mvebu: Check for kwbimage data checksum Marek Behún
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 6/9] arm: mvebu: spl: Print srcaddr in error message Marek Behún
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 7/9] arm: mvebu: spl: Use preferred types u8/u16/u32 instead of uintN_t Marek Behún
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 8/9] arm: mvebu: spl: Use IS_ENABLED() instead of #ifdef where possible Marek Behún
2021-12-14 13:22 ` [PATCH u-boot-marvell v3 9/9] arm: mvebu: spl: Fix 100 column exceeds Marek Behún
2021-12-18  9:16 ` [PATCH u-boot-marvell v3 0/9] More verifications for kwbimage in SPL Stefan Roese
2022-01-13 14:30   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211214132222.21324-2-kabel@kernel.org \
    --to=kabel@kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox