From: "Marek Behún" <marek.behun@nic.cz>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, "Heiko Schocher" <hs@denx.de>,
"Samuel Holland" <samuel@sholland.org>,
"Baruch Siach" <baruch@tkos.co.il>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH] i2c: mvtwsi: Swab the register address if its size is > 1
Date: Sat, 18 Dec 2021 23:41:50 +0100 [thread overview]
Message-ID: <20211218234150.7d21f2aa@thinkpad> (raw)
In-Reply-To: <3542e49a-aedf-406c-8927-a47fff172f92@denx.de>
On Sat, 18 Dec 2021 14:42:51 +0100
Stefan Roese <sr@denx.de> wrote:
> Hi Heiko,
>
> On 11/18/21 09:18, Stefan Roese wrote:
> > Testing on Armada XP with an EEPROM using register address with size
> > of 2 has shown, that the register address bytes are sent to the I2C
> > EEPROM in the incorrect order. This patch swabs the address bytes so
> > that the correct address is transferred to the I2C device.
> >
> > BTW: This worked without any issues before migrating Armada XP to
> > DM I2C.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Samuel Holland <samuel@sholland.org>
> > Cc: Baruch Siach <baruch@tkos.co.il>
> > Cc: Pali Rohár <pali@kernel.org>
> > Cc: Marek Behún <marek.behun@nic.cz>
> > ---
> > It would be good if other users of this I2C driver could test this change
> > with e.g. I2C EEPROM devices using 2 bytes (or more) for addressing.
>
> Could you and other please take a look at this? Would be great, if this
> could be pulled in the next merge window.
Tested-by: Marek Behún <marek.behun@nic.cz>
next prev parent reply other threads:[~2021-12-18 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 8:18 [PATCH] i2c: mvtwsi: Swab the register address if its size is > 1 Stefan Roese
2021-12-18 13:42 ` Stefan Roese
2021-12-18 22:41 ` Marek Behún [this message]
2021-12-20 7:03 ` Heiko Schocher
2021-12-20 10:12 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211218234150.7d21f2aa@thinkpad \
--to=marek.behun@nic.cz \
--cc=baruch@tkos.co.il \
--cc=hs@denx.de \
--cc=pali@kernel.org \
--cc=samuel@sholland.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox