From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC032C433EF for ; Mon, 20 Dec 2021 02:38:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B766A810F3; Mon, 20 Dec 2021 03:38:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="UOmMxFvs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C8991810F3; Mon, 20 Dec 2021 03:38:22 +0100 (CET) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 59FE180FF2 for ; Mon, 20 Dec 2021 03:38:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x629.google.com with SMTP id z3so2156252plg.8 for ; Sun, 19 Dec 2021 18:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=xJ82hc21OnYI6cXxUA2URqHA5QNClCUsGXUbTf2EoAk=; b=UOmMxFvsgYJt9WO5exiDrEpp0tP5Lba2gGPG/z9Vrhn4nkJyyoHmzJaapq2F4yZBSk 7Z6JuKUAHGu6XgC1XsOsqnCTe7yh2iN5gQFnqXkmxTnmtIDwgOuzH37RXRNpvno3O/R3 UtP1g+STMnvnho7RQdPHVH7XI/OsWtSsAHuyHfFk6H+0rgKtE+Ys6tBDwthegGCS0lEZ egV+Wt3GI3HhInul/JCIOPq9YTMymUta+NvO+fSGohojUxvKu+47Uv+bO1GQ1TfW3A44 yRkWn9Cb7J7ZQnfLN02rfdr068mui4ui8L0xmPFs7irCiXsiWTArLOhpQNMWVak58/gt 3ulQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=xJ82hc21OnYI6cXxUA2URqHA5QNClCUsGXUbTf2EoAk=; b=EawcQLdBz5cH63UQeYW2HUXmESnRj15PHILYLiJA15MvZLim2W74XELequhlP5IFlQ C8Ct93Df937CN6tSptf12U0k4AYTTf71/hG425+4v6Q5QQEjbsaj+/mjHk1yHblPgsxO lqPDMdULTfytXFJsTdOw6/N3wLKVCEd3IwpnW9xsfFAC+I48rzq93eUAJzDnhWX7n9aO JkW9/vOK5R1wPNJ47S2yJOl55u+JBW7YU+xIJ2od0AkZSVv/gxTHNgWuEOE3zekmtrur hWUYT8jq7WAR1Lp7ymuPFO5lRWcneD6AzFn2vi3RGN9LxC0+eEI180IlA2uwShKMEO1D 385w== X-Gm-Message-State: AOAM530DCK+4+RhfxQlhzS6ODFS0ZKVIb2HH9eNOLPWrp3PBE0VInh3i leFh8HSz05icCH0N28gVZHdnLA== X-Google-Smtp-Source: ABdhPJwdRfsmZZTOavuL7418Qrrc0VThAu6yqOqBMCswia4t/wRu7tDhBR6J13AxAKbdf3j5m6C0YQ== X-Received: by 2002:a17:902:e892:b0:148:a77a:d312 with SMTP id w18-20020a170902e89200b00148a77ad312mr14636852plg.95.1639967897673; Sun, 19 Dec 2021 18:38:17 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:89bf:be4:468d:12c2]) by smtp.gmail.com with ESMTPSA id v22sm3310159pjg.47.2021.12.19.18.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Dec 2021 18:38:17 -0800 (PST) Date: Mon, 20 Dec 2021 11:38:12 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Heinrich Schuchardt , U-Boot Mailing List , Ilias Apalodimas , Christian Melki , Bin Meng , Tom Rini , Alexander Graf Subject: Re: [PATCH v5 21/28] efi: Support the efi command in the app Message-ID: <20211220023812.GB7671@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , U-Boot Mailing List , Ilias Apalodimas , Christian Melki , Bin Meng , Tom Rini , Alexander Graf References: <20211204155657.2913911-1-sjg@chromium.org> <20211204155657.2913911-15-sjg@chromium.org> <31befeb9-2678-8f56-4067-829f1fd6c2d3@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Dec 17, 2021 at 09:37:21AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Thu, 9 Dec 2021 at 13:27, Heinrich Schuchardt wrote: > > > > On 12/4/21 07:56, Simon Glass wrote: > > > At present the 'efi' command only works in the EFI payload. Update it to > > > work in the app too, so the memory map can be examined. > > > > cmd/efi.c seems to be duplicating function do_efi_show_memmap(). In a > > future patch we should try to move to using common code for commands efi > > and efidebug. > > Yes and that depends on EFI_LOADER. Perhaps one day we can have a > common helper for this, e.g. in lib/efi ? It will inevitably means that we should stick to *UEFI* interfaces (not EFI_LOADER's internal interfaces like efi_xxx_yyy()) to implement those commands, including most of efidebug subcommands. -Takahiro Akashi > Regards, > Simon