From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48426C433EF for ; Mon, 20 Dec 2021 17:01:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 744CD8345C; Mon, 20 Dec 2021 18:01:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 5E04983267; Mon, 20 Dec 2021 18:01:50 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 7834B83468 for ; Mon, 20 Dec 2021 18:01:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E786D6E; Mon, 20 Dec 2021 09:01:45 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 45F803F774; Mon, 20 Dec 2021 09:01:44 -0800 (PST) Date: Mon, 20 Dec 2021 17:01:41 +0000 From: Andre Przywara To: Simon Glass Cc: Jagan Teki , Tom Rini , u-boot@lists.denx.de, Samuel Holland , Jernej Skrabec , Chen-Yu Tsai , Maxime Ripard , Icenowy Zheng , linux-sunxi@lists.linux.dev Subject: Re: [PATCH] sunxi: add board documentation Message-ID: <20211220170141.21770084@donnerap.cambridge.arm.com> In-Reply-To: References: <20211213010322.10726-1-andre.przywara@arm.com> Organization: ARM X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 17 Dec 2021 09:37:08 -0700 Simon Glass wrote: Hi Simon, > On Sun, 12 Dec 2021 at 18:03, Andre Przywara wrote: > > > > Add some long overdue instructions for building and installing U-Boot on > > Allwinner SoC based boards. > > This describes the building process, including TF-A and crust, plus > > installation to SD card, eMMC and SPI flash, both from Linux and U-Boot > > itself. Also describe FEL booting. > > > > Signed-off-by: Andre Przywara > > --- > > Hi, > > > > please have a look whether this makes sense. Feel free to just try something, > > and point out ambiguities or missing bits. For missing topics, please > > send a follow-up patch ;-) > > > > Also this is quite long, shall this be split up in two (or more) files? > > > > This is what rst.ninjs.org made of it, if you prefer to read it formatted: > > https://paste.c-net.org/PleasantNeedy > > > > Cheers, > > Andre > > > > doc/board/allwinner/index.rst | 9 + > > doc/board/allwinner/sunxi.rst | 304 ++++++++++++++++++++++++++++++++++ > > 2 files changed, 313 insertions(+) > > create mode 100644 doc/board/allwinner/index.rst > > create mode 100644 doc/board/allwinner/sunxi.rst > > Reviewed-by: Simon Glass > > I agree that a follow-on patch to remove the duplicated files would be > helpful, but this patch is a big step forward on its own. Thanks! I will address the other comments ASAP. > It would be interesting to convert sunxi to use binman. But Samuel fixed that already, didn't he? Or is there anything left that binman should do? We even now use mkimage to generate the magic BROM SPL signature, and then let binman combine this with the FIT image into the final binary. Or am I missing something here? Or are you asking for patches that remove sunxi as the bad example from the existing documentation? ;-) Cheers, Andre