From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E1F4C433F5 for ; Tue, 21 Dec 2021 15:57:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 220FE83457; Tue, 21 Dec 2021 16:56:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="UlRltCJR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 380708371B; Tue, 21 Dec 2021 16:56:12 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CB062834A7 for ; Tue, 21 Dec 2021 16:55:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 786FFB81681; Tue, 21 Dec 2021 15:55:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C61EC36AE8; Tue, 21 Dec 2021 15:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640102148; bh=Xm1CN5g8sOoiKJbifQxKaCPdKSThKXew51qiAas/ubg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UlRltCJRCfnYV7RvNZ86Z9eozkl2qVslnO5SZ3gPbldZOiz51zOhFOTa2+1gyb1VW 9trW94B7YYQEPIbGkW5t99EiNDg/1nEx/vC5md4PHtBECoMUZiayzvdKjmS5bh6L+p 5RcKvf9yUWuFA9DsSwAvquvOkbobZE1YVNpSVhQHzpJtNttglussz6UvI+keSBb2wv Yr6I3/U0PnAcxPWAx4rY3XNBnw1uJaqbtgIAjYr1hm0rzHddGU0dJfN7kvX4wiRmpB ysWhZETPRZWGJSGkyGPVojpxBPTsMHCRU/dv5452p0lDByZYEErTBmzm9H1umOWgJt 4JLitcOF+vu6Q== Received: by pali.im (Postfix) id C99D8284E; Tue, 21 Dec 2021 16:55:47 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Stefan Roese , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Chris Packham Cc: u-boot@lists.denx.de Subject: [PATCH u-boot-marvell 10/16] tools: kwbimage: Add missing check for maximal value for DATA_DELAY Date: Tue, 21 Dec 2021 16:54:10 +0100 Message-Id: <20211221155416.8557-11-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20211221155416.8557-1-pali@kernel.org> References: <20211221155416.8557-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Data delay is stored as 8-bit number in kwbimage structure. Ensure the given value is at most 255. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- tools/kwbimage.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index 7759a5f94098..4b3b40ce24fb 100644 --- a/tools/kwbimage.c +++ b/tools/kwbimage.c @@ -1610,6 +1610,10 @@ static int image_create_config_parse_oneline(char *line, el->regdata_delay = REGISTER_SET_HDR_OPT_DELAY_SDRAM_SETUP; else el->regdata_delay = REGISTER_SET_HDR_OPT_DELAY_MS(strtoul(value1, NULL, 10)); + if (el->regdata_delay > 255) { + fprintf(stderr, "Maximal DATA_DELAY is 255\n"); + return -1; + } break; case IMAGE_CFG_BAUDRATE: el->baudrate = strtoul(value1, NULL, 10); -- 2.20.1