From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D3ECC433EF for ; Thu, 23 Dec 2021 21:49:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AE3E1831D7; Thu, 23 Dec 2021 22:49:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N0CJK/wy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 53A7983112; Thu, 23 Dec 2021 22:49:45 +0100 (CET) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 88F97831D7 for ; Thu, 23 Dec 2021 22:49:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x530.google.com with SMTP id m21so27544689edc.0 for ; Thu, 23 Dec 2021 13:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qRERpy2YALyj7Ou+P+gsD2oBL35SyRNKEDPcUuG1VeA=; b=N0CJK/wy4pANuEbL4D2TvRhUN7H4ymuM98w2YuvS63SSNUFjSXTYNeyumptE30Ysdy KcLJ4/AJSnbOHHdbvThj4pCYAt4sSG4zhwV1Dy6PvwAxndULkHPHLanCfYk9tvZDtMuB Z/Tkw/E85zySigzI6MEGinPmRzoMZ1vJxQm5onNcX4z60Ug4W4o73GkQbLTUlqyzJ2Mc JNbbKVjxf9bSVhIct32Fb/kswwx0NNG9Q9zYhqBxw/L+O6ye4jOXampR635IwZ3Z/1AQ I2HJDNVSskA9lY9EZeXefM8ilQk9wwwEtA1y+ZIH8PPbwoOfuBRcCgljabhXQNEZurtu QELQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qRERpy2YALyj7Ou+P+gsD2oBL35SyRNKEDPcUuG1VeA=; b=lUwpDBrwB9AnUQXDQPdlevWMptQjE+7wZ6szEuT0peQw9GUI7PifAsdyB9jut++JbK MpfI7RNddM0JDOQNJquygA4kZ8Wf4jqlo758sb5sQJ0pJH8zU05bHuv1J7OA+PW9Aj5K IKS0SrdTrTPvFgnO2td9HPEAsXaa62/STUfNIPadpEFfgZ5YBi5TrCFWAWzAMvFQxL7T OiCbVlNRV/sjq550NnZQ8guslgqP03TUjo11N+sWH1th5lw7ejaVed8tES8luqXorr7r 29Qd7J9AZrkHsjJh/aIuYkRW5Eqq5+Fb8/s2vcbBnnRVrDLyXuF31Xl5fYI107FhPaX8 azug== X-Gm-Message-State: AOAM5333H+hTX6LvogRCZazkaYLRxeNSCiZAgEoeKxUwAi9YkNxRP3jy gldtzunD3h926U24VqDAm9Q= X-Google-Smtp-Source: ABdhPJw9qdQtRWJ8ndXMnikLo9mT+75bnVmsWL42naMTT10aKZxVhmFuhS6MnBBF7GgezL4FyLbrFA== X-Received: by 2002:aa7:c04a:: with SMTP id k10mr3495816edo.308.1640296181182; Thu, 23 Dec 2021 13:49:41 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id lg17sm2045986ejb.194.2021.12.23.13.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 13:49:40 -0800 (PST) Date: Thu, 23 Dec 2021 22:49:38 +0100 From: Tommaso Merciai To: "Peng Fan (OSS)" Cc: "michael@amarulasolutions.com" , Stefano Babic , Fabio Estevam , dl-uboot-imx , Peng Fan , Ye Li , Simon Glass , Marek Vasut , Frieder Schrempf , Marek =?iso-8859-1?Q?Beh=FAn?= , "Ying-Chun Liu (PaulLiu)" , "u-boot@lists.denx.de" Subject: Re: [RFC PATCH v2 0/3] imx8m: move env_get_location for imx8mn and imx8mp at board level Message-ID: <20211223214938.GA7322@tom-desktop> References: <20211130201729.32728-1-tomm.merciai@gmail.com> <5000444e-19f1-c0ce-3a4a-afdc027e4e7d@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5000444e-19f1-c0ce-3a4a-afdc027e4e7d@oss.nxp.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Dec 19, 2021 at 10:11:44AM +0800, Peng Fan (OSS) wrote: > > > On 2021/12/1 4:17, Tommaso Merciai wrote: > > This series move env_get_location from soc to board level. As suggested > > by Michael make no sense to define an > > unique way for multiple board. One board can boot from emmc and having > > env on spi flash etc.. Anyways, this function is kept in both imx8mn > > and imx8mp evk boards instead of being completely dropped. > > (as suggested by Andrey ) > > If there are other i.MX8MN/P boards already uses the function, move > it to i.mx8mn/p_evk would break other boards. If i.MX8MN/P evk are > the other users, it should be ok to move the board code. Hi Peng, Maybe declare it as __weak in soc.c and ovverride it a board level can be a valid solution? Let me know. thanks. tommaso > > Regards, > Peng. > > > > > Tommaso Merciai (3): > > imx8m: drop env_get_location for imx8mn and imx8mp > > imx: imx8mn_evk: override env_get_location > > imx: imx8mp_evk: override env_get_location > > > > arch/arm/mach-imx/imx8m/soc.c | 39 ------------------------- > > board/freescale/imx8mn_evk/imx8mn_evk.c | 35 ++++++++++++++++++++++ > > board/freescale/imx8mp_evk/imx8mp_evk.c | 34 +++++++++++++++++++++ > > 3 files changed, 69 insertions(+), 39 deletions(-) > >