From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14819C433F5 for ; Sat, 1 Jan 2022 18:51:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2393E82FB5; Sat, 1 Jan 2022 19:51:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1641063113; bh=hpoY2/+InJE9rBJnHx6gKgqYNLTbhO/guMck9rUJyxw=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=jRzspE2zOxk9CTz+anb8fWrT2RExfw7XoufnoBy6b2oubXs3qOq0o0+XfhQd0Ft2A 5RCEBeXzp/VWOuaneEUGh35D1cB/qDfnGCyncoNlkaaLpOcw8rbgVqBbgyMRkBnSS/ KxXzXDSqq+MxmBZBEavY9LEAqvnu0uI+hBfQvt9EYqd9rZljYE5a/laQTn3alQVbHY 3I0IEr8zGvT3xx93m6ffihtk/s06gjPkiF7927IlW6+qvUPKf8s76H2fGOOLqdrqX9 PMWxvWUmLmQXNk+dIbXMrhHjkNdmEc3K4MC57uk5/ARhhtNXeBKG/GxpA+mKSm36r8 J6vw1ggEbkRXw== Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id EDE1981277; Sat, 1 Jan 2022 19:51:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1641063111; bh=hpoY2/+InJE9rBJnHx6gKgqYNLTbhO/guMck9rUJyxw=; h=From:To:Cc:Subject:Date:From; b=vOh5EQ4EOk5FbHsqlu96YIUADFlSz/N0qIlXA7XlK/fn+PYyinY8WwpZMtRpT8UsN /gfyu75lRCOCPJ6ibX128SgIn2Z0LFnHMVG3mHLl0F2WV+Srx+cQ2CL33RV65Jw5NF zaXm4aamHFuFzJCrLF0XgtFD2kBh/56MH9RFdSIH9+TUcmQUoP99gaeOTuhi3/yDE9 uygrPnVQI4vj5EWPuNhlDAYlwbMe8pebnYkGQhkRRLYe69RFoEBtwrRfcMMR2iyddb jMqoz7U8Wpgme0thO5El8iLltK/tchtPn6sdfyN+Wm9DnTz9kf8bE/rGgBdBlxU12o nGI1zDthwg6og== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Peng Fan , Simon Glass Subject: [PATCH] Revert "clk: Detect failure to set defaults" Date: Sat, 1 Jan 2022 19:51:39 +0100 Message-Id: <20220101185139.470786-1-marex@denx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This reverts commit 92f1e9a4b31c0bf0f4f61ab823a6a88657323646. The aforementioned patch causes massive breakage on all platforms which have 'assigned-clock' DT property in their DT which references any clock that are not supported by the platform clock driver. That can easily happen either in SPL, or because the clock driver is reduced. Currently it seems all iMX8M are affected and fail to boot altogether. Signed-off-by: Marek Vasut Cc: Peng Fan Cc: Simon Glass --- drivers/clk/clk-uclass.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index f2d26427543..094b1abf13c 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -846,17 +846,13 @@ void devm_clk_put(struct udevice *dev, struct clk *clk) int clk_uclass_post_probe(struct udevice *dev) { - int ret; - /* * when a clock provider is probed. Call clk_set_defaults() * also after the device is probed. This takes care of cases * where the DT is used to setup default parents and rates * using assigned-clocks */ - ret = clk_set_defaults(dev, CLK_DEFAULTS_POST); - if (ret) - return log_ret(ret); + clk_set_defaults(dev, CLK_DEFAULTS_POST); return 0; } -- 2.34.1