From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Peter Robinson <pbrobinson@gmail.com>,
Tom Rini <trini@konsulko.com>, Stefano Babic <sbabic@denx.de>,
Simon Glass <sjg@chromium.org>, Breno Lima <breno.lima@nxp.com>,
Francesco Montefoschi <francesco.montefoschi@udoo.org>,
U-Boot-Denx <u-boot@lists.denx.de>,
linux-fancy <linuxfancy@googlegroups.com>
Subject: Re: help on udoo_neo power up on mainline uboot
Date: Sun, 2 Jan 2022 18:14:54 +0100 [thread overview]
Message-ID: <20220102171454.GA6445@tom-desktop> (raw)
In-Reply-To: <CAOMZO5AGHX9HEbj-X3g0=bTFUZijyVQRqzik3_V76=vf9STTpg@mail.gmail.com>
On Sat, Jan 01, 2022 at 10:24:29PM -0300, Fabio Estevam wrote:
> Hi Tommaso,
>
> On Sat, Jan 1, 2022 at 8:22 PM Tommaso Merciai <tomm.merciai@gmail.com> wrote:
>
> > Hi Peter, Fabio,
> > What do you think about this solution:
> >
> > First create new static entry in gd:
> >
> > +++ b/include/asm-generic/global_data.h
> > @@ -459,6 +459,7 @@ struct global_data {
> > */
> > char *smbios_version;
> > #endif
> > + int board_cfg;
>
> No need to add this new 'board_cfg' field entry.
>
> Please use the existing 'board_type' field instead:
>
> #ifdef CONFIG_BOARD_TYPES
> /**
> * @board_type: board type
> *
> * If a U-Boot configuration supports multiple board types, the actual
> * board type may be stored in this field.
> */
> unsigned long board_type;
> #endif
>
> Please make sure to add CONFIG_BOARD_TYPES=y in the defconfig.
>
> > What do you think about this solution?
> > Let me know.
>
> I like your solution.
>
> The only suggestion is to use the existing 'gd->board_type' and then
> feel free to submit a formal patch.
>
> Thanks!
>
> Fabio Estevam
Hi Fabio,
I need to create a patch on top of your patch series that re-enable
boot from uSD. Your series is already merged? just repull from master?
If not, can you give me some reference of your branch?
Or, I just send a patch on top of you series applied locally?
Let me know.
Thanks,
Tommaso Merciai
next prev parent reply other threads:[~2022-01-02 17:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 16:52 help on udoo_neo power up on mainline uboot Tommaso Merciai
2021-12-28 19:17 ` Fabio Estevam
2021-12-28 21:49 ` Tommaso Merciai
2021-12-29 20:33 ` Tommaso Merciai
2021-12-29 20:51 ` Fabio Estevam
2021-12-29 21:06 ` Fabio Estevam
2021-12-29 21:14 ` Peter Robinson
2021-12-29 21:51 ` Fabio Estevam
2021-12-29 23:16 ` Peter Robinson
2021-12-29 23:21 ` Fabio Estevam
2021-12-29 22:08 ` Tommaso Merciai
2021-12-29 22:38 ` Fabio Estevam
2021-12-29 23:07 ` Fabio Estevam
2021-12-29 23:27 ` Tommaso Merciai
2021-12-30 14:08 ` Peter Robinson
2021-12-30 14:12 ` Fabio Estevam
2021-12-30 14:20 ` Peter Robinson
2022-01-01 23:22 ` Tommaso Merciai
2022-01-02 1:24 ` Fabio Estevam
2022-01-02 17:14 ` Tommaso Merciai [this message]
2022-01-02 17:36 ` Fabio Estevam
2022-01-02 18:29 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220102171454.GA6445@tom-desktop \
--to=tomm.merciai@gmail.com \
--cc=breno.lima@nxp.com \
--cc=festevam@gmail.com \
--cc=francesco.montefoschi@udoo.org \
--cc=linuxfancy@googlegroups.com \
--cc=pbrobinson@gmail.com \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox