From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A29AC433EF for ; Sun, 2 Jan 2022 17:15:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B83F83049; Sun, 2 Jan 2022 18:15:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ovuRvKIE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 889FB8309E; Sun, 2 Jan 2022 18:14:59 +0100 (CET) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 19D6583049 for ; Sun, 2 Jan 2022 18:14:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x52e.google.com with SMTP id j6so127533860edw.12 for ; Sun, 02 Jan 2022 09:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oqJZeqUsrBcx0YVGPuASW7mi5d6uKbowcoVyaIpxKiA=; b=ovuRvKIEXHeCq4T5Xe+/z3cpnuZyKnfaU8HM7KR0EfS1qJSdb1krkB5soVWXf28sv6 Ep3QUJGNpUuj/2CgRkus9dOMKkkjSbq8QmgH6Yg03hcM6qtuaAQIzeMO07HQ56yHVsoO RKZqKA0CU6Sxl4rPV+ffjeblO78UDm61X2ggPl/hr3Qom599GfeHxS5OOb2+f52f+mL+ MzwFbsu8qOwwSDOfUIRQ0fsAUqgq7RMIVfhCAfq3vEWC/V/zvlekwVw6AyuasMLYT/se ejimEYi9KBwVz9yXeQjQMHuue9fWxOtmXf8UfNtNYy4W2aG4CPSyFDC31PhXwejBq0ME HHTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oqJZeqUsrBcx0YVGPuASW7mi5d6uKbowcoVyaIpxKiA=; b=suuHcKMRzr8+nKqErkOZ/KcJ4TBNEwWldOx+N7LPAx1bkZ1dUGUtubxWQwJgSe4fz2 Gfchi9o5EnVMERu6aEYD0ndULo6j2ucbt4BjpMUEa3OlH0LiaSVfCN1+KBg0gYTfF5Uh NJ8yqvcETzqyGo4c5HRZZBcPjJ9bSP3VKK4dgQqk7ei6Jb8M8f3MRuVZbmgXqxuQvuiP yU84LocxBF2xs9s7d4piv7tKXt24h/j5LwiDW9OA4GBTL+2KuVXGFEQj7SWx8jRhqIx4 Zw8nCQEHmVUZKwNFyfWrJDp3Wd0/qdd/ohcnS+XYyGNF6uzYPR5/UHjNPTI2TLcxofDI 98vw== X-Gm-Message-State: AOAM533B0gz7qjk4XHLfd9WqFbf96YLgvuswr4T5EM8oFeIo0rdSvUJV 0SsPt1Jxu5EEEKZlCMFaf0M= X-Google-Smtp-Source: ABdhPJwvKHreReoZf1de9yxDNpl74PhSeftzgonv3Pm/mdNJox/E3yykxkR2n91lYHlj7FJHaxfhsQ== X-Received: by 2002:a17:906:4fc8:: with SMTP id i8mr34258500ejw.427.1641143696575; Sun, 02 Jan 2022 09:14:56 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id a3sm10119898ejd.16.2022.01.02.09.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 09:14:56 -0800 (PST) Date: Sun, 2 Jan 2022 18:14:54 +0100 From: Tommaso Merciai To: Fabio Estevam Cc: Peter Robinson , Tom Rini , Stefano Babic , Simon Glass , Breno Lima , Francesco Montefoschi , U-Boot-Denx , linux-fancy Subject: Re: help on udoo_neo power up on mainline uboot Message-ID: <20220102171454.GA6445@tom-desktop> References: <20211229203305.GA6524@tom-desktop> <20211229220824.GA15234@tom-desktop> <20220101232250.GA14454@tom-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Jan 01, 2022 at 10:24:29PM -0300, Fabio Estevam wrote: > Hi Tommaso, > > On Sat, Jan 1, 2022 at 8:22 PM Tommaso Merciai wrote: > > > Hi Peter, Fabio, > > What do you think about this solution: > > > > First create new static entry in gd: > > > > +++ b/include/asm-generic/global_data.h > > @@ -459,6 +459,7 @@ struct global_data { > > */ > > char *smbios_version; > > #endif > > + int board_cfg; > > No need to add this new 'board_cfg' field entry. > > Please use the existing 'board_type' field instead: > > #ifdef CONFIG_BOARD_TYPES > /** > * @board_type: board type > * > * If a U-Boot configuration supports multiple board types, the actual > * board type may be stored in this field. > */ > unsigned long board_type; > #endif > > Please make sure to add CONFIG_BOARD_TYPES=y in the defconfig. > > > What do you think about this solution? > > Let me know. > > I like your solution. > > The only suggestion is to use the existing 'gd->board_type' and then > feel free to submit a formal patch. > > Thanks! > > Fabio Estevam Hi Fabio, I need to create a patch on top of your patch series that re-enable boot from uSD. Your series is already merged? just repull from master? If not, can you give me some reference of your branch? Or, I just send a patch on top of you series applied locally? Let me know. Thanks, Tommaso Merciai