From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 310F8C433F5 for ; Sun, 2 Jan 2022 22:28:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53B2F82FB5; Sun, 2 Jan 2022 23:28:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IT0GBUte"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AC24A83049; Sun, 2 Jan 2022 23:28:29 +0100 (CET) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1691582F5E for ; Sun, 2 Jan 2022 23:28:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x52c.google.com with SMTP id b13so129359107edd.8 for ; Sun, 02 Jan 2022 14:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XnmagBXV2L6TfUCGO0ts0GUsCh5bmh+8ELzM/fsxAzQ=; b=IT0GBUteSwLL74ApOlcfqStDPvGPQhBW3IQ7SrzcOArPl0imrzzaXqKz1ccKbsioY6 gjHkFihLFsu1MuiGQxrGltcDiMWreM39qUEVhRPFe3OMu/y2sbXZkJeDIbSIaH0eT6Pe ERbfwjPhAMr9Q0jgeyqu4HY0hhyhDoy/uAT/Y5vLq3ka/bzlxCaQNndSy+CX1RLbPkzp zI52bT0Lu/9bTK66n602H7OEAMMDwtcnz5gdQAq1rcFY2O0FGUvczrcFUZKU2vj9DjtY uYIlu5iVs1oNi4wbP276TxhnMClAZeUwpF5YWoyYl7bkmP+VRYcYDQIORwxKvFKHhraI bA/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XnmagBXV2L6TfUCGO0ts0GUsCh5bmh+8ELzM/fsxAzQ=; b=V6+b1hkVlmhf89QVyjR4j5U1VJ15ZFZrBITEp4AlIkzBs5KoxLi5TvY2aXmQ1XcWkN DMHeRVa+qoSCz2IYwwA+WbXzBERQ797vJb7oz6PBtmDYKK8UlcNAnLY2kcRrPnPAoCVJ N+FA59AZpuOIjyZ3iq0VAvcNAArf2StBFmB8pGKoGlcGibiaRDNILMw+BUGrNZK4PcfX KIZMzbhXDQznB8rrNpPk5yxs1BcJ/WQtBbD/RgKILdB0dxY7dcdOBlg4K8LvD/wAYQxw Mm1rGDrdf9ddpImFSZYNEAuQb17Q1KJNkaLzvQAVoGgH6VT0+uFZZW+5zvu5cVFFtzMB t9qA== X-Gm-Message-State: AOAM533nhVmgo7YH4AsCauZ09WM2Kkn9KY3UXj7Uw2tuULmRnbRgXBsl a9DiwiUj5YiCgj5x5AYNRLs= X-Google-Smtp-Source: ABdhPJxB7q4mVAtkJxoa8kYKqernfH4FZKrB0I00/jJgQV52UyfuNKsopLrjo4ZJYVsVsrLtWP0lKQ== X-Received: by 2002:a05:6402:2793:: with SMTP id b19mr41208419ede.353.1641162506680; Sun, 02 Jan 2022 14:28:26 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id sb13sm10251857ejc.26.2022.01.02.14.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 14:28:25 -0800 (PST) Date: Sun, 2 Jan 2022 23:28:23 +0100 From: Tommaso Merciai To: Fabio Estevam Cc: linux-fancy , Breno Lima , Francesco Montefoschi , U-Boot-Denx , Peter Robinson Subject: Re: [PATCH] udoo_neo: fix udoo neo UNDEFINED Message-ID: <20220102222823.GA2694@tom-desktop> References: <20220102182717.36734-1-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Jan 02, 2022 at 04:28:35PM -0300, Fabio Estevam wrote: > Hi Tommaso, > > On Sun, Jan 2, 2022 at 3:27 PM Tommaso Merciai wrote: > > > > get_board_value function fails to get the right board configuration on > > second time that is call. This patch move get_board_value function at > > spl level, once is call, store the right configuration into gd static > > variable gd->board_type and fix the previous error. > > get_board_value is now call only one time. > > > > Signed-off-by: Tommaso Merciai > > I tested your patch on my udoo neo full, but it reports "BASIC" now: > > U-Boot SPL 2022.01-rc4-00031-gc5c4ced998e3-dirty (Jan 02 2022 - 16:22:05 -0300) > Trying to boot from MMC1 > > > U-Boot 2022.01-rc4-00031-gc5c4ced998e3-dirty (Jan 02 2022 - 16:22:05 -0300) > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > CPU: Extended Commercial temperature grade (-20C to 105C) at 59C > Reset cause: WDOG > Model: UDOO Neo Basic > Board: UDOO Neo BASIC > I2C: ready > DRAM: 1 GiB > > (The size is correctly detected as 'full' though') Hi Fabio, Thanks for your test. I'll investigate on the reason and let you know. Tommaso Merciai