From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-fancy <linuxfancy@googlegroups.com>,
Breno Lima <breno.lima@nxp.com>,
Francesco Montefoschi <francesco.montefoschi@udoo.org>,
U-Boot-Denx <u-boot@lists.denx.de>,
Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH] udoo_neo: fix udoo neo UNDEFINED
Date: Mon, 3 Jan 2022 00:59:34 +0100 [thread overview]
Message-ID: <20220102235934.GB2694@tom-desktop> (raw)
In-Reply-To: <CAOMZO5A4YdhzW2WY6_jkypiHVbxRQAaYzrJxFwXJVr+J6QbpPg@mail.gmail.com>
On Sun, Jan 02, 2022 at 04:28:35PM -0300, Fabio Estevam wrote:
> Hi Tommaso,
>
> On Sun, Jan 2, 2022 at 3:27 PM Tommaso Merciai <tomm.merciai@gmail.com> wrote:
> >
> > get_board_value function fails to get the right board configuration on
> > second time that is call. This patch move get_board_value function at
> > spl level, once is call, store the right configuration into gd static
> > variable gd->board_type and fix the previous error.
> > get_board_value is now call only one time.
> >
> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
>
> I tested your patch on my udoo neo full, but it reports "BASIC" now:
>
> U-Boot SPL 2022.01-rc4-00031-gc5c4ced998e3-dirty (Jan 02 2022 - 16:22:05 -0300)
> Trying to boot from MMC1
>
>
> U-Boot 2022.01-rc4-00031-gc5c4ced998e3-dirty (Jan 02 2022 - 16:22:05 -0300)
>
> CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz)
> CPU: Extended Commercial temperature grade (-20C to 105C) at 59C
> Reset cause: WDOG
> Model: UDOO Neo Basic
> Board: UDOO Neo BASIC
> I2C: ready
> DRAM: 1 GiB
>
> (The size is correctly detected as 'full' though')
Hi Fabio,
Sent v2, I think this issue is fixed. Can you test it please.
The ploblem is that after spl, gd->board_type is re-initialized.
Using get_board_value inside board_early_init_f seems solve.
Let me know.
Thanks,
Tommaso Merciai
prev parent reply other threads:[~2022-01-02 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 18:27 [PATCH] udoo_neo: fix udoo neo UNDEFINED Tommaso Merciai
2022-01-02 19:28 ` Fabio Estevam
2022-01-02 22:28 ` Tommaso Merciai
2022-01-02 23:59 ` Tommaso Merciai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220102235934.GB2694@tom-desktop \
--to=tomm.merciai@gmail.com \
--cc=breno.lima@nxp.com \
--cc=festevam@gmail.com \
--cc=francesco.montefoschi@udoo.org \
--cc=linuxfancy@googlegroups.com \
--cc=pbrobinson@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox