From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9BE3C433F5 for ; Sun, 2 Jan 2022 23:59:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 371A782F5E; Mon, 3 Jan 2022 00:59:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SW0aWv69"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 48FFC82FB5; Mon, 3 Jan 2022 00:59:40 +0100 (CET) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AAA9C81420 for ; Mon, 3 Jan 2022 00:59:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x530.google.com with SMTP id b13so129779493edd.8 for ; Sun, 02 Jan 2022 15:59:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=T2bdnFlfrYVYIRpxHXX4w//SYwUHpFizBU051ZIQPb0=; b=SW0aWv69j4buhbtjGxtIx/Ld7leCUbOMfE3zCX8QbZmtKTUDBNhaHjmNrDlYFh0lmz WD7MDN1Fx9QhcjHALg1/BR8xh3crM41MysnuPxKIOBoJvK8zQtbPm8BASeNcnFy0LFhY 4TkDjRzkJQLVhdQ46hhaSRIcC43tAFzXsqHU4k3czlGcWGvdhVUqlbxIDQuJDJYHmzsV cghB98Fs/AYJFVEg5Z8KfOwJ99Hy9MdbYAEqzbaKkUk6DR/NRItpDQeFSbhJsmz7CyCd CbeqsnjBJaGk+sJ2GKBHOAjBSf7inz3lYtRujWVNIS3FkAajHcOjDtRV7Twwn/A/CH9m GN9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T2bdnFlfrYVYIRpxHXX4w//SYwUHpFizBU051ZIQPb0=; b=dMMCNboBfTiJ+NsPKp4rCy0LbDHy/kwMX40t3xLLvxESdMSFRr29J6FK9Mu6b4pjA4 WQAe2uwGCP6DU6JEqXjHzosPU/Nehsgukq5fM1IYTNaNX0ahXzhi5X5b+5YtufJ56vsK LdigA5c4AhbvWEoIogbT6RifJCpmUwytYQRsrYB4f43NQrW8lujEtlVubWb0WiJtGMaO cItw9GxCA8kS59rduOUlo9rkjckG0U/48tohzsLOW3Apu8IJ2e7nIRTULR8R164CAEyw +L3Pf9nNLydYc3Z32+QDCF6IH+aGb71twz4cB5/80On9BWsqN7rGCkx7B12Yn0ZKQR69 Y6GQ== X-Gm-Message-State: AOAM530hpzN5pyQ/XWXAKCIXf3RxlQAQf/rvkadcbnfPHu4uKHFK7Lo/ bCjO22gViajY/GmCZT0Xjrk= X-Google-Smtp-Source: ABdhPJyM3vNykKeBeVmjOcrlWi1INNVe0bt3sEdpbmk276b0RMiap6urHcmdiYh62Lel5T//JexJyA== X-Received: by 2002:a17:907:6d99:: with SMTP id sb25mr37227443ejc.540.1641167977371; Sun, 02 Jan 2022 15:59:37 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id v16sm13064883edc.4.2022.01.02.15.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 15:59:36 -0800 (PST) Date: Mon, 3 Jan 2022 00:59:34 +0100 From: Tommaso Merciai To: Fabio Estevam Cc: linux-fancy , Breno Lima , Francesco Montefoschi , U-Boot-Denx , Peter Robinson Subject: Re: [PATCH] udoo_neo: fix udoo neo UNDEFINED Message-ID: <20220102235934.GB2694@tom-desktop> References: <20220102182717.36734-1-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Jan 02, 2022 at 04:28:35PM -0300, Fabio Estevam wrote: > Hi Tommaso, > > On Sun, Jan 2, 2022 at 3:27 PM Tommaso Merciai wrote: > > > > get_board_value function fails to get the right board configuration on > > second time that is call. This patch move get_board_value function at > > spl level, once is call, store the right configuration into gd static > > variable gd->board_type and fix the previous error. > > get_board_value is now call only one time. > > > > Signed-off-by: Tommaso Merciai > > I tested your patch on my udoo neo full, but it reports "BASIC" now: > > U-Boot SPL 2022.01-rc4-00031-gc5c4ced998e3-dirty (Jan 02 2022 - 16:22:05 -0300) > Trying to boot from MMC1 > > > U-Boot 2022.01-rc4-00031-gc5c4ced998e3-dirty (Jan 02 2022 - 16:22:05 -0300) > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > CPU: Extended Commercial temperature grade (-20C to 105C) at 59C > Reset cause: WDOG > Model: UDOO Neo Basic > Board: UDOO Neo BASIC > I2C: ready > DRAM: 1 GiB > > (The size is correctly detected as 'full' though') Hi Fabio, Sent v2, I think this issue is fixed. Can you test it please. The ploblem is that after spl, gd->board_type is re-initialized. Using get_board_value inside board_early_init_f seems solve. Let me know. Thanks, Tommaso Merciai