public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: sbabic@denx.de
Cc: u-boot@lists.denx.de, pbrobinson@gmail.com,
	tomm.merciai@gmail.com, Fabio Estevam <festevam@gmail.com>
Subject: [PATCH 2/2] udoo: neo: Do not print the Model information
Date: Mon,  3 Jan 2022 12:15:12 -0300	[thread overview]
Message-ID: <20220103151512.435434-2-festevam@gmail.com> (raw)
In-Reply-To: <20220103151512.435434-1-festevam@gmail.com>

By default the Model information from DT is printed:

CPU:   Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz)
CPU:   Extended Commercial temperature grade (-20C to 105C) at 63C
Reset cause: POR
Model: UDOO Neo Basic
Board: UDOO Neo FULL
I2C:   ready

As the udoo basic DT is used, such output may be confusing.

Improve it by only printing the Board model instead, which is
read from the board identification GPIOs.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
This applies on top of Peter's series:
https://lore.kernel.org/all/20211221123249.455347-1-pbrobinson@gmail.com/T

 board/udoo/neo/neo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board/udoo/neo/neo.c b/board/udoo/neo/neo.c
index 0c0d3f615d18..da6a0b4e9247 100644
--- a/board/udoo/neo/neo.c
+++ b/board/udoo/neo/neo.c
@@ -350,7 +350,8 @@ static char *board_string(int type)
 	return "UNDEFINED";
 }
 
-int checkboard(void)
+/* Override the default implementation, DT model is not accurate */
+int show_board_info(void)
 {
 	int *board_type = (int *)OCRAM_START;
 
-- 
2.25.1


  reply	other threads:[~2022-01-03 15:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 15:15 [PATCH 1/2] udoo: neo: Fix the board model printing Fabio Estevam
2022-01-03 15:15 ` Fabio Estevam [this message]
2022-01-05 20:47   ` [PATCH 2/2] udoo: neo: Do not print the Model information Tommaso Merciai
2022-01-05 20:52     ` Fabio Estevam
2022-01-05 21:10       ` Tommaso Merciai
2022-01-08 18:55         ` Tommaso Merciai
2022-01-07 17:03   ` Tom Rini
2022-01-07 17:03 ` [PATCH 1/2] udoo: neo: Fix the board model printing Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220103151512.435434-2-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=pbrobinson@gmail.com \
    --cc=sbabic@denx.de \
    --cc=tomm.merciai@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox