From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54A48C433F5 for ; Wed, 5 Jan 2022 20:48:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F2CEC83769; Wed, 5 Jan 2022 21:48:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FfxJDmOO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2FB0C83762; Wed, 5 Jan 2022 21:48:02 +0100 (CET) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 13E4983769 for ; Wed, 5 Jan 2022 21:47:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-wm1-x332.google.com with SMTP id d198-20020a1c1dcf000000b0034569cdd2a2so114187wmd.5 for ; Wed, 05 Jan 2022 12:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GusvI2/vHAfqK8HWABzRah79oZTnX5QLQVGlQCU6IMs=; b=FfxJDmOOKC8WCfgsy1fkwNKf97brP1UqzChkqOienS7QKGREJgKQjI8wPoaQBhIMy3 1mW3T7V3q0eaje6Yr2ariXhVccNGFRkz6a116HqIJn70Lx9kgcvjdEmftQKT+UV6KQic JvRcUDQ008/AxboSnc0/uFAx0hI0gmJVeT6llL/YmZNz841ceCa8bCSw7TXrDkLGfqUR qShjPcSWcQAQOwomknhbsFzG+m6tf/5QOSv9crgMn/bfF7Ld2XAo2+OP+2NQ6luraGWQ h2uCEw/+W+gSIEcRMx/tY7gLSz9INAqsiZUfWhwhUW5UU0KYxvOzgI2fJzMNy6YodNir ayDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GusvI2/vHAfqK8HWABzRah79oZTnX5QLQVGlQCU6IMs=; b=kkOnEM4RA/lyn/MJHD6DEiOSgQfF+jnHBSgw5OxiF7qbZQU8rLxGMqZYvosL8ofkBl JUo2oic+WhAAv/T7DJqDSfM067MVCeD9lj7yz5sr8R7YID5Re53FDDQyfcqEydqLHbe0 uUpuPkGlVML5vtpSsrFd3hzvbS/SnTOL3+gFh2d3Td/DH7xkiahSQcpM6XXWKiTCF20r I4e5+qhWb0dRfHdm5FQ13KKXO/QEwI3rtv7W7gR/MLN/JElnV6pS1JlAki4n2lYU6/o5 v/ZSAQi5uqUgAEdMOwZwhtF6OdTXw4pYKK20BlPLnzaSonakrAvdcYO5rgpKThp1ezMA WucA== X-Gm-Message-State: AOAM533Cq0oZi0gmeyVCrKhVbPXOAuv28ec+0qQZF1BfGqBEwRYam734 lR3/BCf1AR/z3eel9akWnGXEIl2PQ+w= X-Google-Smtp-Source: ABdhPJwpdegHbJ+eoWdHxCwpZLvDrBMoijaqD6sKpy3uY9PtLBRiP6wU3EZ78EYNdJgHzMRvW+9TuQ== X-Received: by 2002:a05:600c:3787:: with SMTP id o7mr4406697wmr.41.1641415675451; Wed, 05 Jan 2022 12:47:55 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id l6sm74907wry.18.2022.01.05.12.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:47:54 -0800 (PST) Date: Wed, 5 Jan 2022 21:47:52 +0100 From: Tommaso Merciai To: Fabio Estevam Cc: sbabic@denx.de, u-boot@lists.denx.de, pbrobinson@gmail.com Subject: Re: [PATCH 2/2] udoo: neo: Do not print the Model information Message-ID: <20220105204752.GA2177@tom-desktop> References: <20220103151512.435434-1-festevam@gmail.com> <20220103151512.435434-2-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220103151512.435434-2-festevam@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Jan 03, 2022 at 12:15:12PM -0300, Fabio Estevam wrote: > By default the Model information from DT is printed: > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > CPU: Extended Commercial temperature grade (-20C to 105C) at 63C > Reset cause: POR > Model: UDOO Neo Basic > Board: UDOO Neo FULL > I2C: ready > > As the udoo basic DT is used, such output may be confusing. > > Improve it by only printing the Board model instead, which is > read from the board identification GPIOs. Hi Fabio, Thanks, I test your patch on basic and extended model. Below some logs seems all work properly. I hope I helped the cause :) - BASIC log: ------------------------------------------------------------------------- U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 21:38:32 +0100) CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 32C Reset cause: POR Model: UDOO Neo Basic Board: UDOO Neo BASIC I2C: ready DRAM: 512 MiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK In: serial Out: serial Err: serial Net: eth0: ethernet@2188000 [PRIME] Hit -------------------------------------------------------------------------- - EXTENDED LOG: -------------------------------------------------------------------------- U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 21:38:32 +0100) CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 42C Reset cause: POR Model: UDOO Neo Basic Board: UDOO Neo EXTENDED I2C: ready DRAM: 1 GiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK In: serial Out: serial Err: serial Net: Error: ethernet@2188000 address not set. No ethernet found. Hit any key to stop autoboot: 0 ---------------------------------------------------------------------------- Acked-by: Tommaso Merciai Tested-by: Tommaso Merciai Tommaso > > Signed-off-by: Fabio Estevam > --- > This applies on top of Peter's series: > https://lore.kernel.org/all/20211221123249.455347-1-pbrobinson@gmail.com/T > > board/udoo/neo/neo.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/board/udoo/neo/neo.c b/board/udoo/neo/neo.c > index 0c0d3f615d18..da6a0b4e9247 100644 > --- a/board/udoo/neo/neo.c > +++ b/board/udoo/neo/neo.c > @@ -350,7 +350,8 @@ static char *board_string(int type) > return "UNDEFINED"; > } > > -int checkboard(void) > +/* Override the default implementation, DT model is not accurate */ > +int show_board_info(void) > { > int *board_type = (int *)OCRAM_START; > > -- > 2.25.1 >