From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7BADC433F5 for ; Thu, 6 Jan 2022 09:20:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EABE18312A; Thu, 6 Jan 2022 10:20:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ey/b2AEJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD45A83146; Thu, 6 Jan 2022 10:20:15 +0100 (CET) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 645A08312A for ; Thu, 6 Jan 2022 10:20:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x102a.google.com with SMTP id 59-20020a17090a09c100b001b34a13745eso452683pjo.5 for ; Thu, 06 Jan 2022 01:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=XoPJccTkDkUtprNcsLWhZYWGVkeoG/qeFrpAVljXZ78=; b=ey/b2AEJhv3xG2+Vc8Uwxy2vQ8M1qf4ryH7s5vFpercf2QrCJAEu+U9uN+6yZ4fR6+ QC3bFivlDzsGPof7nFcKAh3TmU/qLdOX+BnpkGdUhovUiM8g98XFvTL8dCOjhqWhEfMp ANFXqnHaf9xDwBa65a1RHrrmm1+5osvZeHV62yyj6AU23C0VnMxRC7JgUvTOFb3srUyU WaVM+D79GWZ2dWooo7AI6S/bWuwv7QqQ0a3LMKojYhEVG3VxDiEvCGm885F6iFYkrpj0 W//pEZYDmOWC/VEif76RUcMQ2j6/WJMQjdOup7T+DMzAdAeKUHlMePkxSGS4JHz0aqcj Znow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=XoPJccTkDkUtprNcsLWhZYWGVkeoG/qeFrpAVljXZ78=; b=BmxB9EyspGTj8Giry7TMHZyaHxL5pBHfwzPG+rnM2vOYkOqm7DlxC7ubr+NbEdx9C+ QU1snS44DyqvnCoLnDv4yBIh9fnB6WMNku25NYxIHq2iEHwKs2ircJ6GzCH8S5259MED XviOOFg5FAIvF13I2htFjvm95V63iPrx3YlPKNby5Soap9H7SLq+yrn3pCClVFPMgrLD jtCUDmwO/PZNxwnYMPb2vRhhvtoJk/aGEuWKgGVe3JE/Y+NyFDf7DCXcwH4PZijE/81U EICUAjk+JEm0gjrzh7yip7hPa4f2VLS+qbJ/qDjIH6Ur1taYWi/P/GFltJGE5XILh4Jg Y1XA== X-Gm-Message-State: AOAM532c7dUN14ShbDVNDgAa34tR4xXTH644Y9Dhr0nVyxOIz1wdsaNq 6Cre7rl4bO6/vHZhRUMiCkb4eg== X-Google-Smtp-Source: ABdhPJzpgkzeJmF4e70WMLspwdH+OypYiQCoIeRrgeFpmukGVZ3Sf2Zyjayw8NKhYjGHVBjSS+2YvA== X-Received: by 2002:a17:902:9b90:b0:149:931b:44db with SMTP id y16-20020a1709029b9000b00149931b44dbmr38008596plp.117.1641460804957; Thu, 06 Jan 2022 01:20:04 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:9127:7a05:487c:d781]) by smtp.gmail.com with ESMTPSA id j17sm1827609pfu.77.2022.01.06.01.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 01:20:04 -0800 (PST) Date: Thu, 6 Jan 2022 18:20:00 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, mark.kettenis@xs4all.nl, u-boot@lists.denx.de, agraf@csgraf.de, sjg@chromium.org Subject: Re: [PATCH v8 02/12] tools: build mkeficapsule with tools-only_defconfig Message-ID: <20220106092000.GG45004@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, mark.kettenis@xs4all.nl, u-boot@lists.denx.de, agraf@csgraf.de, sjg@chromium.org References: <20211220050253.31163-1-takahiro.akashi@linaro.org> <20211220050253.31163-3-takahiro.akashi@linaro.org> <2acf4937-0f23-7c40-96a8-07f975a270bd@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2acf4937-0f23-7c40-96a8-07f975a270bd@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Jan 01, 2022 at 10:42:46PM +0100, Heinrich Schuchardt wrote: > On 12/20/21 06:02, AKASHI Takahiro wrote: > > Add CONFIG_TOOLS_MKEFICAPSULE. Then we want to always build mkeficapsule > > if tools-only_defconfig is used. > > > > Signed-off-by: AKASHI Takahiro > > --- > > configs/tools-only_defconfig | 1 + > > tools/Kconfig | 8 ++++++++ > > tools/Makefile | 3 +-- > > 3 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig > > index f482c9a1c1b0..5427797dd4c3 100644 > > --- a/configs/tools-only_defconfig > > +++ b/configs/tools-only_defconfig > > @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=y > > # CONFIG_VIRTIO_MMIO is not set > > # CONFIG_VIRTIO_PCI is not set > > # CONFIG_VIRTIO_SANDBOX is not set > > +CONFIG_TOOLS_MKEFICAPSULE=y > > diff --git a/tools/Kconfig b/tools/Kconfig > > index 91ce8ae3e516..117c921da3fe 100644 > > --- a/tools/Kconfig > > +++ b/tools/Kconfig > > @@ -90,4 +90,12 @@ config TOOLS_SHA512 > > help > > Enable SHA512 support in the tools builds > > > > +config TOOLS_MKEFICAPSULE > > + bool "Build efimkcapsule command" > > + default y if EFI_CAPSULE_ON_DISK > > We want to build mkeficapsule for tools-only_defconfig but your patch > fails to do so. This has been discussed before. Yes. I'm sure that tools-only_defconfig will build mkeficapsule even though we have "default y if EFI_CAPSULE_ON_DISK" since we have: > > +CONFIG_TOOLS_MKEFICAPSULE=y > Why should we only build mkeficapsule for EFI_CAPSULE_ON_DISK=y and not > for other instances of CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y? mkeficapsule deals with capsule files only which are supported under EFI_CAPSULE_ON_DISK. Please also note that, under the current implementation, UpdateCapsule() API is not officially supported. -Takahiro Akashi > Best regards > > Heinrich > > > + help > > + This command allows users to create a UEFI capsule file and, > > + optionally sign that file. If you want to enable UEFI capsule > > + update feature on your target, you certainly need this. > > + > > endmenu > > diff --git a/tools/Makefile b/tools/Makefile > > index 1763f44cac43..766c0674f4a0 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -238,8 +238,7 @@ hostprogs-$(CONFIG_MIPS) += mips-relocs > > hostprogs-$(CONFIG_ASN1_COMPILER) += asn1_compiler > > HOSTCFLAGS_asn1_compiler.o = -idirafter $(srctree)/include > > > > -mkeficapsule-objs := mkeficapsule.o $(LIBFDT_OBJS) > > -hostprogs-$(CONFIG_EFI_HAVE_CAPSULE_SUPPORT) += mkeficapsule > > +hostprogs-$(CONFIG_TOOLS_MKEFICAPSULE) += mkeficapsule > > > > # We build some files with extra pedantic flags to try to minimize things > > # that won't build on some weird host compiler -- though there are lots of >