From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5754C433EF for ; Fri, 7 Jan 2022 17:04:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 010108378D; Fri, 7 Jan 2022 18:03:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HXWpN9cf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C316B8378D; Fri, 7 Jan 2022 18:03:34 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 79DB183787 for ; Fri, 7 Jan 2022 18:03:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id p12so6008963qvj.6 for ; Fri, 07 Jan 2022 09:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Act19hyXAUV801b0wx063cjYzRU4+QcvQDVWT7qSkxQ=; b=HXWpN9cf/z1ynGqYAaIa1LSHCfXQhenE5SM6pcVjksonP+VyPZ1N2UjbAjjMrNMpK8 5SI1pAD7v/5omXxXJF1j79vi9TqzQ3Oh+lbUGQfFvttGWSQ98HkMLo2iMfvUwULmVXVR 9IJfaA5xBvadjrUbzj4o61sH2YeMWMzeIMJuU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Act19hyXAUV801b0wx063cjYzRU4+QcvQDVWT7qSkxQ=; b=2je8hZGgcjfpsdf+Tz4nqitUnd1MNmc0XOKkvEB1raZXXKWagL2xjMwy++qf9R5pIL PNZODPTrLdYjwgkNcq6Fu00J6qgsn706k8OHlmQHtKu31E6CXzjz8gFzF9atTC9/1hKy pZ7S3n1CI0YoF0lH5cAzLlnQReh7dk4DTXJjrgNVyErRoKUa+EVQxYg5iYa9m8yq6HgW cUARKz7Fmr8itI7+F7PNOce0pM9hgkwOg6N3oIM+WllIm67YiRivFNnCaVbo4YsmY4dw pf5zwT8BJ9JbRfrgPHLBD0T320I9DOX+JjAWOJg9iVJqEKOoWC6KPBh5mstJRkn+Ux9P znJA== X-Gm-Message-State: AOAM5326hTjrAT1fYq3+4RyImR1ZO2ZIU+YOPhGM5d7yLpWres5XKWXT tVyaisfycA5EoqzzxB2h3GfZKQ== X-Google-Smtp-Source: ABdhPJwGXorOZh3wwa/KP8HEq4b0egZHFlKEz7HxlOZ2Ipo+ASQB2S4DAD3bhHrKACqtjW7Rrho7uQ== X-Received: by 2002:a05:6214:508b:: with SMTP id kk11mr1755739qvb.61.1641575010351; Fri, 07 Jan 2022 09:03:30 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-f174-9b83-85b8-612f.res6.spectrum.com. [2603:6081:7b01:cbda:f174:9b83:85b8:612f]) by smtp.gmail.com with ESMTPSA id 82sm3489639qkd.77.2022.01.07.09.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 09:03:29 -0800 (PST) Date: Fri, 7 Jan 2022 12:03:28 -0500 From: Tom Rini To: Bin Meng Cc: Ilias Apalodimas , Simon Glass , Leo Yu-Chi Liang , Rick Chen , U-Boot Mailing List Subject: Re: [PATCH] riscv: sifive: Fix OF_BOARD boot failure Message-ID: <20220107170328.GU2773246@bill-the-cat> References: <20220105010757.750589-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kYjgnhhF68gsb/oS" Content-Disposition: inline In-Reply-To: <20220105010757.750589-1-bmeng.cn@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --kYjgnhhF68gsb/oS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 05, 2022 at 09:07:57AM +0800, Bin Meng wrote: > When using QEMU to have a quick test of booting U-Boot S-mode payload > directly without the needs of preparing the SPI flash or SD card images > for SiFive Unleashed board, as per the instructions [1], it currently > does not boot any more. >=20 > This was caused by the OF_PRIOR_STAGE removal, as gd->fdt_blob no longer > points to a valid DTB. OF_BOARD is supposed to replace OF_PRIOR_STAGE, > hence we need to add the OF_BOARD logic in board_fdt_blob_setup(). >=20 > [1] https://qemu.readthedocs.io/en/latest/system/riscv/sifive_u.html#runn= ing-u-boot >=20 > Fixes: 2e8d2f88439d ("riscv: Remove OF_PRIOR_STAGE from RISC-V boards") > Fixes: d6f8ab30a2af ("treewide: Remove OF_PRIOR_STAGE") > Signed-off-by: Bin Meng > Reviewed-by: Ilias Apalodimas > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --kYjgnhhF68gsb/oS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHYcl8ACgkQFHw5/5Y0 tyxd+Av8DAzs2ofBB2drTMQEotb/f+Ku4uXPKEHM7TfXsA1PajyR8WPR8CuZZ03F tyjjhniCHrv0AEQkQJDDrZMRkydEKFHTF99mJ+llfiiAdqwJn2Tevg72r4HvvVb9 va1jz+ExEbe0KAEAhNhPIoLKuV9+LD6P70Fft31mOeaPPNxGKfk0gKtNN3ju5Mec ePjazao4901mFiYJA3sspFZurZeZpy+A3X7i+dUyO7/v6BwtWt4XHb9g7/zP28NY mXkwBhW/nn6tif5AaB7aB1duSm4oWVTI0+0bTaAlGZNflhf5TtP78ajknlJIDTp6 Hx+qa16MY8+9GTtId+Z/+Q1o58VnG3AP8CmPjCwKNTrm/bke+eD6gSxm8Xd7lLJW TaVNmXTkQ5AwzLX9SB9tEqQNJrcNOUvprjsOqK1hwyzfpDSuivwcvJQbeo7NvwaE 8Gu2H6oX+L4jKvoinj5x1Gm+dal+oRRNF2H7WVfjne7/YecipdVvM/HyO3Snur6B PcdXkyDc =D9US -----END PGP SIGNATURE----- --kYjgnhhF68gsb/oS--