From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 107B9C433F5 for ; Sat, 8 Jan 2022 19:09:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5EDB880FAE; Sat, 8 Jan 2022 20:08:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cxFforW2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 01A5E82EBB; Sat, 8 Jan 2022 20:08:58 +0100 (CET) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DB92F80F3F for ; Sat, 8 Jan 2022 20:08:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x530.google.com with SMTP id b7so6814101edj.9 for ; Sat, 08 Jan 2022 11:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Il+rVqMR/LgT1DjCk+qVcd9keHeL+VILSyHtu0wR/aw=; b=cxFforW2C+maag2cfVylOchGGktB9BWQs9DIwnxcH2hYapnglV5QWQ7CzTLdSNsFIu bm8sNpcNShod3R1/Q6GpO/+9HBTgdiBJJcLCHWRffoXHHEhDxKYYUFb4cR7Z561dEJAW pPORCmT8xme6Bxy9iWmbl1Uxtw18sUlX2nEYZTSQb9oCT4jze5oCxOm2M9ZdQohL6Mku 7S1ZLsV/JIDMo6VJic0rEUWjPwDTPD+yL2FnntAg2SJdmBANQO1todQKpT6xiN2Hufly XHvg2wm70fQ+OL9e1g+p2OXx5SYKQIqWVH1dskGNROCRkh6rNVz4612mSW6jCrgMX1zD KA2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Il+rVqMR/LgT1DjCk+qVcd9keHeL+VILSyHtu0wR/aw=; b=N7AeN/iTnY+0w+D6zKFWY8vouq/ETnF+bkwDWLxL03xiRRX5sM74PiRhDbSgtJOO6u bpwTQLShnNuvmuct3Z6zeXOJ18o30SFTdXDM1zNpXfc0AOe/plA9ANBkeH6LTpOMbTTN 1RXIptF1SRt5cxe3WFKTPQaMev6pfb1TwhfatD1TYZdSR31rxrVViLt2GRbEh6M+DPob uJpgrogvo+LC0eQxn3iPxskT3/zjyVOWv5vcLxCFGI5bbc9YXIejyqT+purOT4AQGUHO aayBtxs9zx/OOmxudNhwcoxRqsXot31emRx7mQcPDyPSWVNHMnN+t5yyoE/dBSyIoBrf DaFw== X-Gm-Message-State: AOAM531J8eAX66IxGVOcyrwq6MFIYNOFEGNhrBwqhzkhg4jsvP7ykuoD lKn7NYAV17GOcM2us48m1AY= X-Google-Smtp-Source: ABdhPJxsHACcb+ZrfFILXCOmIZIz/lm6an+DCPisju98qJYzoBrhdXcf82bk6nDpuLnugGbiMyobIA== X-Received: by 2002:a17:906:254d:: with SMTP id j13mr4070541ejb.628.1641668934488; Sat, 08 Jan 2022 11:08:54 -0800 (PST) Received: from tom-desktop (net-93-71-218-227.cust.vodafonedsl.it. [93.71.218.227]) by smtp.gmail.com with ESMTPSA id 14sm719862ejk.215.2022.01.08.11.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 11:08:53 -0800 (PST) Date: Sat, 8 Jan 2022 20:08:51 +0100 From: Tommaso Merciai To: Teresa Remmet Cc: "ye.li@nxp.com" , "uboot-imx@nxp.com" , "festevam@gmail.com" , "peng.fan@nxp.com" , "michael@amarulasolutions.com" , "sbabic@denx.de" , "hws@denx.de" , "marex@denx.de" , "sjg@chromium.org" , "frieder.schrempf@kontron.de" , "u-boot@lists.denx.de" Subject: Re: [RFC PATCH v3 1/5] imx8m: drop env_get_location for imx8mn and imx8mp Message-ID: <20220108190851.GB2633@tom-desktop> References: <20211225202554.47853-1-tomm.merciai@gmail.com> <20211225202554.47853-2-tomm.merciai@gmail.com> <2f14182478aa4d2c0d0c03906beab1ee3483b4a6.camel@phytec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2f14182478aa4d2c0d0c03906beab1ee3483b4a6.camel@phytec.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Jan 04, 2022 at 11:04:10AM +0000, Teresa Remmet wrote: > Hello Tommaso, > > Am Samstag, dem 25.12.2021 um 21:25 +0100 schrieb Tommaso Merciai: > > This function defined for two architecture is not really generic > > and can generate problem when people add a new board. > > > > Signed-off-by: Tommaso Merciai > > --- > > arch/arm/mach-imx/imx8m/soc.c | 39 ------------------------------- > > ---- > > 1 file changed, 39 deletions(-) > > > > diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach- > > imx/imx8m/soc.c > > index 863508776d..f0030a557a 100644 > > --- a/arch/arm/mach-imx/imx8m/soc.c > > +++ b/arch/arm/mach-imx/imx8m/soc.c > > @@ -1313,45 +1313,6 @@ void do_error(struct pt_regs *pt_regs, > > unsigned int esr) > > #endif > > > > #if defined(CONFIG_IMX8MN) || defined(CONFIG_IMX8MP) > > -enum env_location env_get_location(enum env_operation op, int prio) > > -{ > > - enum boot_device dev = get_boot_device(); > > - enum env_location env_loc = ENVL_UNKNOWN; > > - > > - if (prio) > > - return env_loc; > > - > > - switch (dev) { > > -#ifdef CONFIG_ENV_IS_IN_SPI_FLASH > > - case QSPI_BOOT: > > - env_loc = ENVL_SPI_FLASH; > > - break; > > -#endif > > -#ifdef CONFIG_ENV_IS_IN_NAND > > - case NAND_BOOT: > > - env_loc = ENVL_NAND; > > - break; > > -#endif > > -#ifdef CONFIG_ENV_IS_IN_MMC > > - case SD1_BOOT: > > - case SD2_BOOT: > > - case SD3_BOOT: > > - case MMC1_BOOT: > > - case MMC2_BOOT: > > - case MMC3_BOOT: > > - env_loc = ENVL_MMC; > > - break; > > -#endif > > - default: > > -#if defined(CONFIG_ENV_IS_NOWHERE) > > - env_loc = ENVL_NOWHERE; > > -#endif > > - break; > > - } > > - > > - return env_loc; > > -} > > - > > #ifndef ENV_IS_EMBEDDED > > long long env_get_offset(long long defautl_offset) > > would it not make sense to move also env_get_offset() to board level? Hi Teresa, I think is better to put this function at board level. In this way others boards that use i.MX8MN/i.MX8MM SOC can customize env_get_location function. For example: maybe one user want store U-Boot env on a device other than the boot device. Tommaso > > Regards, > Teresa > > > > { > -- > PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany > > Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber | > Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE > 149059855