From: Stefan Eichenberger <eichest@gmail.com>
To: devel-sven@geroedel.de, mr.nuke.me@gmail.com, sjg@chromium.org
Cc: u-boot@lists.denx.de
Subject: [PATCH 1/2] tools/fitimage: remove redundant format check
Date: Mon, 10 Jan 2022 18:48:31 +0100 [thread overview]
Message-ID: <20220110174832.257300-2-eichest@gmail.com> (raw)
In-Reply-To: <20220110174832.257300-1-eichest@gmail.com>
fit_extract_contents does a fit_check_format even thought it was already
checked during imagetool_verify_print_header.
Therefore, this check is not necessary. This commit removes the
redundancy.
Signed-off-by: Stefan Eichenberger <eichest@gmail.com>
---
tools/fit_image.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/fit_image.c b/tools/fit_image.c
index f4f372ba62..62e1796ce5 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -884,11 +884,6 @@ static int fit_extract_contents(void *ptr, struct image_tool_params *params)
/* Indent string is defined in header image.h */
p = IMAGE_INDENT_STRING;
- if (fit_check_format(fit, IMAGE_SIZE_INVAL)) {
- printf("Bad FIT image format\n");
- return -1;
- }
-
/* Find images parent node offset */
images_noffset = fdt_path_offset(fit, FIT_IMAGES_PATH);
if (images_noffset < 0) {
--
2.32.0
next prev parent reply other threads:[~2022-01-10 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 17:48 [PATCH 0/2] fix dumpimage for fit images Stefan Eichenberger
2022-01-10 17:48 ` Stefan Eichenberger [this message]
2022-01-21 15:20 ` [PATCH 1/2] tools/fitimage: remove redundant format check Simon Glass
2022-01-24 16:53 ` Tom Rini
2022-01-10 17:48 ` [PATCH 2/2] tools/fitimage: make sure dumpimage still works when "@" are detected Stefan Eichenberger
2022-01-21 15:20 ` Simon Glass
2022-01-24 16:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220110174832.257300-2-eichest@gmail.com \
--to=eichest@gmail.com \
--cc=devel-sven@geroedel.de \
--cc=mr.nuke.me@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox