Re: [PATCH 2/2] board: starqltechn: get board usable - fix defconfig and strip config options

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

On Tue, Jan 11, 2022 at 07:01:59PM +0300, Dzmitry Sankouski wrote:

> - add FIT image support
> - increase LMB_MAX_REGIONS, to store all linux dtb reserved memory regions
> - add linux kernel image header
> 
> Uart driver causes hang, when u-boot is used in android boot image instead
> of linux. Temporary disable console driver, until investigated and fixed.
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  configs/starqltechn_defconfig | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/configs/starqltechn_defconfig b/configs/starqltechn_defconfig
> index f57bb859cc..987ce93a36 100644
> --- a/configs/starqltechn_defconfig
> +++ b/configs/starqltechn_defconfig
> @@ -2,13 +2,14 @@ CONFIG_ARM=y
>  CONFIG_SKIP_LOWLEVEL_INIT=y
>  CONFIG_POSITION_INDEPENDENT=y
>  CONFIG_ARCH_SNAPDRAGON=y
> -CONFIG_SYS_TEXT_BASE=0x80000000
> -CONFIG_SYS_MALLOC_LEN=0x81f000
>  CONFIG_DEFAULT_DEVICE_TREE="starqltechn"
> +CONFIG_BOOTDELAY=0
> +CONFIG_FIT=y
> +CONFIG_FIT_VERBOSE=y
>  CONFIG_TARGET_STARQLTECHN=y
>  CONFIG_IDENT_STRING="\nSamsung S9 SM-G9600"
>  CONFIG_SYS_LOAD_ADDR=0x80000000
> -CONFIG_USE_PREBOOT=y
> +CONFIG_LMB_MAX_REGIONS=64
>  # CONFIG_DISPLAY_CPUINFO is not set
>  CONFIG_HUSH_PARSER=y
>  CONFIG_CMD_GPIO=y
> @@ -20,5 +21,8 @@ CONFIG_PM8916_GPIO=y
>  CONFIG_PINCTRL=y
>  CONFIG_DM_PMIC=y
>  CONFIG_PMIC_PM8916=y
> -CONFIG_MSM_GENI_SERIAL=y
> +# todo: fix serial initialization hang, when assembled in android boot image.
> +CONFIG_REQUIRE_SERIAL_CONSOLE=n
> +CONFIG_MSM_GENI_SERIAL=n
>  CONFIG_SPMI_MSM=y
> +CONFIG_LINUX_KERNEL_IMAGE_HEADER=y

As the defconfig files are (re)generated by 'savedefconfig' that comment
will be lost quickly.  And it needs to be "# CONFIG_FOO is not set" as
well.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]