Re: [PATCH u-boot-marvell v2 13/20] arm: mvebu: Enable BootROM output on A38x

Stefan Roese
2022-01-13T06:42:51Z

On 1/12/22 18:20, Pali Rohár wrote:
> BootROMs on pre-A38x SoCs enabled its output on UART by default, but A38x'
> BootROM has its output on UART disabled by default.
>
> To enable BootROM output on A38x SoC, it is required to set DEBUG flag
> (which only enables BootROM output and nothing more) in kwbimage. For UART
> images this DEBUG flag is ignored by BootROM.
>
> Enable kwbimage DEBUG flag for all A38x boards.
>
> With this change BootROM prints the following (success) information on UART
> before booting U-Boot kwbimage:
>
> BootROM - 1.73
> Booting from SPI flash
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> arch/arm/mach-mvebu/Makefile | 7 +++++++
> arch/arm/mach-mvebu/kwbimage.cfg.in | 3 +++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index 9ace049c9d7c..74478a3134e3 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -69,6 +69,13 @@ KWB_REPLACE += SEC_FUSE_DUMP
> KWB_CFG_SEC_FUSE_DUMP = a38x
> endif
>
> +ifdef CONFIG_ARMADA_38X
> +# BootROM output is by default enabled on pre-A38x and disabled on A38x
> +# DEBUG flag on A38x for non-UART boot source only enable BootROM output and nothing more
> +KWB_REPLACE += DEBUG
> +KWB_CFG_DEBUG = 1
> +endif
> +
> quiet_cmd_kwbcfg = KWBCFG $@
> cmd_kwbcfg = sed -ne '$(foreach V,$(KWB_REPLACE),s/\#@$(V)/$(V) $(KWB_CFG_$(V))/;)p' \
> <$< >$(dir $@)$(@F)
> diff --git a/arch/arm/mach-mvebu/kwbimage.cfg.in b/arch/arm/mach-mvebu/kwbimage.cfg.in
> index 603e8863450c..ccb09975817e 100644
> --- a/arch/arm/mach-mvebu/kwbimage.cfg.in
> +++ b/arch/arm/mach-mvebu/kwbimage.cfg.in
> @@ -11,5 +11,8 @@ VERSION 1
> # Boot Media configurations
> #@BOOT_FROM
>
> +# Enable BootROM output via DEBUG flag on SoCs which require it
> +#@DEBUG
> +
> # Include U-Boot SPL with DDR3 training code into Binary Header
> BINARY spl/u-boot-spl.bin #@LOAD_ADDRESS
>

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de