Re: [PATCH v4 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

On Wed, Jan 12, 2022 at 06:47:38PM -0300, Fabio Estevam wrote:
> Hi Patrick,
> 
> On Sat, Jan 8, 2022 at 12:05 PM Patrick Wildt <patrick@blueri.se> wrote:
> >
> > The MNT Reform 2 is a modular DIY laptop.  In its initial version it
> > is based on the BoundaryDevices i.MX8MQ SoM.  Some parts have been
> > lifted from BoundaryDevices official U-Boot downstream project.
> >
> > Signed-off-by: Patrick Wildt <patrick@blueri.se>
> 
> Patch looks, only minor comments:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 
> > --- /dev/null
> > +++ b/arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +
> > +#include "imx8mq-u-boot.dtsi"
> > +
> > +&usdhc1 {
> > +       mmc-hs400-1_8v;
> > +};
> > +
> > +&usdhc2 {
> > +       cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> > +       sd-uhs-sdr104;
> > +       sd-uhs-ddr50;
> 
> It is Ok to put them in the u-boot.dtsi for now, but what about adding
> it to the mainline dts?
> 
> > +/* ENET1 */
> > +#if defined(CONFIG_CMD_NET)
> > +#define CONFIG_ETHPRIME                        "FEC"
> > +
> > +#define CONFIG_FEC_XCV_TYPE            RGMII
> > +#define CONFIG_FEC_MXC_PHYADDR         4
> > +#define FEC_QUIRK_ENET_MAC
> > +
> > +#define IMX_FEC_BASE                   0x30BE0000
> 
> Not needed with DM.
> 
> > +#define CONFIG_MXC_GPIO
> 
> This should be in Kconfig.

To be a little clearer here, CI now tests and fails if you have symbols
that are in Kconfig listed in your board.h file.  You can get CI run
automatically as explained here:
https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]