From: "Marek Behún" <marek.behun@nic.cz>
To: "Pali Rohár" <pali@kernel.org>
Cc: Stefan Roese <sr@denx.de>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Phil Sutter <phil@nwl.cc>, Dennis Gilmore <dgilmore@redhat.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH] arm: mvebu: Replace hardcoded values 0x0030/0x4030 by proper calculation
Date: Wed, 12 Jan 2022 23:27:06 +0100 [thread overview]
Message-ID: <20220112232706.2d4c538f@thinkpad> (raw)
In-Reply-To: <20220112173208.6555-1-pali@kernel.org>
On Wed, 12 Jan 2022 18:32:08 +0100
Pali Rohár <pali@kernel.org> wrote:
> These hardcoded values were calculated from CONFIG_SPL_TEXT_BASE macro. Now
> this macro is configurable via Kconfig, so calculate values 0x0030/0x4030
> at compile time via CONFIG_SPL_TEXT_BASE option. Values 0x0030/0x4030
> represents offset of CONFIG_SPL_TEXT_BASE from address 0x40000000.
Is there any point in having these configurable? Can the board boot if
the user changes it? If not, wouldn't it make more sense to convert
these to macros in soc.h, and changing their names?
Or does compilation need CONFIG_SPL_TEXT_BASE to link properly?
Marek
next prev parent reply other threads:[~2022-01-12 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 17:32 [PATCH] arm: mvebu: Replace hardcoded values 0x0030/0x4030 by proper calculation Pali Rohár
2022-01-12 22:27 ` Marek Behún [this message]
2022-01-12 22:31 ` Pali Rohár
2022-01-13 6:51 ` Stefan Roese
2022-01-13 10:49 ` Pali Rohár
2022-01-14 15:41 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112232706.2d4c538f@thinkpad \
--to=marek.behun@nic.cz \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=dgilmore@redhat.com \
--cc=pali@kernel.org \
--cc=phil@nwl.cc \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox