From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <u-boot-bounces@lists.denx.de>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from phobos.denx.de (phobos.denx.de [85.214.62.61])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 971F6C433EF
	for <u-boot@archiver.kernel.org>; Wed, 12 Jan 2022 22:27:15 +0000 (UTC)
Received: from h2850616.stratoserver.net (localhost [IPv6:::1])
	by phobos.denx.de (Postfix) with ESMTP id E1412832EC;
	Wed, 12 Jan 2022 23:27:12 +0100 (CET)
Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=nic.cz
Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de
Received: by phobos.denx.de (Postfix, from userid 109)
 id AF94783395; Wed, 12 Jan 2022 23:27:11 +0100 (CET)
Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by phobos.denx.de (Postfix) with ESMTPS id 1BC5A83248
 for <u-boot@lists.denx.de>; Wed, 12 Jan 2022 23:27:09 +0100 (CET)
Authentication-Results: phobos.denx.de;
 dmarc=pass (p=none dis=none) header.from=nic.cz
Authentication-Results: phobos.denx.de;
 spf=pass smtp.mailfrom=marek.behun@nic.cz
Received: from thinkpad (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680])
 by mail.nic.cz (Postfix) with ESMTPSA id 90F7F140BEF;
 Wed, 12 Jan 2022 23:27:08 +0100 (CET)
Date: Wed, 12 Jan 2022 23:27:06 +0100
From: Marek =?UTF-8?B?QmVow7pu?= <marek.behun@nic.cz>
To: Pali =?UTF-8?B?Um9ow6Fy?= <pali@kernel.org>
Cc: Stefan Roese <sr@denx.de>, Chris Packham
 <chris.packham@alliedtelesis.co.nz>, Phil Sutter <phil@nwl.cc>, Dennis
 Gilmore <dgilmore@redhat.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] arm: mvebu: Replace hardcoded values 0x0030/0x4030 by
 proper calculation
Message-ID: <20220112232706.2d4c538f@thinkpad>
In-Reply-To: <20220112173208.6555-1-pali@kernel.org>
References: <20220112173208.6555-1-pali@kernel.org>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: u-boot@lists.denx.de
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: U-Boot discussion <u-boot.lists.denx.de>
List-Unsubscribe: <https://lists.denx.de/options/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>
List-Archive: <https://lists.denx.de/pipermail/u-boot/>
List-Post: <mailto:u-boot@lists.denx.de>
List-Help: <mailto:u-boot-request@lists.denx.de?subject=help>
List-Subscribe: <https://lists.denx.de/listinfo/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=subscribe>
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de
X-Virus-Status: Clean

On Wed, 12 Jan 2022 18:32:08 +0100
Pali Roh=C3=A1r <pali@kernel.org> wrote:

> These hardcoded values were calculated from CONFIG_SPL_TEXT_BASE macro. N=
ow
> this macro is configurable via Kconfig, so calculate values 0x0030/0x4030
> at compile time via CONFIG_SPL_TEXT_BASE option. Values 0x0030/0x4030
> represents offset of CONFIG_SPL_TEXT_BASE from address 0x40000000.

Is there any point in having these configurable? Can the board boot if
the user changes it? If not, wouldn't it make more sense to convert
these to macros in soc.h, and changing their names?

Or does compilation need CONFIG_SPL_TEXT_BASE to link properly?

Marek