From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64BBCC433F5 for ; Thu, 13 Jan 2022 13:36:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ACBD083496; Thu, 13 Jan 2022 14:36:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="q82Q/dqk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BEBF083491; Thu, 13 Jan 2022 14:36:33 +0100 (CET) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C015983478 for ; Thu, 13 Jan 2022 14:36:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id c19so6840053qtx.3 for ; Thu, 13 Jan 2022 05:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PKttWYTah91+NigWgTY90S675Yxd92VoSPxPSLSj2XI=; b=q82Q/dqkESnBUNJjC10N3I5YLtxbCd5B5Sn9rW11X7dsgvC9252UA5JU+aR3e9YlZc b4XaziymTG5azz+Pj2MaPV5vemlnxg0XFFBj7pZAoH5i/XMvWKBrsA6yc6b6761h4WeN f8VLA84C9doULGSvnB1QT615iW8LEcwnbOaUg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PKttWYTah91+NigWgTY90S675Yxd92VoSPxPSLSj2XI=; b=Oj15l9Fq7VJ+YRYKqNZ9fZMibDhBSgfPMn4nU+vwibP1bxUm9X8ktnSrxvWSfVIND7 qBwwZ5jx+wnW9iOTZYUFotIVUWydwnONvooQllk5OBLiAVowglBF8HqnCYa+v49WzKFl BEuLrm6CoJ0tE2T1v9gollhJt50NlpmOQKumq7XrJYr5rnbisyyc93o3WkjScl7PwVsy xXQeNQ4usAcR/JIbN3XGY/2xomrBK39DZPZgy1iUU4ANANDBF544SvssHS1eSwB++6RF T8FWu88iaTwTp5IZov7katD1Xd0oVRa3/uG4KRPQCcQF0tdIpG/ESyZAYZ3Nac4Tez2M 1jqA== X-Gm-Message-State: AOAM5319lr8gZjOtG8kMsekU6p7u8dc0G33M0xyeJ5L6xY1EchizYmgo i6VpKAX3FqPseU6L1COID4Yjdg== X-Google-Smtp-Source: ABdhPJxnf+jqtMeYv6E3bq3s6ITq7WPnd7ZYOHLQoo5OCSdTqwnkw7dVJ4XjiW8/Psm+0NLgPSIgFQ== X-Received: by 2002:a05:622a:1ba4:: with SMTP id bp36mr3425310qtb.455.1642080989387; Thu, 13 Jan 2022 05:36:29 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2440-966a-5ce3-c6d0.res6.spectrum.com. [2603:6081:7b01:cbda:2440:966a:5ce3:c6d0]) by smtp.gmail.com with ESMTPSA id h9sm1852907qkp.106.2022.01.13.05.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 05:36:28 -0800 (PST) Date: Thu, 13 Jan 2022 08:36:27 -0500 From: Tom Rini To: Stefan Roese Cc: Tony Dinh , U-Boot Mailing List , Marek =?utf-8?B?QmVo77+9bg==?= , Pali =?utf-8?B?Um9o77+9cg==?= , David Purdy Subject: Re: [PATCH v2 4/8] arm: kirkwood: Pogoplug-V4 : Add board include configs file Message-ID: <20220113133627.GK9207@bill-the-cat> References: <20211223072649.13237-1-mibodhi@gmail.com> <20211223072649.13237-5-mibodhi@gmail.com> <8eb39c1f-9523-5017-af45-3d3bba07c443@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Vwmj/TXzE7NEH899" Content-Disposition: inline In-Reply-To: <8eb39c1f-9523-5017-af45-3d3bba07c443@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Vwmj/TXzE7NEH899 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 13, 2022 at 02:32:00PM +0100, Stefan Roese wrote: > On 12/23/21 08:26, Tony Dinh wrote: > > Add include configs file for Pogoplug V4 board > >=20 > > Signed-off-by: Tony Dinh > > --- > >=20 > > (no changes since v1) > >=20 > > include/configs/pogo_v4.h | 94 +++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 94 insertions(+) > > create mode 100644 include/configs/pogo_v4.h > >=20 > > diff --git a/include/configs/pogo_v4.h b/include/configs/pogo_v4.h > > new file mode 100644 > > index 0000000000..b449986e8c > > --- /dev/null > > +++ b/include/configs/pogo_v4.h > > @@ -0,0 +1,94 @@ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > +/* > > + * Copyright (C) 2014-2021 Tony Dinh > > + * > > + * Based on > > + * Copyright (C) 2012 > > + * David Purdy > > + * > > + * Based on Kirkwood support: > > + * (C) Copyright 2009 > > + * Marvell Semiconductor > > + * Written-by: Prafulla Wadaskar > > + */ > > + > > +#ifndef _CONFIG_POGO_V4_H > > +#define _CONFIG_POGO_V4_H > > + > > +/* > > + * Machine type definition and ID > > + */ > > +#define MACH_TYPE_POGO_V4 3960 > > +#define CONFIG_MACH_TYPE MACH_TYPE_POGO_V4 >=20 > Are you really using the pretty old CONFIG_MACH_TYPE to boot Linux > on this device? >=20 > > + > > +/* > > + * High Level Configuration Options (easy to change) > > + */ > > +#define CONFIG_FEROCEON_88FR131 /* #define CPU Core subversion */ > > +#define CONFIG_KW88F6192 /* SOC Name */ >=20 > At least CONFIG_FEROCEON_88FR131 is available in Kconfig > (arch/arm/mach-kirkwood/Kconfig), so there should be no need to add it > via some header. >=20 > Please double-check other macros in this header as well for availability > in Kconfig. At this point you can now make CI do this for you as we have a test that will fail if there's unmigrated symbols in your board header file. The logic can also be copy/pasted out to a script to run by yourself too. --=20 Tom --Vwmj/TXzE7NEH899 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHgKtQACgkQFHw5/5Y0 tyxFywwAsYQyc1s35M2VeHcA0yUkciZSqNGbmbm18PueYGMu7JZWja/3PlldzQsl TI8XYpg8IYm9iwf+Zvey4YkWfTX8gA8jFMnKax+8aR71vItopyZjMw4a8AhbevNB YSkj9jYULZ3XZOY2/VI+8vpShx7yWpm381SHmm2J/rvTVuUE/6xTB5uLwLUlpNwB lI+zWDNgYQTczeCiCloQ2DFYStD/LRjqhmIULPCOpjh/7gjuIWseRHXeSSiv5cT0 fwN9BMHxyferh3xvMhIug5w2YSULHaLqgeGvO3e/8ZK4FdMMhCmCtH6n5DGog2nc 4g5iybufui9YH4Y+017WhhIGJrFH5zm0qa4l5vjmbHDEz63UEyKQEDQFsiEy2pHP JGnfVV5jHbpUpkFGViRICXUIgYRVCgfqtrP2BWY+lHe/JX4yF2zUC6dyGL5aSYC9 sOYNQiMI0V80aywAey7krzZLcjrmyQFIabe1/WAwbmwqe/+W1fsCfCTYaupnbpjq wAU726nV =IQ1Y -----END PGP SIGNATURE----- --Vwmj/TXzE7NEH899--