From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5149DC433EF for ; Fri, 14 Jan 2022 01:41:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5CDF682DB7; Fri, 14 Jan 2022 02:41:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BfCc8sJM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4E83583260; Fri, 14 Jan 2022 02:41:24 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A98BD82A59 for ; Fri, 14 Jan 2022 02:41:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id q14so9296227qtx.10 for ; Thu, 13 Jan 2022 17:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z1FdBqahPamuCiq9QIrZRLwrDrCmlmA1tSnnGGrLMC4=; b=BfCc8sJMmixGVo6w0EQVaRa7rHi2/Y68C7l10THsYD+Uj9+TsP4rjbNdXVnwCoUl/I y6iixJxD/acwgNJNs1m27RyfhsuVayJFytTHeINB/QHNdh2vAB5Np+PuVyFbg2NHPQWv lja6D600cjnLNKJkpPY3c3gR26btSH4JbNsxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z1FdBqahPamuCiq9QIrZRLwrDrCmlmA1tSnnGGrLMC4=; b=JheeZb/tBpiv7R5oYpqY0rqZIsgm2yfYHu+gd42lH5BT2kQUma+yFd9Gjc+qG3xTo2 FpwXzT4Urt23e+k8MxXbfxGBefQQK6eaqBpB+FBZIiV7qWLHYJiClfRvTFd+mSrx3drE aNjAK3tySj18erJ8DHvZCQJABDj91V05BSqLlOY/U4bhaVpKj0qmBi4NR8UMIM9OHfya zmQMurYm7QJUPEW7JLcZig7rBuuEYnPCN2EAkYsWtQ4Yzkg8UfY+5ZDlQS5iXcnb2M1+ uyZ6GZEbtDIELKDLVwEsLAQYxyHJMs6bpz1XFCkuGTA1y/8zs0h7ILUR54b2hUChxhAD Iijg== X-Gm-Message-State: AOAM533J1uL0QmKFTqFCAbTWJw5BJWCw//BJPE6xa7lvH7JjQ9dDS2Sf Z4FQyWglBBpMXTMxEq3auhy9kg== X-Google-Smtp-Source: ABdhPJzeoDatEJ7lAA/tS+ZqpaUUtbTVXOe4k4fqvIVfhPxlOX9vz55VthOeDS4nsJEHCTZQQlDocQ== X-Received: by 2002:a05:622a:14c8:: with SMTP id u8mr5938255qtx.267.1642124479440; Thu, 13 Jan 2022 17:41:19 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-0df1-f022-9a85-fd94.res6.spectrum.com. [2603:6081:7b01:cbda:df1:f022:9a85:fd94]) by smtp.gmail.com with ESMTPSA id 2sm3240880qtx.66.2022.01.13.17.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 17:41:18 -0800 (PST) Date: Thu, 13 Jan 2022 20:41:16 -0500 From: Tom Rini To: Tony Dinh Cc: Stefan Roese , U-Boot Mailing List , Marek =?utf-8?B?QmVo77+9bg==?= , Pali =?utf-8?B?Um9o77+9cg==?= , David Purdy Subject: Re: [PATCH v2 4/8] arm: kirkwood: Pogoplug-V4 : Add board include configs file Message-ID: <20220114014116.GR9207@bill-the-cat> References: <20211223072649.13237-1-mibodhi@gmail.com> <20211223072649.13237-5-mibodhi@gmail.com> <8eb39c1f-9523-5017-af45-3d3bba07c443@denx.de> <20220113133627.GK9207@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FiNbsEwipjuZ/8Wl" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --FiNbsEwipjuZ/8Wl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 13, 2022 at 04:50:20PM -0800, Tony Dinh wrote: > Hi Tom, >=20 > On Thu, Jan 13, 2022 at 5:36 AM Tom Rini wrote: > > > > On Thu, Jan 13, 2022 at 02:32:00PM +0100, Stefan Roese wrote: > > > On 12/23/21 08:26, Tony Dinh wrote: > > > > Add include configs file for Pogoplug V4 board > > > > > > > > Signed-off-by: Tony Dinh > > > > --- > > > > > > > > (no changes since v1) > > > > > > > > include/configs/pogo_v4.h | 94 ++++++++++++++++++++++++++++++++++= +++++ > > > > 1 file changed, 94 insertions(+) > > > > create mode 100644 include/configs/pogo_v4.h > > > > > > > > diff --git a/include/configs/pogo_v4.h b/include/configs/pogo_v4.h > > > > new file mode 100644 > > > > index 0000000000..b449986e8c > > > > --- /dev/null > > > > +++ b/include/configs/pogo_v4.h > > > > @@ -0,0 +1,94 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > +/* > > > > + * Copyright (C) 2014-2021 Tony Dinh > > > > + * > > > > + * Based on > > > > + * Copyright (C) 2012 > > > > + * David Purdy > > > > + * > > > > + * Based on Kirkwood support: > > > > + * (C) Copyright 2009 > > > > + * Marvell Semiconductor > > > > + * Written-by: Prafulla Wadaskar > > > > + */ > > > > + > > > > +#ifndef _CONFIG_POGO_V4_H > > > > +#define _CONFIG_POGO_V4_H > > > > + > > > > +/* > > > > + * Machine type definition and ID > > > > + */ > > > > +#define MACH_TYPE_POGO_V4 3960 > > > > +#define CONFIG_MACH_TYPE MACH_TYPE_POGO_V4 > > > > > > Are you really using the pretty old CONFIG_MACH_TYPE to boot Linux > > > on this device? > > > > > > > + > > > > +/* > > > > + * High Level Configuration Options (easy to change) > > > > + */ > > > > +#define CONFIG_FEROCEON_88FR131 /* #define CPU Core sub= version */ > > > > +#define CONFIG_KW88F6192 /* SOC Name */ > > > > > > At least CONFIG_FEROCEON_88FR131 is available in Kconfig > > > (arch/arm/mach-kirkwood/Kconfig), so there should be no need to add it > > > via some header. > > > > > > Please double-check other macros in this header as well for availabil= ity > > > in Kconfig. > > > > At this point you can now make CI do this for you as we have a test that > > will fail if there's unmigrated symbols in your board header file. The > > logic can also be copy/pasted out to a script to run by yourself too. >=20 > I have not used CI before (not sure how). But I used a script copied > from your post: >=20 > https://lists.denx.de/pipermail/u-boot/2021-September/460085.html >=20 > ./check-migrated-symbols.sh include/configs/pogo_v4.h >=20 > That should be enough to see which ones to migrate, right? Yup, that'll do it. --=20 Tom --FiNbsEwipjuZ/8Wl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHg1LkACgkQFHw5/5Y0 tyxfMQwAjEPdWSzMucI62qv2KgUd/MEFLodloGdg+3W6ygw8So43zL/xNDgAHQS2 Mke3rBqbM1mWuVal/RIHarU6lNThBK+QxD6ZuUoSuLmwolqcOJRTHpo9sPfWUvl7 2T5pF5WAxc2xcV3yUf/ma5lsf8KBiwS/MyzGiM3rI61DYlrJrZAjQwv4pvNCBmUm wIN+iLVZkg36ua66RhNI2RAN1+eohak8T7PiuDFyF7ePnhJsnUKLSsAjEXqchJHk 7ZzNLSN29pwi9W3pMjWb9eI25mDvpRiBPAl/7UAs9up7wii6tMONh2tWXxppnbfW AJNpkGJjdLlpAGeyAiJos2iBQpSMSGjUuqYyg1HF08EB/ics9KAfirbEJiQoEzBe uRRFwT12ofTm+sQF0qQmpeNoI6lxXgiW7OV5iIY62lBlblfG1zQRekDa9WMkGUCI XBkbV/zhjwaqd0nrQKmX0OlI/lG4rR/1bKW+/LmhZOh1W/muTTsSMTe8T0mWAZ10 yQEYY45K =k0h/ -----END PGP SIGNATURE----- --FiNbsEwipjuZ/8Wl--