From: Tom Rini <trini@konsulko.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: u-boot@lists.denx.de, git@xilinx.com,
Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
Bin Meng <bmeng.cn@gmail.com>,
Franck LENORMAND <franck.lenormand@nxp.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Igor Opaniuk <igor.opaniuk@foundries.io>,
Jaehoon Chung <jh80.chung@samsung.com>,
Joel Peshkin <joel.peshkin@broadcom.com>,
Jorge Ramirez-Ortiz <jorge@foundries.io>,
Kory Maincent <kory.maincent@bootlin.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Maxime Ripard <maxime@cerno.tech>, Peng Fan <peng.fan@nxp.com>,
Pragnesh Patel <pragnesh.patel@sifive.com>,
Roland Gaudig <roland.gaudig@weidmueller.com>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] cmd: Add Kconfig option for multiprocessor cmds
Date: Fri, 14 Jan 2022 15:00:38 -0500 [thread overview]
Message-ID: <20220114200038.GU9207@bill-the-cat> (raw)
In-Reply-To: <af2b143a1cc6ad16a088c3c72e580bdd276f9baa.1642162053.git.michal.simek@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]
On Fri, Jan 14, 2022 at 01:07:34PM +0100, Michal Simek wrote:
> From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>
> Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor
> commands. Compile cmd/mp.c based on CONFIG_CMD_MP.
>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> cmd/Kconfig | 8 ++++++++
> cmd/Makefile | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 5b30b13e438f..1e3eef4437b5 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1827,6 +1827,14 @@ config MP
> different processors in multiprocessor
> cases.
>
> +config CMD_MP
> + bool "support for multiprocessor commands"
> + depends on MP
> + default y
> + help
> + This enables commands to bringup different processors
> + in multiprocessor cases.
> +
> config CMD_TIMER
> bool "timer"
> help
> diff --git a/cmd/Makefile b/cmd/Makefile
> index 891819ae0f6b..9e8074bb7e49 100644
> --- a/cmd/Makefile
> +++ b/cmd/Makefile
> @@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o
> obj-$(CONFIG_CMD_SLEEP) += sleep.o
> obj-$(CONFIG_CMD_MMC) += mmc.o
> obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o
> -obj-$(CONFIG_MP) += mp.o
> +obj-$(CONFIG_CMD_MP) += mp.o
> obj-$(CONFIG_CMD_MTD) += mtd.o
> obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o
> obj-$(CONFIG_CMD_CLONE) += clone.o
The problem is that there's already an entry for MP in cmd/Kconfig. So
yes, it should be fixed for consistency, but the current entry
renamed/moved. Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-01-14 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 12:07 [PATCH] cmd: Add Kconfig option for multiprocessor cmds Michal Simek
2022-01-14 20:00 ` Tom Rini [this message]
2022-01-17 9:18 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220114200038.GU9207@bill-the-cat \
--to=trini@konsulko.com \
--cc=a-govindraju@ti.com \
--cc=ashok.reddy.soma@xilinx.com \
--cc=aymen.sghaier@nxp.com \
--cc=bmeng.cn@gmail.com \
--cc=franck.lenormand@nxp.com \
--cc=git@xilinx.com \
--cc=igor.opaniuk@foundries.io \
--cc=jh80.chung@samsung.com \
--cc=joel.peshkin@broadcom.com \
--cc=jorge@foundries.io \
--cc=kory.maincent@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maxime@cerno.tech \
--cc=michal.simek@xilinx.com \
--cc=peng.fan@nxp.com \
--cc=pragnesh.patel@sifive.com \
--cc=roland.gaudig@weidmueller.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox