* [PATCH] cmd: Add Kconfig option for multiprocessor cmds
@ 2022-01-14 12:07 Michal Simek
2022-01-14 20:00 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2022-01-14 12:07 UTC (permalink / raw)
To: u-boot, git
Cc: Ashok Reddy Soma, Aswath Govindraju, Aymen Sghaier, Bin Meng,
Franck LENORMAND, Heinrich Schuchardt, Igor Opaniuk,
Jaehoon Chung, Joel Peshkin, Jorge Ramirez-Ortiz, Kory Maincent,
Marek Szyprowski, Maxime Ripard, Peng Fan, Pragnesh Patel,
Roland Gaudig, Simon Glass
From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor
commands. Compile cmd/mp.c based on CONFIG_CMD_MP.
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
cmd/Kconfig | 8 ++++++++
cmd/Makefile | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 5b30b13e438f..1e3eef4437b5 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1827,6 +1827,14 @@ config MP
different processors in multiprocessor
cases.
+config CMD_MP
+ bool "support for multiprocessor commands"
+ depends on MP
+ default y
+ help
+ This enables commands to bringup different processors
+ in multiprocessor cases.
+
config CMD_TIMER
bool "timer"
help
diff --git a/cmd/Makefile b/cmd/Makefile
index 891819ae0f6b..9e8074bb7e49 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o
obj-$(CONFIG_CMD_SLEEP) += sleep.o
obj-$(CONFIG_CMD_MMC) += mmc.o
obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o
-obj-$(CONFIG_MP) += mp.o
+obj-$(CONFIG_CMD_MP) += mp.o
obj-$(CONFIG_CMD_MTD) += mtd.o
obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o
obj-$(CONFIG_CMD_CLONE) += clone.o
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cmd: Add Kconfig option for multiprocessor cmds
2022-01-14 12:07 [PATCH] cmd: Add Kconfig option for multiprocessor cmds Michal Simek
@ 2022-01-14 20:00 ` Tom Rini
2022-01-17 9:18 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2022-01-14 20:00 UTC (permalink / raw)
To: Michal Simek
Cc: u-boot, git, Ashok Reddy Soma, Aswath Govindraju, Aymen Sghaier,
Bin Meng, Franck LENORMAND, Heinrich Schuchardt, Igor Opaniuk,
Jaehoon Chung, Joel Peshkin, Jorge Ramirez-Ortiz, Kory Maincent,
Marek Szyprowski, Maxime Ripard, Peng Fan, Pragnesh Patel,
Roland Gaudig, Simon Glass
[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]
On Fri, Jan 14, 2022 at 01:07:34PM +0100, Michal Simek wrote:
> From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>
> Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor
> commands. Compile cmd/mp.c based on CONFIG_CMD_MP.
>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> cmd/Kconfig | 8 ++++++++
> cmd/Makefile | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 5b30b13e438f..1e3eef4437b5 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1827,6 +1827,14 @@ config MP
> different processors in multiprocessor
> cases.
>
> +config CMD_MP
> + bool "support for multiprocessor commands"
> + depends on MP
> + default y
> + help
> + This enables commands to bringup different processors
> + in multiprocessor cases.
> +
> config CMD_TIMER
> bool "timer"
> help
> diff --git a/cmd/Makefile b/cmd/Makefile
> index 891819ae0f6b..9e8074bb7e49 100644
> --- a/cmd/Makefile
> +++ b/cmd/Makefile
> @@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o
> obj-$(CONFIG_CMD_SLEEP) += sleep.o
> obj-$(CONFIG_CMD_MMC) += mmc.o
> obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o
> -obj-$(CONFIG_MP) += mp.o
> +obj-$(CONFIG_CMD_MP) += mp.o
> obj-$(CONFIG_CMD_MTD) += mtd.o
> obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o
> obj-$(CONFIG_CMD_CLONE) += clone.o
The problem is that there's already an entry for MP in cmd/Kconfig. So
yes, it should be fixed for consistency, but the current entry
renamed/moved. Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cmd: Add Kconfig option for multiprocessor cmds
2022-01-14 20:00 ` Tom Rini
@ 2022-01-17 9:18 ` Michal Simek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2022-01-17 9:18 UTC (permalink / raw)
To: Tom Rini, Michal Simek
Cc: u-boot, git, Ashok Reddy Soma, Aswath Govindraju, Aymen Sghaier,
Bin Meng, Franck LENORMAND, Heinrich Schuchardt, Igor Opaniuk,
Jaehoon Chung, Joel Peshkin, Jorge Ramirez-Ortiz, Kory Maincent,
Marek Szyprowski, Maxime Ripard, Peng Fan, Pragnesh Patel,
Roland Gaudig, Simon Glass
On 1/14/22 21:00, Tom Rini wrote:
> On Fri, Jan 14, 2022 at 01:07:34PM +0100, Michal Simek wrote:
>
>> From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>>
>> Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor
>> commands. Compile cmd/mp.c based on CONFIG_CMD_MP.
>>
>> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> cmd/Kconfig | 8 ++++++++
>> cmd/Makefile | 2 +-
>> 2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index 5b30b13e438f..1e3eef4437b5 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -1827,6 +1827,14 @@ config MP
>> different processors in multiprocessor
>> cases.
>>
>> +config CMD_MP
>> + bool "support for multiprocessor commands"
>> + depends on MP
>> + default y
>> + help
>> + This enables commands to bringup different processors
>> + in multiprocessor cases.
>> +
>> config CMD_TIMER
>> bool "timer"
>> help
>> diff --git a/cmd/Makefile b/cmd/Makefile
>> index 891819ae0f6b..9e8074bb7e49 100644
>> --- a/cmd/Makefile
>> +++ b/cmd/Makefile
>> @@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o
>> obj-$(CONFIG_CMD_SLEEP) += sleep.o
>> obj-$(CONFIG_CMD_MMC) += mmc.o
>> obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o
>> -obj-$(CONFIG_MP) += mp.o
>> +obj-$(CONFIG_CMD_MP) += mp.o
>> obj-$(CONFIG_CMD_MTD) += mtd.o
>> obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o
>> obj-$(CONFIG_CMD_CLONE) += clone.o
>
> The problem is that there's already an entry for MP in cmd/Kconfig. So
> yes, it should be fixed for consistency, but the current entry
> renamed/moved. Thanks!
Consistency is one part. Second part is that MP code can be called without any
command that's why having two symbols make sense.
Anyway I have sent v2 with moving MP to Kconfig.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-17 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-14 12:07 [PATCH] cmd: Add Kconfig option for multiprocessor cmds Michal Simek
2022-01-14 20:00 ` Tom Rini
2022-01-17 9:18 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox