public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] lib: export vsscanf
@ 2021-12-20 23:19 Samuel Dionne-Riel
  2021-12-28  8:33 ` Simon Glass
  2022-01-15 12:38 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Samuel Dionne-Riel @ 2021-12-20 23:19 UTC (permalink / raw)
  To: u-boot; +Cc: Simon Glass

The function was missing from exports, even though it loooks like the
intent of the implementation in sscanf.c was to have it exported.

Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Cc: Simon Glass <sjg@chromium.org>
---

This is needed for porting an external library to U-Boot, in WIP
changes. It builds with a warning, and does link since the symbol is
present. Though when treating warnings as errors during development, it
becomes an issue.

 include/vsprintf.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/vsprintf.h b/include/vsprintf.h
index b474630146..8bfafa0d33 100644
--- a/include/vsprintf.h
+++ b/include/vsprintf.h
@@ -307,6 +307,14 @@ char *strmhz(char *buf, unsigned long hz);
  */
 void str_to_upper(const char *in, char *out, size_t len);
 
+/**
+ * vsscanf - Unformat a buffer into a list of arguments
+ * @buf:	input buffer
+ * @fmt:	format of buffer
+ * @args:	arguments
+ */
+int vsscanf(const char *inp, char const *fmt0, va_list ap);
+
 /**
  * sscanf - Unformat a buffer into a list of arguments
  * @buf:	input buffer
-- 
2.34.0



-- 
Samuel Dionne-Riel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] lib: export vsscanf
  2021-12-20 23:19 [PATCH] lib: export vsscanf Samuel Dionne-Riel
@ 2021-12-28  8:33 ` Simon Glass
  2022-01-15 12:38 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-12-28  8:33 UTC (permalink / raw)
  To: Samuel Dionne-Riel; +Cc: U-Boot Mailing List

On Mon, 20 Dec 2021 at 16:19, Samuel Dionne-Riel <samuel@dionne-riel.com> wrote:
>
> The function was missing from exports, even though it loooks like the
> intent of the implementation in sscanf.c was to have it exported.
>
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>
> This is needed for porting an external library to U-Boot, in WIP
> changes. It builds with a warning, and does link since the symbol is
> present. Though when treating warnings as errors during development, it
> becomes an issue.
>
>  include/vsprintf.h | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] lib: export vsscanf
  2021-12-20 23:19 [PATCH] lib: export vsscanf Samuel Dionne-Riel
  2021-12-28  8:33 ` Simon Glass
@ 2022-01-15 12:38 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-01-15 12:38 UTC (permalink / raw)
  To: Samuel Dionne-Riel; +Cc: u-boot, Simon Glass

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

On Mon, Dec 20, 2021 at 06:19:16PM -0500, Samuel Dionne-Riel wrote:

> The function was missing from exports, even though it loooks like the
> intent of the implementation in sscanf.c was to have it exported.
> 
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> Cc: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-15 12:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-20 23:19 [PATCH] lib: export vsscanf Samuel Dionne-Riel
2021-12-28  8:33 ` Simon Glass
2022-01-15 12:38 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox