public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Cc: "Simon Glass" <sjg@chromium.org>,
	"Lukasz Majewski" <lukma@denx.de>,
	"Sean Anderson" <seanga2@gmail.com>,
	"Daniel Schwierzeck" <daniel.schwierzeck@gmail.com>,
	"Joe Hershberger" <joe.hershberger@ni.com>,
	"Ramon Fried" <rfried.dev@gmail.com>,
	"Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: [PATCH 3/7] net: bcm63xx: Don't check clk_free
Date: Sat, 15 Jan 2022 17:25:00 -0500	[thread overview]
Message-ID: <20220115222504.617013-4-seanga2@gmail.com> (raw)
In-Reply-To: <20220115222504.617013-1-seanga2@gmail.com>

This function always succeeds, so don't check its return value.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---

 drivers/net/bcm6348-eth.c | 6 +-----
 drivers/net/bcm6368-eth.c | 6 +-----
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/net/bcm6348-eth.c b/drivers/net/bcm6348-eth.c
index aad7b61213..06e0dd74a5 100644
--- a/drivers/net/bcm6348-eth.c
+++ b/drivers/net/bcm6348-eth.c
@@ -461,11 +461,7 @@ static int bcm6348_eth_probe(struct udevice *dev)
 			return ret;
 		}
 
-		ret = clk_free(&clk);
-		if (ret < 0) {
-			pr_err("%s: error freeing clock %d\n", __func__, i);
-			return ret;
-		}
+		clk_free(&clk);
 	}
 
 	/* try to perform resets */
diff --git a/drivers/net/bcm6368-eth.c b/drivers/net/bcm6368-eth.c
index 29abe7fc96..c2a8b9f057 100644
--- a/drivers/net/bcm6368-eth.c
+++ b/drivers/net/bcm6368-eth.c
@@ -546,11 +546,7 @@ static int bcm6368_eth_probe(struct udevice *dev)
 			return ret;
 		}
 
-		ret = clk_free(&clk);
-		if (ret < 0) {
-			pr_err("%s: error freeing clock %d\n", __func__, i);
-			return ret;
-		}
+		clk_free(&clk);
 	}
 
 	/* try to perform resets */
-- 
2.34.1


  parent reply	other threads:[~2022-01-15 22:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-15 22:24 [PATCH 0/7] clk: Make clk_free return void Sean Anderson
2022-01-15 22:24 ` [PATCH 1/7] clk: Make rfree " Sean Anderson
2022-01-27 15:05   ` Simon Glass
2022-01-27 15:42     ` Sean Anderson
2022-01-27 21:35       ` Simon Glass
2022-02-01 14:49         ` Sean Anderson
2022-02-02  3:59           ` Simon Glass
2022-02-02  4:24             ` Sean Anderson
2022-02-26 18:36               ` Simon Glass
2022-02-27 19:38                 ` Sean Anderson
2022-03-01 14:58                   ` Simon Glass
2022-03-16 16:18                     ` Sean Anderson
2022-03-16 19:23                       ` Simon Glass
2022-01-15 22:24 ` [PATCH 2/7] dma: bcm6348: Don't check clk_free Sean Anderson
2022-01-15 22:25 ` Sean Anderson [this message]
2022-01-15 22:25 ` [PATCH 4/7] phy: bcm63xx: " Sean Anderson
2022-01-15 22:25 ` [PATCH 5/7] spi: " Sean Anderson
2022-01-15 22:25 ` [PATCH 6/7] spi: dw: " Sean Anderson
2022-01-15 22:25 ` [PATCH 7/7] clk: Make clk_free return void Sean Anderson
2022-03-30 19:21 ` [PATCH 0/7] " Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220115222504.617013-4-seanga2@gmail.com \
    --to=seanga2@gmail.com \
    --cc=daniel.schwierzeck@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=lukma@denx.de \
    --cc=noltari@gmail.com \
    --cc=rfried.dev@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox