From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BE09C433EF for ; Mon, 17 Jan 2022 01:35:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 44B1483025; Mon, 17 Jan 2022 02:35:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E4B518302C; Mon, 17 Jan 2022 02:35:36 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 208CC81E3E for ; Mon, 17 Jan 2022 02:35:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4395E1FB; Sun, 16 Jan 2022 17:35:33 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 487A33F766; Sun, 16 Jan 2022 17:35:32 -0800 (PST) Date: Mon, 17 Jan 2022 01:34:55 +0000 From: Andre Przywara To: Chris Morgan Cc: u-boot@lists.denx.de, hs@denx.de, Chris Morgan , Gajjar Akash Subject: Re: [PATCH 1/1] i2c: mvtwsi: Add compatible string for allwinner, sun4i-a10-i2c Message-ID: <20220117013455.02533b1a@slackpad.fritz.box> In-Reply-To: <20220107175254.6042-1-macroalpha82@gmail.com> References: <20220107175254.6042-1-macroalpha82@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 7 Jan 2022 11:52:54 -0600 Chris Morgan wrote: Hi Chris, > From: Chris Morgan > > This adds a compatible string for the Allwinner Sun4i-A10 I2C > controller. Without this, boards based on the R8 and A13 (at a > minimum) fail to boot. > > Signed-off-by: Chris Morgan Applied to sunxi/master, thanks! Out of curiosity, can you say what "fail to boot" means, exactly? I see that indeed i2c in U-Boot proper got lost when I2C was moved to DM in the v2022.01 merge window, but that didn't have any visible effect apart from the "i2c" command not working on my BananaPi. Ethernet, USB and Linux boot worked fine, still. Cheers, Andre > --- > drivers/i2c/mvtwsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c > index ff21e3c52b..979b825eec 100644 > --- a/drivers/i2c/mvtwsi.c > +++ b/drivers/i2c/mvtwsi.c > @@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = { > static const struct udevice_id mvtwsi_i2c_ids[] = { > { .compatible = "marvell,mv64xxx-i2c", }, > { .compatible = "marvell,mv78230-i2c", }, > + { .compatible = "allwinner,sun4i-a10-i2c", }, > { .compatible = "allwinner,sun6i-a31-i2c", }, > { /* sentinel */ } > };