From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>,
Wolfgang Denk <wd@denx.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH] env: fat: Add new lines at the end of print statements
Date: Mon, 17 Jan 2022 19:02:36 +0900 [thread overview]
Message-ID: <20220117100236.GB32171@laputa> (raw)
In-Reply-To: <20220102113835.1046267-1-pbrobinson@gmail.com>
On Sun, Jan 02, 2022 at 11:38:35AM +0000, Peter Robinson wrote:
> Add some new line feeds at the end of print messages to make things
> easier to read on the console. The other env options do this so
> this is just an omission for FAT env.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> env/fat.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/env/fat.c b/env/fat.c
> index 9d37d26f9e..fdccd6cd2a 100644
> --- a/env/fat.c
> +++ b/env/fat.c
> @@ -77,7 +77,7 @@ static int env_fat_save(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
It would be better to remove the comment above as well.
-Takahiro Akashi
> - printf("Unable to use %s %d:%d... ",
> + printf("Unable to use %s %d:%d... \n",
> CONFIG_ENV_FAT_INTERFACE, dev, part);
> return 1;
> }
> @@ -93,7 +93,7 @@ static int env_fat_save(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
> - printf("Unable to write \"%s\" from %s%d:%d... ",
> + printf("Unable to write \"%s\" from %s%d:%d... \n",
> file, CONFIG_ENV_FAT_INTERFACE, dev, part);
> return 1;
> }
> @@ -135,7 +135,7 @@ static int env_fat_load(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
> - printf("Unable to use %s %d:%d... ",
> + printf("Unable to use %s %d:%d... \n",
> CONFIG_ENV_FAT_INTERFACE, dev, part);
> goto err_env_relocate;
> }
> @@ -153,7 +153,7 @@ static int env_fat_load(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
> - printf("Unable to read \"%s\" from %s%d:%d... ",
> + printf("Unable to read \"%s\" from %s%d:%d... \n",
> CONFIG_ENV_FAT_FILE, CONFIG_ENV_FAT_INTERFACE, dev, part);
> goto err_env_relocate;
> }
> --
> 2.33.1
>
prev parent reply other threads:[~2022-01-17 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 11:38 [PATCH] env: fat: Add new lines at the end of print statements Peter Robinson
2022-01-15 12:38 ` Tom Rini
2022-01-17 10:02 ` AKASHI Takahiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117100236.GB32171@laputa \
--to=takahiro.akashi@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=pbrobinson@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox