* [PATCH] env: fat: Add new lines at the end of print statements
@ 2022-01-02 11:38 Peter Robinson
2022-01-15 12:38 ` Tom Rini
2022-01-17 10:02 ` AKASHI Takahiro
0 siblings, 2 replies; 3+ messages in thread
From: Peter Robinson @ 2022-01-02 11:38 UTC (permalink / raw)
To: Joe Hershberger, Wolfgang Denk, u-boot; +Cc: Peter Robinson
Add some new line feeds at the end of print messages to make things
easier to read on the console. The other env options do this so
this is just an omission for FAT env.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
env/fat.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/env/fat.c b/env/fat.c
index 9d37d26f9e..fdccd6cd2a 100644
--- a/env/fat.c
+++ b/env/fat.c
@@ -77,7 +77,7 @@ static int env_fat_save(void)
* This printf is embedded in the messages from env_save that
* will calling it. The missing \n is intentional.
*/
- printf("Unable to use %s %d:%d... ",
+ printf("Unable to use %s %d:%d... \n",
CONFIG_ENV_FAT_INTERFACE, dev, part);
return 1;
}
@@ -93,7 +93,7 @@ static int env_fat_save(void)
* This printf is embedded in the messages from env_save that
* will calling it. The missing \n is intentional.
*/
- printf("Unable to write \"%s\" from %s%d:%d... ",
+ printf("Unable to write \"%s\" from %s%d:%d... \n",
file, CONFIG_ENV_FAT_INTERFACE, dev, part);
return 1;
}
@@ -135,7 +135,7 @@ static int env_fat_load(void)
* This printf is embedded in the messages from env_save that
* will calling it. The missing \n is intentional.
*/
- printf("Unable to use %s %d:%d... ",
+ printf("Unable to use %s %d:%d... \n",
CONFIG_ENV_FAT_INTERFACE, dev, part);
goto err_env_relocate;
}
@@ -153,7 +153,7 @@ static int env_fat_load(void)
* This printf is embedded in the messages from env_save that
* will calling it. The missing \n is intentional.
*/
- printf("Unable to read \"%s\" from %s%d:%d... ",
+ printf("Unable to read \"%s\" from %s%d:%d... \n",
CONFIG_ENV_FAT_FILE, CONFIG_ENV_FAT_INTERFACE, dev, part);
goto err_env_relocate;
}
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] env: fat: Add new lines at the end of print statements
2022-01-02 11:38 [PATCH] env: fat: Add new lines at the end of print statements Peter Robinson
@ 2022-01-15 12:38 ` Tom Rini
2022-01-17 10:02 ` AKASHI Takahiro
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-01-15 12:38 UTC (permalink / raw)
To: Peter Robinson; +Cc: Joe Hershberger, Wolfgang Denk, u-boot
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
On Sun, Jan 02, 2022 at 11:38:35AM +0000, Peter Robinson wrote:
> Add some new line feeds at the end of print messages to make things
> easier to read on the console. The other env options do this so
> this is just an omission for FAT env.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] env: fat: Add new lines at the end of print statements
2022-01-02 11:38 [PATCH] env: fat: Add new lines at the end of print statements Peter Robinson
2022-01-15 12:38 ` Tom Rini
@ 2022-01-17 10:02 ` AKASHI Takahiro
1 sibling, 0 replies; 3+ messages in thread
From: AKASHI Takahiro @ 2022-01-17 10:02 UTC (permalink / raw)
To: Peter Robinson; +Cc: Joe Hershberger, Wolfgang Denk, u-boot
On Sun, Jan 02, 2022 at 11:38:35AM +0000, Peter Robinson wrote:
> Add some new line feeds at the end of print messages to make things
> easier to read on the console. The other env options do this so
> this is just an omission for FAT env.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> env/fat.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/env/fat.c b/env/fat.c
> index 9d37d26f9e..fdccd6cd2a 100644
> --- a/env/fat.c
> +++ b/env/fat.c
> @@ -77,7 +77,7 @@ static int env_fat_save(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
It would be better to remove the comment above as well.
-Takahiro Akashi
> - printf("Unable to use %s %d:%d... ",
> + printf("Unable to use %s %d:%d... \n",
> CONFIG_ENV_FAT_INTERFACE, dev, part);
> return 1;
> }
> @@ -93,7 +93,7 @@ static int env_fat_save(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
> - printf("Unable to write \"%s\" from %s%d:%d... ",
> + printf("Unable to write \"%s\" from %s%d:%d... \n",
> file, CONFIG_ENV_FAT_INTERFACE, dev, part);
> return 1;
> }
> @@ -135,7 +135,7 @@ static int env_fat_load(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
> - printf("Unable to use %s %d:%d... ",
> + printf("Unable to use %s %d:%d... \n",
> CONFIG_ENV_FAT_INTERFACE, dev, part);
> goto err_env_relocate;
> }
> @@ -153,7 +153,7 @@ static int env_fat_load(void)
> * This printf is embedded in the messages from env_save that
> * will calling it. The missing \n is intentional.
> */
> - printf("Unable to read \"%s\" from %s%d:%d... ",
> + printf("Unable to read \"%s\" from %s%d:%d... \n",
> CONFIG_ENV_FAT_FILE, CONFIG_ENV_FAT_INTERFACE, dev, part);
> goto err_env_relocate;
> }
> --
> 2.33.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-17 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-02 11:38 [PATCH] env: fat: Add new lines at the end of print statements Peter Robinson
2022-01-15 12:38 ` Tom Rini
2022-01-17 10:02 ` AKASHI Takahiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox