From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89ACAC433F5 for ; Mon, 17 Jan 2022 14:47:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F203181A03; Mon, 17 Jan 2022 15:46:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="C0ysMYTE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C647282C6D; Mon, 17 Jan 2022 15:46:57 +0100 (CET) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B92080F9E for ; Mon, 17 Jan 2022 15:46:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id v7so19374940qtw.13 for ; Mon, 17 Jan 2022 06:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Kp4H6un80crcJClmOGUSMZLnjTkj2uf4QS+xjtbPvWI=; b=C0ysMYTEf3K1DuQig1Qp8voLQo+noBn7K3YoNgbwaCQgChdFeyhz139VHx/HOAWLLV Zs71H8l3hIC+v8CsBlNuHnl3duOC5J3s+HHwet88+TwuCgNIgm0HvkEaAXzJ2pOzi1zb UxeyDUx5feMcomWpUVwj6GtVWviTACXzqrHkg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Kp4H6un80crcJClmOGUSMZLnjTkj2uf4QS+xjtbPvWI=; b=O5bWCJvGlTeA+pduJ9ooY6oN/XAu5XkbJMYiczMlnuA7XW297fS8ucV5F7cn/nY3Yu r/MoO8dLC7HWaYWRBwlW6xfQ9UHVWDC9og8Ralwz67p+wmZ9CcogXg0nWjwdnrzC9b/Q J9dlVIf+tRuJQLaNYLD8p79sTFCgqxIPHM0BrVhWcQ1U5xT2uktcZ/lMPKEwV6YERmzQ Kty8oiPsB0c2259vMRtAB1x8ssajFJhIrtmlvLXz/a6R5TCu5NDc3TKImCE/AsINhc7Q R86RqAls4nf1ZFDpcFIh9a3U3pCETG49ttoPKM97LOT5JzWmt6vijiTXtUYMICKH2akF rUqQ== X-Gm-Message-State: AOAM532pzmIcm6kLDCiybWau3dWYALX89GZtTf5RjEHEuR/e1RBt1aKe 10UNuyMBylnTcGDCtCFWSd8t/g== X-Google-Smtp-Source: ABdhPJxMr7+LVHEehSVvA/33dg+hzsUzva9/wIQZJd7VwavPdfVghy3HCS9ltxVb1zECkJkjFy9fwQ== X-Received: by 2002:ac8:5994:: with SMTP id e20mr17555833qte.687.1642430813156; Mon, 17 Jan 2022 06:46:53 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-91f5-d300-5341-d6b8.res6.spectrum.com. [2603:6081:7b01:cbda:91f5:d300:5341:d6b8]) by smtp.gmail.com with ESMTPSA id q7sm9049686qkl.72.2022.01.17.06.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 06:46:52 -0800 (PST) Date: Mon, 17 Jan 2022 09:46:50 -0500 From: Tom Rini To: Vignesh Raghavendra Cc: Dave Gerlach , Joe Hershberger , Ramon Fried , u-boot@lists.denx.de, Grygorii Strashko Subject: Re: [PATCH 6/8] configs: am64x_evm: set eth1 as boot interface Message-ID: <20220117144650.GA2631507@bill-the-cat> References: <20211224072536.270251-1-vigneshr@ti.com> <20211224072536.270251-7-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <20211224072536.270251-7-vigneshr@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 24, 2021 at 12:55:34PM +0530, Vignesh Raghavendra wrote: > ROM supports boot from CPSW second port, therefore set eth1 boot > interface >=20 > Signed-off-by: Vignesh Raghavendra > --- > include/configs/am64x_evm.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_evm.h > index 99624081c3..cd4b658e5f 100644 > --- a/include/configs/am64x_evm.h > +++ b/include/configs/am64x_evm.h > @@ -33,7 +33,7 @@ > * our memory footprint. The less we use for BSS the more we have availa= ble > * for everything else. > */ > -#define CONFIG_SPL_BSS_MAX_SIZE 0x1000 > +#define CONFIG_SPL_BSS_MAX_SIZE 0xa000 > /* > * Link BSS to be within SPL in a dedicated region located near the top = of > * the MCU SRAM, this way making it available also before relocation. No= te > @@ -64,6 +64,7 @@ > "if test $fdtfile =3D undefined; then " \ > "echo WARNING: Could not determine device tree to use; fi; \0" \ > "name_kern=3DImage\0" \ > + "ethact=3Deth0\0" \ > "console=3DttyS2,115200n8\0" \ > "args_all=3Dsetenv optargs earlycon=3Dns16550a,mmio32,0x02800000 " \ > "${mtdparts}\0" \ > @@ -140,4 +141,6 @@ > =20 > #define CONFIG_SYS_USB_FAT_BOOT_PARTITION 1 > =20 > +#define CONFIG_SPL_ETH_DEVICE "eth1" > + > #endif /* __CONFIG_AM642_EVM_H */ What's going on exactly here? First, CONFIG_SPL_ETH_DEVICE needs to be migrated to Kconfig now, if we're going to use it. But, it's used to set "ethact", which wouldd normally be eth0, but you're setting it to eth1 here and eth0 for U-Boot itself? Can you please explain the setup here? Thanks! --=20 Tom --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHlgVcACgkQFHw5/5Y0 tywqhQv/V+3UG5GC90PTLuWB8Mh25pMzBKz/Ayegj4RTsW58IcvBgRVJXa5EC9GM 9TtcUUbLEng+5jQKiPOFdyB8BKj/EtIz2IpajHzPN6+F/yrLDJqojHB9Z/dFstDz 7+Qdd1kPYRjs3TgFJRNfk4gbHQKyHhU0aZEni0/U+Ga7nYn6U//m8dJ1DNLTeKTk YbdXTfrv5HC46L/cFnH0UMF/XBHiRikgJupRlmd3LTCzEJhKyoJebvNOr2cfAYLz itdwXG+2AQCZPrAk77t1dXKxDYjQYA0i1tb/wb1G7yTHzRSLm//xY6WokgZhEzel n/Dd6JNzaNuXxA7u4bCme3oVtJncm2/lHvhtCI/iZ+KicQkC6qZug5+ILW0YDl+6 s269s1nZxClSkUfnVd/SYxMKHamP5elS+Ee+MLivCsNtDpI4RK1D2hj9v2zTFUgo 4z8r045KfB6MuIlYZqKeMYBBVXo5bNRiKGToj8Ry2e5OkREoUXRWjDE2HkGM71Zi SzwW/ozU =Kuz1 -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--