From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5478DC433F5 for ; Mon, 17 Jan 2022 16:59:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9DBD2837DC; Mon, 17 Jan 2022 17:59:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qbPxvvT+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 97424837E7; Mon, 17 Jan 2022 17:59:48 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8585A837E9 for ; Mon, 17 Jan 2022 17:59:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id c19so19780266qtx.3 for ; Mon, 17 Jan 2022 08:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=19Pvj4FXgRGfpy5hFBdRb0bAg3fIL5ILm057yJFcpo4=; b=qbPxvvT+iiWkQuT/ETdR44fJ0MY9CAcA+7HXpPxGf7/ffhZVcq9dSTa6y0lNxv/9OS jMMriPvI37Aj9qU31k7Fh1/mXODYqhDNl1LyX+ZNk146lhbwqwb7LutjcIxa7gi6T4IW 0LVhITQ8ylI+hY1VsA1YWX9dBe25XSMnEtM4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=19Pvj4FXgRGfpy5hFBdRb0bAg3fIL5ILm057yJFcpo4=; b=ED7GX9eyqHCDOVE6KLc5iXWAQtpkLbtjSiPrIz5LuBmGZTELi72l2c6agi/QVBx5+a BhNbz1KPHb0QnbC4xxb1htTYbi9MWcJPbZmQRpHERzS6tng8rUmyPKKSCj1YysKbFOQU IXp7Mlfn9CxFWJPNS2EC8EyBB+ewlzijMlEt9CenYI1drq9N8f61I5CAr6VKwT15RtmT CcpocOBUl3RyBRn+bpqWYjpIkGwi0kNWqbbSpjK5jsjECSkefE6YTlvIQRUtqCJ4WUvW CvIM6DYbv60WpENa91eTRflwt3okXVCoJfqHM8wgPTMWeWHi3rMpoFCjwi6AtxUrGibD AS5Q== X-Gm-Message-State: AOAM532qtkrOk9udF+J9ZY51coTw4NUB1f6P/0b4AAHla0ilSbiJfemD zXUAzBxPsvN+VqvSFs1ZZrpjtQ== X-Google-Smtp-Source: ABdhPJxhwfKxKv/jr3z+rqrZeWBxe+mzGCRCIfPOXcLhvtyoCN1cfhKruKHTf8o0COmgzEpFsTWNkQ== X-Received: by 2002:a05:622a:130b:: with SMTP id v11mr17857949qtk.355.1642438782905; Mon, 17 Jan 2022 08:59:42 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-8dc3-db57-8e4a-695a.res6.spectrum.com. [2603:6081:7b01:cbda:8dc3:db57:8e4a:695a]) by smtp.gmail.com with ESMTPSA id d3sm3724125qte.76.2022.01.17.08.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 08:59:42 -0800 (PST) Date: Mon, 17 Jan 2022 11:59:40 -0500 From: Tom Rini To: Angus Ainslie Cc: "NXP i.MX U-Boot Team" , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Peng Fan , Marcel Ziswiler , Teresa Remmet , Adam Ford , Tim Harvey , Jagan Teki , Ilko Iliev , kernel@puri.sm Subject: Re: [PATCH 05/13] include: configs: add the librem5.h include file Message-ID: <20220117165940.GM2631111@bill-the-cat> References: <20220117150735.218886-1-angus@akkea.ca> <20220117150735.218886-6-angus@akkea.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N8ia4yKhAKKETby7" Content-Disposition: inline In-Reply-To: <20220117150735.218886-6-angus@akkea.ca> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --N8ia4yKhAKKETby7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 17, 2022 at 07:07:27AM -0800, Angus Ainslie wrote: > Initial commit of the librem5.h configuration >=20 > Signed-off-by: Angus Ainslie You'll want to use CI (https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html) to get this tested for migrated symbols, or copy the CI logic out to a script and do that manually as I suspect there's some symbols here that need to be in the defconfig. Also: > +#ifdef CONFIG_SPL_BUILD > +#define CONFIG_SPL_THERM_SUPPORT > +#define CONFIG_SPL_WATCHDOG_SUPPORT > +#define CONFIG_SPL_DRIVERS_MISC_SUPPORT > +#define CONFIG_SPL_LDSCRIPT "arch/arm/cpu/armv8/u-boot-spl.lds" > +#define CONFIG_SPL_STACK 0x187FF0 > +#define CONFIG_SPL_GPIO_SUPPORT > +#define CONFIG_SPL_MMC_SUPPORT > +#define CONFIG_SPL_BSS_START_ADDR 0x00180000 > +#define CONFIG_SPL_BSS_MAX_SIZE 0x2000 /* 8 KB */ > +#define CONFIG_SPL_STACK_R_ADDR 0x42300000 > +#define CONFIG_SPL_STACK_R > +#define CONFIG_SYS_SPL_MALLOC_START 0x42200000 > +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x80000 /* 512 KB */ > +#define CONFIG_SYS_ICACHE_OFF > +#define CONFIG_SYS_DCACHE_OFF > + > +#define CONFIG_MALLOC_F_ADDR 0x182000 /* malloc f used before GD_FLG_FU= LL_MALLOC_INIT */ > + > +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE /* For RAW image gives a error inf= o not panic */ > + > +#undef CONFIG_SPL_DM_PMIC > +#undef CONFIG_SPL_DM_I2C > +#undef CONFIG_SPL_DM_PMIC_BD71837 > +#undef CONFIG_DM_USB > +#undef CONFIG_SPL_DM_USB > +#undef CONFIG_USB_DWC3_GENERIC > +#undef CONFIG_DEVRES > + > +#define CONFIG_SYS_I2C > + > +#define CONFIG_POWER_BD71837 > +#define CONFIG_POWER_BD71837_I2C_BUS 0 > +#define CONFIG_POWER_BD71837_I2C_ADDR 0x4B > + > +#define CONFIG_SPL_DMA_SUPPORT > + > +#define CONFIG_SYS_FSL_USDHC_NUM 1 > + > +#else /* CONFIG_SPL_BUILD*/ > + > +#define CONFIG_SYS_FSL_USDHC_NUM 2 > + > +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1 > + > +#define CONFIG_USBD_HS > + > +#define CONFIG_USB_GADGET_VBUS_DRAW 2 > + > +#endif /* CONFIG_SPL_BUILD*/ You can't use CONFIG_SPL_BUILD in this way. Symbols need to always be set (and yes, this likely came from some other bad example). [snip] > + "bootargs=3Du_boot_version=3D" PLAIN_VERSION "\0" \ Why do you need this? It might be a problem for reproducible builds, and also you should just be able to use ${version} from the environment? Thanks. --=20 Tom --N8ia4yKhAKKETby7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHloHwACgkQFHw5/5Y0 tywlsQv/Z/9GoIhkCQxV/OYUE2ODex+LSojDuJQYj2WamWpiCEBjcMyDCAEZevyv wZKgu9ETMlr1k5ftXkiAJATHr0MxBBfoJRvmoUB9t0scEw0eU6n73djOfSVo6wNp pceiRP12Aj+UT4fcYNxj3I3jroiQ/ZpCY7aGCZGqw+o5rXkg7Onw3F74pep9IVYw fgLu9k1ZgxSZmTQrywelzpM64TxKBJiR9BcSA//qDdB9sn0s3KmlnnMWMPAUMZas PeXf0vz/VnrCUiDOMBWd7YGklWGvxTImul0C5qwkV4JSSjVQvTDHNwxbCvBNgIgR ycp4VrT9hvHwpUJu1Ro8NuifLFqCEgW4XWMx9BVoDIvv2mJ8dY7f15ZL0fRdwGCe MwtnZvyBgIzDhsIU2HHZAWi8cf7CD3EN4KRLHmck9mIr+WPGYkSo11ZjVxU8a6bz AkJq2PcKTrwAQilRfXKYK0pEnbRaKU98zBanujxHKcwwevMLM2QDvYd+bt0v3KhN 3H0ijbhC =nEAY -----END PGP SIGNATURE----- --N8ia4yKhAKKETby7--