From: Tom Rini <trini@konsulko.com>
To: Angus Ainslie <angus@akkea.ca>
Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Teresa Remmet <t.remmet@phytec.de>,
Adam Ford <aford173@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Ilko Iliev <iliev@ronetix.at>,
kernel@puri.sm
Subject: Re: [PATCH 00/13] Add support for the Purism Librem5 Phone
Date: Mon, 17 Jan 2022 12:49:51 -0500 [thread overview]
Message-ID: <20220117174951.GO2631111@bill-the-cat> (raw)
In-Reply-To: <2460dcc7d927ccaef6c00333a18fc764@akkea.ca>
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
On Mon, Jan 17, 2022 at 09:14:05AM -0800, Angus Ainslie wrote:
> Hi Toni
>
> On 2022-01-17 08:59, Tom Rini wrote:
> > On Mon, Jan 17, 2022 at 07:07:22AM -0800, Angus Ainslie wrote:
> >
> > > I sent this patchset as a single monolithic patch and did not see any
> > > comment on it.
> > >
> > > https://lists.denx.de/pipermail/u-boot/2022-January/471087.html
> > >
> > > Here it is as a set of patches instead.
> > >
> > > This is all of the code required to boot the Librem5 Phone.
> > >
> > > It can boot the phone in uuu mode or directly from the eMMC
> >
> > Yes, sorry, we're a little behind on imx-related patches right now. In
> > general yes, splitting this up a bit helps, but it's too split now.
> > I'll reply with some specific questions / comments, but the way it was
> > before is better really.
>
> Thanks for the review and I'll start making changes for v2.
>
> About how it should be split up. Should all of the "board/purism/librem5"
> and config files be in one patch with the devicetree and documentation in
> separate patches ?
Since you've already split out driver/etc changes to other patches, one
patch with board/ and include/configs/ and configs/ and dts files is
fine.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-01-17 17:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 15:07 [PATCH 00/13] Add support for the Purism Librem5 Phone Angus Ainslie
2022-01-17 15:07 ` [PATCH 01/13] MAINTAINERS: add Purism to the maintainers file Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 15:07 ` [PATCH 02/13] arm: dts: add the Purism devicetree files Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 17:51 ` Angus Ainslie
2022-01-17 18:25 ` Tom Rini
2022-01-17 18:52 ` Angus Ainslie
2022-01-17 19:42 ` Tom Rini
2022-01-17 15:07 ` [PATCH 03/13] arm: imx8m: add Purism Librem5 Kconfig Angus Ainslie
2022-01-17 15:07 ` [PATCH 04/13] configs: add the Librem5 defconfig Angus Ainslie
2022-01-17 15:07 ` [PATCH 05/13] include: configs: add the librem5.h include file Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 15:07 ` [PATCH 06/13] board: librem5: add the u-boot source for the Librem5 Angus Ainslie
2022-01-17 15:07 ` [PATCH 07/13] board: librem5: add the u-boot header " Angus Ainslie
2022-01-17 15:07 ` [PATCH 08/13] board: librem5: add the SPL source " Angus Ainslie
2022-01-17 15:07 ` [PATCH 09/13] board: librem5: add the LPDDR4 " Angus Ainslie
2022-01-17 15:07 ` [PATCH 11/13] board: librem5: add Librem5 MAINTAINERS file Angus Ainslie
2022-01-17 15:07 ` [PATCH 12/13] board: librem5: add Librem5 build files Angus Ainslie
2022-01-17 15:07 ` [PATCH 13/13] doc: librem5: add Librem5 documentation Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 16:59 ` [PATCH 00/13] Add support for the Purism Librem5 Phone Tom Rini
2022-01-17 17:14 ` Angus Ainslie
2022-01-17 17:15 ` Angus Ainslie
2022-01-17 17:50 ` Tom Rini
2022-01-17 17:49 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117174951.GO2631111@bill-the-cat \
--to=trini@konsulko.com \
--cc=aford173@gmail.com \
--cc=angus@akkea.ca \
--cc=festevam@gmail.com \
--cc=iliev@ronetix.at \
--cc=jagan@amarulasolutions.com \
--cc=kernel@puri.sm \
--cc=marcel.ziswiler@toradex.com \
--cc=peng.fan@nxp.com \
--cc=sbabic@denx.de \
--cc=t.remmet@phytec.de \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox