From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D722C433EF for ; Mon, 17 Jan 2022 17:50:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 28AFA8128D; Mon, 17 Jan 2022 18:50:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VQsd26GJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 632C9811AC; Mon, 17 Jan 2022 18:50:00 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 949B380FDE for ; Mon, 17 Jan 2022 18:49:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id l17so19884353qtk.7 for ; Mon, 17 Jan 2022 09:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t/HZr4Mkm+rcOVOUAr+UiJWIrnha7TL5EbpY1v9+VyU=; b=VQsd26GJXSr/wX3txzlfY6qVOg49sTJNXvZQ+NVovaUKW07bYHV6Kt4hEE+2wQleD6 tzefK5A5K7QW4noJWNjuQ1wB0Rcme4fbd1MnSkM9Zm49Z36HvVqsqY8i1lfBcTeTmM4w tFT2/QSWHreUyiNVknjHkBjDwN7TsuJIt7RPY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t/HZr4Mkm+rcOVOUAr+UiJWIrnha7TL5EbpY1v9+VyU=; b=ak5sGvv3CPzVdDTxd2RqzJOsw5zQFK7S50ukQCyQWu6eU3qLnKuQkovblgXah68XxF IpjEpN474gMyUwY8CxWiStTitWHoqLSSFqNMJRakc+4g9jgw+TLwcRNtv1z0Dow6SG6C RBra9O0+siQZQ6np1wdVFsxtvrKjN+ii6hQvKw2ywXD/FpURF/Kvu4+V7hgpxOgRlh65 MuEbyziKcs/kOY10KKMf6QimHeAZM6a+D4QmnwxeJJbp1x3+kSnG7lPuH4jXK7Yf8q6P p4ul/QUpyPI0N9EhgmsZfCLOQxfo8zIajD+TjTVKMKCx9vqmGFFtt2mmO32NbxhGjBLk j0aw== X-Gm-Message-State: AOAM532miZQP4abXF0KfoASjm+5uc7onlUbyyPz/Bbq5OeIju915Tbp/ wn/N/uM4pjfn3GgmP2pTPUuocQ== X-Google-Smtp-Source: ABdhPJwVsUHsvDaQG6udJ3O+p0lVOTFkdwIrHYRtepKYy68eDEqjjm5+/l9zNxT7isLglPlWr9sUQA== X-Received: by 2002:ac8:5e4a:: with SMTP id i10mr17919474qtx.569.1642441795345; Mon, 17 Jan 2022 09:49:55 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-8dc3-db57-8e4a-695a.res6.spectrum.com. [2603:6081:7b01:cbda:8dc3:db57:8e4a:695a]) by smtp.gmail.com with ESMTPSA id j10sm9357708qtx.17.2022.01.17.09.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 09:49:54 -0800 (PST) Date: Mon, 17 Jan 2022 12:49:51 -0500 From: Tom Rini To: Angus Ainslie Cc: "NXP i.MX U-Boot Team" , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Peng Fan , Marcel Ziswiler , Teresa Remmet , Adam Ford , Tim Harvey , Jagan Teki , Ilko Iliev , kernel@puri.sm Subject: Re: [PATCH 00/13] Add support for the Purism Librem5 Phone Message-ID: <20220117174951.GO2631111@bill-the-cat> References: <20220117150735.218886-1-angus@akkea.ca> <20220117165914.GJ2631111@bill-the-cat> <2460dcc7d927ccaef6c00333a18fc764@akkea.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SLfjTIIQuAzj8yil" Content-Disposition: inline In-Reply-To: <2460dcc7d927ccaef6c00333a18fc764@akkea.ca> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --SLfjTIIQuAzj8yil Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 17, 2022 at 09:14:05AM -0800, Angus Ainslie wrote: > Hi Toni >=20 > On 2022-01-17 08:59, Tom Rini wrote: > > On Mon, Jan 17, 2022 at 07:07:22AM -0800, Angus Ainslie wrote: > >=20 > > > I sent this patchset as a single monolithic patch and did not see any > > > comment on it. > > >=20 > > > https://lists.denx.de/pipermail/u-boot/2022-January/471087.html > > >=20 > > > Here it is as a set of patches instead. > > >=20 > > > This is all of the code required to boot the Librem5 Phone. > > >=20 > > > It can boot the phone in uuu mode or directly from the eMMC > >=20 > > Yes, sorry, we're a little behind on imx-related patches right now. In > > general yes, splitting this up a bit helps, but it's too split now. > > I'll reply with some specific questions / comments, but the way it was > > before is better really. >=20 > Thanks for the review and I'll start making changes for v2. >=20 > About how it should be split up. Should all of the "board/purism/librem5" > and config files be in one patch with the devicetree and documentation in > separate patches ? Since you've already split out driver/etc changes to other patches, one patch with board/ and include/configs/ and configs/ and dts files is fine. --=20 Tom --SLfjTIIQuAzj8yil Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHlrDwACgkQFHw5/5Y0 tyw5nAv/UKgazgexN/A5IVis1lHrGpxUEu/5DG/mqaSvwz5FqAylBTa3qOJ3Xl/M uIdvoxNfZtLoL6P8WnQwwdnGtYlSY3vzCS9HCGu3Nrsq5baM9E8g6HNdK7FgBzy/ nj54xgea6PdeITkymmlzEfhcb+c9oIMJe150MDT5tbj9e5TefejjxHYEbQcwSdyY yuW2wv5yXynBRNs0SRfvi7anqDkRiAjhVfnExIoPjRRcVCskM9re3JAcP/crVqnx Zo4vPMbW6vH8PrSStlAjrm4O/fIOEZNiLaAKBBf35kmM2xXW2IrikIpVYBUDlk7q rULJ0IpX6vQU8aGrFQpya5wy+BerQtOIFLQTOrGud/MkdlaxM7zK1UdOjlCQ7SJF +BWNGj9htZv/2BUgdBfN0vD27QDIMyYf+s3omMI5sJClEkQYwMFwVmiA9570zylO VBimfnJZDB+Y/+QJ+UX/McJyajxk5YbkARnJ7fIoybJT/vh85rIH+0MJ6NWA/VMF mEllezWB =fLtk -----END PGP SIGNATURE----- --SLfjTIIQuAzj8yil--