From: Tom Rini <trini@konsulko.com>
To: Angus Ainslie <angus@akkea.ca>
Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Teresa Remmet <t.remmet@phytec.de>,
Adam Ford <aford173@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Ilko Iliev <iliev@ronetix.at>,
kernel@puri.sm
Subject: Re: [PATCH 02/13] arm: dts: add the Purism devicetree files
Date: Mon, 17 Jan 2022 13:25:13 -0500 [thread overview]
Message-ID: <20220117182513.GR2631111@bill-the-cat> (raw)
In-Reply-To: <3498b84cf21f803c0466927fdb83d9be@akkea.ca>
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
On Mon, Jan 17, 2022 at 09:51:24AM -0800, Angus Ainslie wrote:
> Hi Tom,
>
> On 2022-01-17 08:59, Tom Rini wrote:
> > On Mon, Jan 17, 2022 at 07:07:24AM -0800, Angus Ainslie wrote:
> >
> > > Initial commit of Librem5 devicetree files
> > >
> > > Signed-off-by: Angus Ainslie <angus@akkea.ca>
> >
> > Please note what kernel release the not -u-boot.dtsi files are a copy
> > from, as they need to be copies and not modified, thanks.
>
> There's an issue with adding the devicetree from the 5.16 kernel.
>
> I get a compilation error due to a :missing .h in the devicetree files:
>
> In file included from arch/arm/dts/imx8mq-librem5-r3.dtsi:11,
> from arch/arm/dts/.imx8mq-librem5.dtb.pre.tmp:6:
> arch/arm/dts/imx8mq-librem5.dtsi:13:10: fatal error:
> dt-bindings/rfkill/rfkill.h: No such file or directory
> 13 | #include "dt-bindings/rfkill/rfkill.h"
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Should that get added to the u-boot source as well or should I modify the
> dts to remove this ?
Import the missing binding(s) in a separate commit first please.
> For the kernel we also have 4 different dts files for the differences in PCB
> versions. For u-boot we don't need the differentiation as it deals with
> things like camera rotation and prox sensor sensitivity.
>
> There's 2 ways to solve the this I think.
>
> 1) just use the latest librem5 dts file which is made up of 3 different
> dts(i) files.
> 2) have a defconfig for each of the different PCB versions.
>
> Do you have a preference ?
Can you tell the revision at run-time? We have examples of boards that
can and will include revA.dtb and revB.dtb and select the correct one at
run time (and start with something that works on revA and revB).
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-01-17 18:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 15:07 [PATCH 00/13] Add support for the Purism Librem5 Phone Angus Ainslie
2022-01-17 15:07 ` [PATCH 01/13] MAINTAINERS: add Purism to the maintainers file Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 15:07 ` [PATCH 02/13] arm: dts: add the Purism devicetree files Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 17:51 ` Angus Ainslie
2022-01-17 18:25 ` Tom Rini [this message]
2022-01-17 18:52 ` Angus Ainslie
2022-01-17 19:42 ` Tom Rini
2022-01-17 15:07 ` [PATCH 03/13] arm: imx8m: add Purism Librem5 Kconfig Angus Ainslie
2022-01-17 15:07 ` [PATCH 04/13] configs: add the Librem5 defconfig Angus Ainslie
2022-01-17 15:07 ` [PATCH 05/13] include: configs: add the librem5.h include file Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 15:07 ` [PATCH 06/13] board: librem5: add the u-boot source for the Librem5 Angus Ainslie
2022-01-17 15:07 ` [PATCH 07/13] board: librem5: add the u-boot header " Angus Ainslie
2022-01-17 15:07 ` [PATCH 08/13] board: librem5: add the SPL source " Angus Ainslie
2022-01-17 15:07 ` [PATCH 09/13] board: librem5: add the LPDDR4 " Angus Ainslie
2022-01-17 15:07 ` [PATCH 11/13] board: librem5: add Librem5 MAINTAINERS file Angus Ainslie
2022-01-17 15:07 ` [PATCH 12/13] board: librem5: add Librem5 build files Angus Ainslie
2022-01-17 15:07 ` [PATCH 13/13] doc: librem5: add Librem5 documentation Angus Ainslie
2022-01-17 16:59 ` Tom Rini
2022-01-17 16:59 ` [PATCH 00/13] Add support for the Purism Librem5 Phone Tom Rini
2022-01-17 17:14 ` Angus Ainslie
2022-01-17 17:15 ` Angus Ainslie
2022-01-17 17:50 ` Tom Rini
2022-01-17 17:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117182513.GR2631111@bill-the-cat \
--to=trini@konsulko.com \
--cc=aford173@gmail.com \
--cc=angus@akkea.ca \
--cc=festevam@gmail.com \
--cc=iliev@ronetix.at \
--cc=jagan@amarulasolutions.com \
--cc=kernel@puri.sm \
--cc=marcel.ziswiler@toradex.com \
--cc=peng.fan@nxp.com \
--cc=sbabic@denx.de \
--cc=t.remmet@phytec.de \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox