From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 255E9C433F5 for ; Mon, 17 Jan 2022 18:25:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 635E782DA1; Mon, 17 Jan 2022 19:25:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="EZrJBlUl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D745C834A0; Mon, 17 Jan 2022 19:25:20 +0100 (CET) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9DF8082A71 for ; Mon, 17 Jan 2022 19:25:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id t1so4013429qvp.4 for ; Mon, 17 Jan 2022 10:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RAtDYnZdcCFdJd/U+Mqk0YFj5wHnZGe2nW6eWjNt6Y0=; b=EZrJBlUlDhGkfoRiCDNTyEmJvOys1kbJDs4w7W6/7AHGhtj+sdGQyu41QmQNNdeaW6 IEl7Ip2whbUcQ3cN8/IvEsDuXECRHZMdHvgIdpSiiTgZSUzktoxYrMWe9xRM7+ddei4c U1gQQkbxvKDOccEG2+sJHzySMpKuErTACRCzU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RAtDYnZdcCFdJd/U+Mqk0YFj5wHnZGe2nW6eWjNt6Y0=; b=S6JIOQnTox6z+kCnC9hakV+KUlGvoers2wiI7WFsvbFTAJ6FYIbXDoM/dMzVRn7dD3 IgmadS0Y09LSip7jjFqSvH3EJ0UrbwwiINYayTLoqk7Hy3XjiSDx15+4ktQy/al4w/2s tiPlJztmyIowkYaHz7yMUuG4EIpT1R6E+I6MFzREslt8AwlIiymWWSzyjltRrUyO2c6z ReSiFmv73neRO8FENib9vBRM9mrj3qCBpBopvQXtezyVUt7FqtzG0o8gAKtfUK5PWaRn 5yyanWj20G6hlExPuCp6i6Bhi7B9HH6YqT1uC8aVbmAEjC/l9GZo30WvW9PTV5OjivX/ ABWA== X-Gm-Message-State: AOAM5311wZuUAQjV3xWG2xj1S2hr4KyrwoxnWP+VujUOmbt7S/qpInLy jgAN/f0/jznaivqWRr06+Caf1Q== X-Google-Smtp-Source: ABdhPJzdYCKk9etwJVet4o4dn2oX4tV4I/opOTyzyYIbRyIaQyCZZT4bUAJkAgiPnIzlbXlq99+IFg== X-Received: by 2002:a05:6214:2b05:: with SMTP id jx5mr19452660qvb.124.1642443916194; Mon, 17 Jan 2022 10:25:16 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-8dc3-db57-8e4a-695a.res6.spectrum.com. [2603:6081:7b01:cbda:8dc3:db57:8e4a:695a]) by smtp.gmail.com with ESMTPSA id g20sm2988448qtb.49.2022.01.17.10.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 10:25:15 -0800 (PST) Date: Mon, 17 Jan 2022 13:25:13 -0500 From: Tom Rini To: Angus Ainslie Cc: "NXP i.MX U-Boot Team" , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Peng Fan , Marcel Ziswiler , Teresa Remmet , Adam Ford , Tim Harvey , Jagan Teki , Ilko Iliev , kernel@puri.sm Subject: Re: [PATCH 02/13] arm: dts: add the Purism devicetree files Message-ID: <20220117182513.GR2631111@bill-the-cat> References: <20220117150735.218886-1-angus@akkea.ca> <20220117150735.218886-3-angus@akkea.ca> <20220117165932.GL2631111@bill-the-cat> <3498b84cf21f803c0466927fdb83d9be@akkea.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9ToWwKEyhugL+MAz" Content-Disposition: inline In-Reply-To: <3498b84cf21f803c0466927fdb83d9be@akkea.ca> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --9ToWwKEyhugL+MAz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 17, 2022 at 09:51:24AM -0800, Angus Ainslie wrote: > Hi Tom, >=20 > On 2022-01-17 08:59, Tom Rini wrote: > > On Mon, Jan 17, 2022 at 07:07:24AM -0800, Angus Ainslie wrote: > >=20 > > > Initial commit of Librem5 devicetree files > > >=20 > > > Signed-off-by: Angus Ainslie > >=20 > > Please note what kernel release the not -u-boot.dtsi files are a copy > > from, as they need to be copies and not modified, thanks. >=20 > There's an issue with adding the devicetree from the 5.16 kernel. >=20 > I get a compilation error due to a :missing .h in the devicetree files: >=20 > In file included from arch/arm/dts/imx8mq-librem5-r3.dtsi:11, > from arch/arm/dts/.imx8mq-librem5.dtb.pre.tmp:6: > arch/arm/dts/imx8mq-librem5.dtsi:13:10: fatal error: > dt-bindings/rfkill/rfkill.h: No such file or directory > 13 | #include "dt-bindings/rfkill/rfkill.h" > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > Should that get added to the u-boot source as well or should I modify the > dts to remove this ? Import the missing binding(s) in a separate commit first please. > For the kernel we also have 4 different dts files for the differences in = PCB > versions. For u-boot we don't need the differentiation as it deals with > things like camera rotation and prox sensor sensitivity. >=20 > There's 2 ways to solve the this I think. >=20 > 1) just use the latest librem5 dts file which is made up of 3 different > dts(i) files. > 2) have a defconfig for each of the different PCB versions. >=20 > Do you have a preference ? Can you tell the revision at run-time? We have examples of boards that can and will include revA.dtb and revB.dtb and select the correct one at run time (and start with something that works on revA and revB). --=20 Tom --9ToWwKEyhugL+MAz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHltIYACgkQFHw5/5Y0 tyyaWwwAlqSsSTgvg4vzZIEkimmpxUFoqnEZ3nMVYBZxInibmm6Yp/hJFjgC5HfP oqy5+BVW7ftvmYCQmz9VJbrpF0EWbgSrYwAVcoVBVdXBG8OqD0/nnbB7TssoxG+s VbUycU7o9auAq0mzCBQtcmjKXpH92nTmh5fSgpMr3XXTAe/Ow6z2IApJI2gc5rf2 zZ9bKyt4nVjLDTXdnmwk1ChX29+koDukgj/W8kVv8Qmb7GYo+hR1nfzH//dHpdtV 5CnfDPPtEkggnPjKv6X6mUHk4mnypcMxrt1ggZKUsV9MnsJ+jks+wQZUBKGtlzXd sOQo6JGu65rQR6o368PE8x/IgJlYc0hjtCbhSYjra7IknR8F8/X0nhENwlTq3Q5L XSlG9Sj1wNbiAcFjBZzR4NOhuP/PkrKryuOwfhI//cE1DxUmQQninTRJeuNpJ/UQ KEoAgPVh5CS1Gbq1L9FVPNcV93zdmd0VR9DWobaTt5qAUiymyPLyl+Q1y11vuTrY FKXX8G08 =Ljht -----END PGP SIGNATURE----- --9ToWwKEyhugL+MAz--