Re: [PATCH 6/8] configs: am64x_evm: set eth1 as boot interface

Vignesh Raghavendra
2022-01-21T07:12:08Z

On 17/01/22 8:16 pm, Tom Rini wrote:
> On Fri, Dec 24, 2021 at 12:55:34PM +0530, Vignesh Raghavendra wrote:
>
>> ROM supports boot from CPSW second port, therefore set eth1 boot
>> interface
>>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> ---
>> include/configs/am64x_evm.h | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_evm.h
>> index 99624081c3..cd4b658e5f 100644
>> --- a/include/configs/am64x_evm.h
>> +++ b/include/configs/am64x_evm.h
>> @@ -33,7 +33,7 @@
>> * our memory footprint. The less we use for BSS the more we have available
>> * for everything else.
>> */
>> -#define CONFIG_SPL_BSS_MAX_SIZE 0x1000
>> +#define CONFIG_SPL_BSS_MAX_SIZE 0xa000
>> /*
>> * Link BSS to be within SPL in a dedicated region located near the top of
>> * the MCU SRAM, this way making it available also before relocation. Note
>> @@ -64,6 +64,7 @@
>> "if test $fdtfile = undefined; then " \
>> "echo WARNING: Could not determine device tree to use; fi; \0" \
>> "name_kern=Image\0" \
>> + "ethact=eth0\0" \

This is redundant, will drop.

>> "console=ttyS2,115200n8\0" \
>> "args_all=setenv optargs earlycon=ns16550a,mmio32,0x02800000 " \
>> "${mtdparts}\0" \
>> @@ -140,4 +141,6 @@
>>
>> #define CONFIG_SYS_USB_FAT_BOOT_PARTITION 1
>>
>> +#define CONFIG_SPL_ETH_DEVICE "eth1"
>> +
>> #endif /* __CONFIG_AM642_EVM_H */
>
> What's going on exactly here? First, CONFIG_SPL_ETH_DEVICE needs to be
> migrated to Kconfig now, if we're going to use it. But, it's used to
> set "ethact", which wouldd normally be eth0, but you're setting it to
> eth1 here and eth0 for U-Boot itself? Can you please explain the setup
> here? Thanks!
>

ROM supports boot from cpsw_port2 (eth1) and not cpsw_port1 (eth0),
hence I had to set CONFIG_SPL_ETH_DEVICE to eth1. Thinking a bit more,
it does not make sense to enable both ports in SPL as only eth1 is used
during ethboot. So CONFIG_SPL_ETH_DEVICE need not be touched if eth0 is
disabled for SPL.

Will update DT files accordingly.

Regards
Vignesh