From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD95CC433F5 for ; Tue, 18 Jan 2022 14:16:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 64A018384A; Tue, 18 Jan 2022 15:16:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="uCZGEIGi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D15468381D; Tue, 18 Jan 2022 15:16:45 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B7CD483856 for ; Tue, 18 Jan 2022 15:16:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7EA2A614B0; Tue, 18 Jan 2022 14:16:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB63C00446; Tue, 18 Jan 2022 14:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642515399; bh=zMz/zqRSinvk+gaWO7VeAbMEKC0ExFCJcRIbJipYwfk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uCZGEIGixiLWkSTtBhQXM8nCt+7P/lM3g3yRK4jYWu521BNS1BICU0sgauYPKbOMO zmdyFXeZZAYSHUCkEO8EWSUPwXHvKmMmQ7rQdvsnaEIxW5ki0/PRJAw8wcfokA8jxw 8uNcdRy6aQPO8mCPaEsgbY88oyolxTXvN30V42yb/P/ZTX26NpMR7QJBCIWA+TRIiB fNa3smNBwOL7HZKouBntKMP+wxfA/PF2P79HxS5ProPQsNaKizF69yP5cV5rDddzcF RFlDRcPfr3qfxugzqb6IBzdFJGCEVqEyz49sGfI3X9nCszMu8vNqKThDvdW0Ieg4s4 vgOidIsIo8OFg== Date: Tue, 18 Jan 2022 15:16:31 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese Cc: Simon Glass , Albert Aribaud , Tom Warren , Aaron Williams , Daniel Schwierzeck , York Sun , Priyanka Jain , Oliver Graute , Meenakshi Aggarwal , Wasim Khan , Joe Hershberger , Ramon Fried , Anatolij Gustschin , Neil Armstrong , Jagan Teki , Andre Przywara , Biwen Li , Chaitanya Sakinam , Anji J , Michael Walle , Marek =?UTF-8?B?QmVow7pu?= , Vladimir Oltean , Bin Meng , Hou Zhiqiang , Pali =?UTF-8?B?Um9ow6Fy?= , Igal Liberman , u-boot@lists.denx.de, u-boot-amlogic@groups.io Subject: Re: [PATCH u-boot-dm v2] fdt_support: Add fdt_for_each_node_by_compatible() helper macro Message-ID: <20220118151631.4e664bad@thinkpad> In-Reply-To: <8f86f3c1-4c99-cb16-9ae2-e3c00ac1ebd9@denx.de> References: <20220110104639.13744-1-kabel@kernel.org> <8f86f3c1-4c99-cb16-9ae2-e3c00ac1ebd9@denx.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 18 Jan 2022 14:28:17 +0100 Stefan Roese wrote: > Hi Marek, >=20 > On 1/10/22 11:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > >=20 > > Add macro fdt_for_each_node_by_compatible() to allow iterating over > > fdt nodes by compatible string. > >=20 > > Convert various usages of > > off =3D fdt_node_offset_by_compatible(fdt, start, compat); > > while (off > 0) { > > code(); > > off =3D fdt_node_offset_by_compatible(fdt, off, compat); > > } > > and similar, to > > fdt_for_each_node_by_compatible(off, fdt, start, compat) > > code(); > >=20 > > Signed-off-by: Marek Beh=C3=BAn > > Reviewed-by: Stefan Roese =20 >=20 > Apart from some merge issues, which I solved while appying, I'm seeing > multiple problems with world building in CI / Azure. For example: >=20 > $ make turris_mox_defconfig > $ make -s -j20 > drivers/phy/marvell/comphy_a3700.c: In function=20 > 'find_available_node_by_compatible': > drivers/phy/marvell/comphy_a3700.c:988:9: warning: implicit declaration=20 > of function 'fdt_for_each_node_by_compatible'; did you mean=20 > 'find_available_node_by_compatible'? [-Wimplicit-function-declaration] > 988 | fdt_for_each_node_by_compatible(offset, gd->fdt_blob,=20 > offset, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | find_available_node_by_compatible > drivers/phy/marvell/comphy_a3700.c:989:52: error: expected ';' before 'if' > 989 | compatible) > | ^ > | ; > 990 | if (fdtdec_get_is_enabled(gd->fdt_blob, offset)) > | ~~ > make[3]: *** [scripts/Makefile.build:254:=20 > drivers/phy/marvell/comphy_a3700.o] Error 1 > make[2]: *** [scripts/Makefile.build:394: drivers/phy/marvell] Error 2 > make[1]: *** [scripts/Makefile.build:394: drivers/phy] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1889: drivers] Error 2 > make: *** Waiting for unfinished jobs.... >=20 > Could you please take a look and re-submit once this passes a world > CI build? Or did I miss to apply some other patch before this one? I sent v3 where I fixed compilation for various targets. Seems that github's CI does not do all the tests anymore, and so didn't catch them, otherwise I don't know how this could have happend. There is one merge issue with Tom's master branch. I explained how to resolve it in v3 after commit text. Marek