From: Andy Chiu <andy.chiu@sifive.com>
To: monstr@monstr.eu
Cc: Andy Chiu <andy.chiu@sifive.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
u-boot@lists.denx.de
Subject: [PATCH 2/3] net: xilinx: Move setup of 1G MAC to a function
Date: Thu, 20 Jan 2022 15:34:19 +0800 [thread overview]
Message-ID: <20220120073420.1887809-2-andy.chiu@sifive.com> (raw)
In-Reply-To: <20220120073420.1887809-1-andy.chiu@sifive.com>
Separate the flow out so that it would be easiler to implement error
handling logic.
Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
---
drivers/net/xilinx_axi_emac.c | 50 +++++++++++++++++++++--------------
1 file changed, 30 insertions(+), 20 deletions(-)
diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
index 3117dae05e..dbda6c70d8 100644
--- a/drivers/net/xilinx_axi_emac.c
+++ b/drivers/net/xilinx_axi_emac.c
@@ -763,38 +763,48 @@ static int axiemac_miiphy_write(struct mii_dev *bus, int addr, int devad,
return phywrite(bus->priv, addr, reg, value);
}
-static int axi_emac_probe(struct udevice *dev)
+static int axiemac_setup_emac(struct udevice *dev)
{
struct axidma_plat *plat = dev_get_plat(dev);
struct eth_pdata *pdata = &plat->eth_pdata;
struct axidma_priv *priv = dev_get_priv(dev);
int ret;
+ priv->eth_hasnobuf = plat->eth_hasnobuf;
+ priv->phyaddr = plat->phyaddr;
+ priv->phy_of_handle = plat->phy_of_handle;
+ priv->interface = pdata->phy_interface;
+
+ priv->bus = mdio_alloc();
+ priv->bus->read = axiemac_miiphy_read;
+ priv->bus->write = axiemac_miiphy_write;
+ priv->bus->priv = priv;
+
+ ret = mdio_register_seq(priv->bus, dev_seq(dev));
+ if (ret)
+ return ret;
+
+ axiemac_phy_init(dev);
+
+ return ret;
+}
+
+static int axi_emac_probe(struct udevice *dev)
+{
+ struct axidma_plat *plat = dev_get_plat(dev);
+ struct eth_pdata *pdata = &plat->eth_pdata;
+ struct axidma_priv *priv = dev_get_priv(dev);
+
priv->iobase = (struct axi_regs *)pdata->iobase;
priv->dmatx = plat->dmatx;
/* RX channel offset is 0x30 */
priv->dmarx = (struct axidma_reg *)((phys_addr_t)priv->dmatx + 0x30);
priv->mactype = plat->mactype;
- if (priv->mactype == EMAC_1G) {
- priv->eth_hasnobuf = plat->eth_hasnobuf;
- priv->phyaddr = plat->phyaddr;
- priv->phy_of_handle = plat->phy_of_handle;
- priv->interface = pdata->phy_interface;
-
- priv->bus = mdio_alloc();
- priv->bus->read = axiemac_miiphy_read;
- priv->bus->write = axiemac_miiphy_write;
- priv->bus->priv = priv;
-
- ret = mdio_register_seq(priv->bus, dev_seq(dev));
- if (ret)
- return ret;
-
- axiemac_phy_init(dev);
- }
-
- return 0;
+ if (priv->mactype == EMAC_1G)
+ return axiemac_setup_emac(dev);
+ else
+ return 0;
}
static int axi_emac_remove(struct udevice *dev)
--
2.34.1
next prev parent reply other threads:[~2022-01-20 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 7:34 [PATCH 1/3] net: xilinx: fix load access fault Andy Chiu
2022-01-20 7:34 ` Andy Chiu [this message]
2022-01-20 7:34 ` [PATCH 3/3] net: xilinx: Force a probe failure if it cannot setup phy Andy Chiu
2022-02-09 13:33 ` Andy Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120073420.1887809-2-andy.chiu@sifive.com \
--to=andy.chiu@sifive.com \
--cc=joe.hershberger@ni.com \
--cc=monstr@monstr.eu \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox