From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35E3CC433EF for ; Thu, 20 Jan 2022 15:06:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9703B83888; Thu, 20 Jan 2022 16:06:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Hsml25qI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4B62883890; Thu, 20 Jan 2022 16:06:14 +0100 (CET) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 62AAB8385C for ; Thu, 20 Jan 2022 16:06:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id c190so6003448qkg.9 for ; Thu, 20 Jan 2022 07:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UDL3NoDSPlp9crUWpw2sGnBEqXYK85YUtVDtsOHKZjY=; b=Hsml25qISJjwjox4n4eTx0309HMlBczTct1OQuRjmQTPlftanX2Fbpm9wpVWmQeExh yGwB0LJW7YU5wn/qjqKk2Nj+ShbAtcjlFP96cEJh2kKptAAE/atoKoHDiF8q0ZlfTQKK Hv7GPZfYEkKJAoxWdZNdMOhKCB0rGPlR846i0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UDL3NoDSPlp9crUWpw2sGnBEqXYK85YUtVDtsOHKZjY=; b=njL7YdpXy9ZBv43WWCby2BHAFTviGR7uqVU9UKr5VXkaQ7jOO966HY9Aa/o0CMMQJ0 2y9MUi7IsFgKxaYtuVYcdAbd9xcVzBhRJumi/qDnY4xPfu/I/aanNXRcARJwcw+ZuaNb wH2f+t23/YU+5u0Pi6n7lrb1YByL1W3qI+k9N8dPQLAlzKXrlFxHpZZLt0lLIYjLb5kJ KPc5hkqNPF2pr23zBhV7yQDnQraoRmkgsb0d2kL5gZKv2eMAFKLSsfT6DBvwdU9mbjD0 K/Q9XIUG3hbssUzirTO7gf0uiTqiC3CxsGmaiSX5ptG6XMGPZfnJitOqnkHJG3uFsVjO 0x1Q== X-Gm-Message-State: AOAM531rx2VxGhpW8ZJAVJl/7SfsYl+jD5HgW5xtbjzg4FDm/0iX3zHE KateiGvNWfwoSICFuN/CTNSwhw== X-Google-Smtp-Source: ABdhPJz/Vgm0vJyCyrE4AJeBBMrsww29nl3LJnl5PldcHIn9FWo2xY7umsYZuQhXicujvxlvvoaaSQ== X-Received: by 2002:a05:620a:2902:: with SMTP id m2mr11007729qkp.209.1642691170000; Thu, 20 Jan 2022 07:06:10 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id w20sm1756980qkp.102.2022.01.20.07.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 07:06:09 -0800 (PST) Date: Thu, 20 Jan 2022 10:06:07 -0500 From: Tom Rini To: AKASHI Takahiro , Heinrich Schuchardt , ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, mark.kettenis@xs4all.nl, u-boot@lists.denx.de, agraf@csgraf.de, sjg@chromium.org Subject: Re: [PATCH v9 03/11] tools: build mkeficapsule with tools-only_defconfig Message-ID: <20220120150607.GF7004@bill-the-cat> References: <20220118043954.55940-1-takahiro.akashi@linaro.org> <20220118043954.55940-4-takahiro.akashi@linaro.org> <20220120013903.GA42867@laputa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DEueqSqTbz/jWVG1" Content-Disposition: inline In-Reply-To: <20220120013903.GA42867@laputa> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --DEueqSqTbz/jWVG1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 20, 2022 at 10:39:03AM +0900, AKASHI Takahiro wrote: > Heinrich, >=20 > On Wed, Jan 19, 2022 at 05:08:14PM +0100, Heinrich Schuchardt wrote: > > On 1/18/22 05:39, AKASHI Takahiro wrote: > > > Add CONFIG_TOOLS_MKEFICAPSULE. Then we want to always build mkeficaps= ule > > > if tools-only_defconfig is used. > > >=20 > > > Signed-off-by: AKASHI Takahiro > > > Reviewed-by: Simon Glass > > > --- > > > configs/tools-only_defconfig | 1 + > > > tools/Kconfig | 8 ++++++++ > > > tools/Makefile | 3 +-- > > > 3 files changed, 10 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defcon= fig > > > index f482c9a1c1b0..5427797dd4c3 100644 > > > --- a/configs/tools-only_defconfig > > > +++ b/configs/tools-only_defconfig > > > @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=3Dy > > > # CONFIG_VIRTIO_MMIO is not set > > > # CONFIG_VIRTIO_PCI is not set > > > # CONFIG_VIRTIO_SANDBOX is not set > > > +CONFIG_TOOLS_MKEFICAPSULE=3Dy > > > diff --git a/tools/Kconfig b/tools/Kconfig > > > index 91ce8ae3e516..117c921da3fe 100644 > > > --- a/tools/Kconfig > > > +++ b/tools/Kconfig > > > @@ -90,4 +90,12 @@ config TOOLS_SHA512 > > > help > > > Enable SHA512 support in the tools builds > > >=20 > > > +config TOOLS_MKEFICAPSULE > > > + bool "Build efimkcapsule command" > > > + default y if EFI_CAPSULE_ON_DISK > >=20 > > We discussed this with Tom before. Building of tools should not depend > > on board options. Can we make this 'default y'? >=20 > No. > I think we have different opinions here. >=20 > I think that any of *board* configs should build only all the binaries > that are need to run U-Boot on that board. > For distros' case that you have mentioned before, we should > encourage them to use tools-only_defconfig for packaging U-Boot > host tools rather than using any particular *board* config. >=20 > # In either case, the resulting binary, as far as mkeficapsule is > concerned, is the exact same without any dependency of target configs. For "mkimage" we go very very far in the direction of "this tool needs to be the same for all boards" because so many times not doing so has come back to be a problem for users and developers and distros. This is adding a new tool, yes? We have many examples of only building a tool given a CONFIG option, and so long as the tool itself doesn't change based on CONFIG options, that's fine. tools-only_defconfig needs to enable this, and is enabling this. --=20 Tom --DEueqSqTbz/jWVG1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHpelsACgkQFHw5/5Y0 tyxQLAv8Dg//HtYKYhCzOmMnit4Q0LY6z4fEvyvx/UvB1t5GHvLJUNSjscrSt+ik dr90wwE7K1hD59J7Mu2ZsELpInvnDJRu2y94d4nkjgbq/1Lxgv475U5cvMr3mW4j tHE3c2L2yKQAC4CwarMM20M74WpiRG0GZoav77gr2ysEM40acDIsUpPCUXPgFpUx kO+cjXd2k178tMuF358YPIEk8c0ljVANItOpbLW40o5XQaPGfMB2SmgteeqNkkXp 01i+KJuYPxKyhrQaW9DsRl8PHAlIfL/nzZHtxUfO5gnudyiKWblVWVcJhuoOYiCt qXhkXG3AaAe8IMaxRnQ4PlUUSJVXQFr7ikNeFPEQVQjxEqGaFqimqUskv+RcuZvf /365AHNn5Br0wjU8ogJpXBxy+VzF9XNybsUOOCspSn9IoP/qaTE28s5xZS2rik+F cehRsV3dumIJzXnFtorChzIR0AsfBkooTo+7Sx82/MwN5aJFC4CZcFl4Dt1771oe o6/gKxAd =GeF/ -----END PGP SIGNATURE----- --DEueqSqTbz/jWVG1--