From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 258A1C433EF for ; Thu, 20 Jan 2022 18:13:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CBF1B83858; Thu, 20 Jan 2022 19:12:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RKsE0jBP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF87183864; Thu, 20 Jan 2022 19:12:56 +0100 (CET) Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EEEBE83852 for ; Thu, 20 Jan 2022 19:12:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=macroalpha82@gmail.com Received: by mail-oo1-xc2c.google.com with SMTP id v10-20020a4a860a000000b002ddc59f8900so2559015ooh.7 for ; Thu, 20 Jan 2022 10:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PG2KCk4W6eY5QOBsK0g/qRc/sEqA2XZH9mnwkJlntaU=; b=RKsE0jBPNhp2/szcL9n4zWcsgyouPbNdV3tmxnmPXNea+NxiZrlMe8etdYFKX4l0O7 AwFt5bS7EEIa6ozSCA+PrAT8nAVfBnphHbBtSHBgFBd+GXle+d+T6nQsbQDK0M8qmk9d G/WA8AppJyLRFr4bnb+WQEoAYjn70mS1W4Jer4/zy8flkpreV+U0ID/BoXL5nj7/aNlr 7ag3apIH241w7+kg45hP7xDxFZz73vyO1CJRN2XQCeCbgpxPRMq/jk/geWZ7bOVisaBf pxW8G+Ka4kvNCdOUbkvsClC/8MIaVSSsz9hbKKnO3kKoN7fFGPSl/+ytDeKBFrNzVYDn 2gFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PG2KCk4W6eY5QOBsK0g/qRc/sEqA2XZH9mnwkJlntaU=; b=WsPW7LwasIJFVJYEjODcrYdATYE4TkRXgySl9My4prJtgU1DfQ2GN7P7lzm8aSvQop P7rJd4HKIz9wxrpJ60nux8yw/aGgfqzkWGKmi5ueBULCuQ/RJSagIKW+FwNDB0K5A5KB J3rVEoDwCUq4FvdVatVEgfbeLM4/cuoyEfpIJYbVlTUjlze/4+AdmaEzB7OfV80CmW5F ESZAMyiHX+cZBixrDJ4Kf3f1Oq18aD0cGopHfjH3IhLGk81savsgjOPkqCqSDfSPKF3l k57N6TRk8TVvIIZzct0EyBWeyoh1/sjsFZPO/VogeS8nL53hmp3Gxw2/eVGbq/HL+Dep 24Dw== X-Gm-Message-State: AOAM533xbbzEKCFPUW2NH7SL/4B2TN6s6iWjXxkWVSU1jODGnn5q2Jy/ YHwSBa7l75FIHKGtfUQHVlU= X-Google-Smtp-Source: ABdhPJygjDBIjAGG8Nf/tQAuBIb3+39oEQhu2SmRnfp27nnociJQX7mavWWHiB6p5O69h1OZDtFESw== X-Received: by 2002:a05:6820:1609:: with SMTP id bb9mr91749oob.30.1642702372253; Thu, 20 Jan 2022 10:12:52 -0800 (PST) Received: from wintermute.localdomain (cpe-76-183-134-35.tx.res.rr.com. [76.183.134.35]) by smtp.gmail.com with ESMTPSA id az2sm2111313oib.35.2022.01.20.10.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 10:12:51 -0800 (PST) Date: Thu, 20 Jan 2022 12:12:49 -0600 From: Chris Morgan To: Jesse Taube Cc: Tnze Jdao , "u-boot@lists.denx.de" , "giulio.benetti@benettiengineering.com" Subject: Re: [PATCH 00/11] Add support for SUNIV and F1C100s. Message-ID: <20220120181249.GA32@wintermute.localdomain> References: <9ea3dfed-515e-4e60-189f-4e965a2d8e6e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ea3dfed-515e-4e60-189f-4e965a2d8e6e@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Jan 15, 2022 at 04:02:05PM -0500, Jesse Taube wrote: > > > On 1/10/22 00:13, Tnze Jdao wrote: > > I tested this patch and tried to run it on my LicheePi Nano. It works, but I found there is WARNINGs when compile the code: > > ------- > > include/configs/sunxi-common.h:128:0: warning: "CONFIG_ENV_SECT_SIZE" redefined > > #define CONFIG_ENV_SECT_SIZE 0x1000 > Ah I will move this it should be moved to defconfig thx for pointing this > out. > > > > In file included from ././include/linux/kconfig.h:4:0, > > from :0: > > include/generated/autoconf.h:296:0: note: this is the location of the previous definition > > #define CONFIG_ENV_SECT_SIZE 0x1 > Not entirely sure how it got defined here, it doesn't get defined in my > generated config. > > > > In file included from include/configs/suniv.h:12:0, > > from include/config.h:4, > > from include/common.h:16, > > from lib/slre.c:24: > > -------- > > And I think the problem is the CONFIG_ENV_SECT_SIZE should be (and required to) defined in the config file rather than at include/configs/sunxi-common.h:128 > > Im sorry for the late reply the email got lost. I have tested the patch on master (pulled 2022-01-20). licheepi_nano_defconfig compiles and builds just fine for me, and I am able to run it on the device without incident via FEL mode. licheepi_nano_spiflash_defconfig however gives me multiple warnings, and when the warnings are addressed it boots but gives me errors regarding the SPI controller in U-Boot. "make licheepi_nano_spiflash_defconfig" warning: WARNING: unmet direct dependencies detected for SPI_MEM Depends on [n]: SPI [=n] Selected by [y]: - SPI_FLASH [=y] When I specify CONFIG_SPI=y I get the following when I try to compile: Environment Sector-Size (ENV_SECT_SIZE) [] (NEW) When I provide a value of 0x1000 which corresponds to the block size of the SPI chip I use I then get the following warnings repeated and it fails to compile: include/configs/sunxi-common.h:60: warning: "CONFIG_SYS_LOAD_ADDR" redefined When I work through the remaining errors and get it to compile, I get this error in U-Boot when attempting to use the SPI controller: sun4i_spi spi@1c05000: failed to get ahb clock I presume the issue is that the defconfig is both incomplete for the SPI booting method and the SUN6I_SPI which is specified in the SPI defconfig is not in mainline yet. Until the SPI driver is present it's probably best to just drop the licheepi_nano_spiflash_defconfig. Tested-By: Chris Morgan