From: Tom Rini <trini@konsulko.com>
To: Ramon Fried <rfried.dev@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Dave Gerlach <d-gerlach@ti.com>,
Joe Hershberger <joe.hershberger@ni.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode
Date: Thu, 20 Jan 2022 18:19:45 -0500 [thread overview]
Message-ID: <20220120231945.GN7004@bill-the-cat> (raw)
In-Reply-To: <CAGi-RUKJB60Y7_B_5_BaZWpYXujhGHkWQKZyeyMRakA_shSzow@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Fri, Jan 21, 2022 at 01:13:54AM +0200, Ramon Fried wrote:
> On Mon, Jan 17, 2022 at 8:37 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Dec 24, 2021 at 12:55:30PM +0530, Vignesh Raghavendra wrote:
> >
> > > On certain TI SoC, like AM64x there is a CPSW3G which supports 2
> > > external independent MAC ports for single CPSW instance.
> > > It is not possible for Ethernet driver to register more than one port
> > > for given instance.
> > >
> > > This patch modifies top level CPSW NUSS as UCLASS_MISC and binds
> > > UCLASS_ETH to individual ports so as to support bring up more than one
> > > Ethernet interface in U-Boot.
> > >
> > > Note that there is no isolation in the since, CPSW NUSS is in promisc
> > > mode and forwards all packets to host.
> > >
> > > Since top level driver is now UCLASS_MISC, board files would need to
> > > instantiate this driver explicitly.
> > >
> > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> >
> > Applied to u-boot/master, thanks!
> why ? comments were not addressed.
I missed that you had comments, sorry. Shall I revert this one for now?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-01-20 23:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 7:25 [PATCH 0/8] ARM: ti: AM64x: Add Ethernet boot support on AM64x SK Vignesh Raghavendra
2021-12-24 7:25 ` [PATCH 1/8] mach-k3: common: Instantiate AM65 CPSW NUSS wrapper Vignesh Raghavendra
2022-01-17 18:36 ` Tom Rini
2021-12-24 7:25 ` [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode Vignesh Raghavendra
2021-12-29 19:31 ` Ramon Fried
2022-01-21 4:18 ` Vignesh Raghavendra
2022-01-17 18:37 ` Tom Rini
2022-01-20 23:13 ` Ramon Fried
2022-01-20 23:19 ` Tom Rini [this message]
2022-01-21 4:32 ` Vignesh Raghavendra
2021-12-24 7:25 ` [PATCH 3/8] board: ti: am64x: Init DRAM size in R5/A53 SPL Vignesh Raghavendra
2022-01-17 18:37 ` Tom Rini
2021-12-24 7:25 ` [PATCH 4/8] mach-k3: am642_init: Probe AM65 CPSW NUSS for " Vignesh Raghavendra
2022-01-17 18:37 ` Tom Rini
2021-12-24 7:25 ` [PATCH 5/8] mach-k3: am64_spl: Alias Ethernet RGMII boot to CPGMAC Vignesh Raghavendra
2022-01-17 18:37 ` Tom Rini
2021-12-24 7:25 ` [PATCH 6/8] configs: am64x_evm: set eth1 as boot interface Vignesh Raghavendra
2022-01-17 14:46 ` Tom Rini
2022-01-21 7:11 ` Vignesh Raghavendra
2021-12-24 7:25 ` [PATCH 7/8] ARM: dts: K3-am642-r5-sk: Enable Second CPSW port in R5/A53 SPL Vignesh Raghavendra
2022-01-17 18:37 ` Tom Rini
2021-12-24 7:25 ` [PATCH 8/8] configs: am64x_evm_r5/a53_defconfig: Enable configs required for Ethboot Vignesh Raghavendra
2022-01-17 14:47 ` Tom Rini
2022-01-21 4:29 ` Vignesh Raghavendra
2022-01-21 14:57 ` Tom Rini
2022-01-21 15:18 ` Vignesh Raghavendra
2022-01-21 15:21 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120231945.GN7004@bill-the-cat \
--to=trini@konsulko.com \
--cc=d-gerlach@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox